Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/regtest/completion: TestDefinitionReplaceRange failures #60902

Closed
gopherbot opened this issue Jun 20, 2023 · 2 comments
Closed

x/tools/gopls/internal/regtest/completion: TestDefinitionReplaceRange failures #60902

gopherbot opened this issue Jun 20, 2023 · 2 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/completion" && test == "TestDefinitionReplaceRange"

Issue created automatically to collect these failures.

Example (log):

panic: test timed out after 10m0s

testing.(*T).Run(0xc001ff89c0, {0x100b88a1d?, 0x100ba58cc?}, 0xc000129400)
	/tmp/buildlet/go/src/testing/testing.go:1494 +0x37a
golang.org/x/tools/gopls/internal/lsp/regtest.(*Runner).Run(0xc000263220, 0xc001ff89c0, {0x100bce2b2, 0x26}, 0xc003bcd440, {0x0, 0x0, 0x6491fab4?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/runner.go:169 +0x4e5
golang.org/x/tools/gopls/internal/lsp/regtest.Run(...)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/regtest.go:54
golang.org/x/tools/gopls/internal/regtest/completion.TestDefinitionReplaceRange(0xc0011b2340?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/regtest/completion/completion_test.go:795 +0x167
testing.tRunner(0xc001ff89c0, 0x100d04e08)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 20, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/completion" && test == "TestDefinitionReplaceRange"
2023-06-20 19:04 darwin-amd64-10_15 tools@b71392af go@f394cd77 x/tools/gopls/internal/regtest/completion.TestDefinitionReplaceRange (log) 
panic: test timed out after 10m0s

testing.(*T).Run(0xc001ff89c0, {0x100b88a1d?, 0x100ba58cc?}, 0xc000129400)
	/tmp/buildlet/go/src/testing/testing.go:1494 +0x37a
golang.org/x/tools/gopls/internal/lsp/regtest.(*Runner).Run(0xc000263220, 0xc001ff89c0, {0x100bce2b2, 0x26}, 0xc003bcd440, {0x0, 0x0, 0x6491fab4?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/runner.go:169 +0x4e5
golang.org/x/tools/gopls/internal/lsp/regtest.Run(...)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/regtest.go:54
golang.org/x/tools/gopls/internal/regtest/completion.TestDefinitionReplaceRange(0xc0011b2340?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/regtest/completion/completion_test.go:795 +0x167
testing.tRunner(0xc001ff89c0, 0x100d04e08)

— watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jun 20, 2023
@gopherbot gopherbot added this to the Unreleased milestone Jun 20, 2023
@findleyr
Copy link
Contributor

Looks like Yet Another Hanging Go command.

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: Done
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@gopherbot @findleyr