Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: TestMemPprof failures #60901

Open
gopherbot opened this issue Jun 20, 2023 · 7 comments
Open

runtime: TestMemPprof failures #60901

gopherbot opened this issue Jun 20, 2023 · 7 comments
Assignees
@cherrymui
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
Backlog

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "runtime" && test == "TestMemPprof"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestMemPprof (0.01s)
    crash_test.go:537: signal: trace/breakpoint trap (core dumped)

— watchflakes
@gopherbot gopherbot added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. compiler/runtime Issues related to the Go compiler and/or runtime. labels Jun 20, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime" && test == "TestMemPprof"
2023-06-20 18:25 linux-amd64-longtest go@8484f2fe runtime.TestMemPprof (log) 
--- FAIL: TestMemPprof (0.01s)
    crash_test.go:537: signal: trace/breakpoint trap (core dumped)

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented Jun 20, 2023

See also #57149.

@mknyszek
Copy link
Contributor

mknyszek commented Jul 5, 2023

This is notably in the maymorestack=mayMoreStackMove section (#57149 also is, but mentioning it explicitly).

@mknyszek
Copy link
Contributor

mknyszek commented Jul 5, 2023

In triage, it's very weird that we got a SIGTRAP here. Timeout should be sending a SIGQUIT (or a SIGKILL if SIGQUIT is blocked). If we collected core dumps from builders, this would be a bit easier to figure out. (#49165)

@mknyszek mknyszek added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Jul 5, 2023
@mknyszek mknyszek added this to the Backlog milestone Jul 5, 2023
@mknyszek
Copy link
Contributor

mknyszek commented Jul 5, 2023

@prattmic suggests that maybe we jumped to the wrong address, because we pad functions with int $3.

@mknyszek
Copy link
Contributor

mknyszek commented Jul 5, 2023

To get more information, Cherry is going to change the test runner in this case to actually dump whatever the subprocess that failed here wrote to stdout/stderr. Right now we have very little to go on.

@gopherbot
Copy link
Author

Change https://go.dev/cl/507978 mentions this issue: runtime: print output on failure in TestMemPprof

gopherbot pushed a commit that referenced this issue Jul 6, 2023
@cherrymui
runtime: print output on failure in TestMemPprof
e6ec2a3 
If running testprog fails, print the output.

For #60901.

Change-Id: Iee80fb09412ce13bae6ac3589779a8cdf7761765
Reviewed-on: https://go-review.googlesource.com/c/go/+/507978
Reviewed-by: Michael Pratt <mpratt@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Cherry Mui <cherryyz@google.com>
bradfitz pushed a commit to tailscale/go that referenced this issue Jul 15, 2023
@cherrymui @bradfitz
runtime: print output on failure in TestMemPprof
867865c 
If running testprog fails, print the output.

For golang#60901.

Change-Id: Iee80fb09412ce13bae6ac3589779a8cdf7761765
Reviewed-on: https://go-review.googlesource.com/c/go/+/507978
Reviewed-by: Michael Pratt <mpratt@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Cherry Mui <cherryyz@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cherrymui cherrymui

Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
Go Compiler / Runtime
Status: No status
Test Flakes
Status: No status
Milestone
Backlog
Development

No branches or pull requests
4 participants
@mknyszek @bcmills @gopherbot @cherrymui