Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/internal/task/releaselet: Windows installer for Go 1.21 and newer displays time stamp as part of Go version #60886

Closed
dmitshur opened this issue Jun 20, 2023 · 1 comment
Assignees
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Windows
Milestone

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Jun 20, 2023

The VERSION file historically contained nothing but the Go version string, and there was no difference in behavior between reading just its first line or the entire file. The Windows installer currently picks the former, and since the VERSION file is extended to include additional metadata as of Go 1.21, it ends up displaying the time stamp as part of the version too:

Screenshot 2023-06-17 094715

What it should look like instead

Screenshot 2023-06-21 003423

CC @golang/release.

@dmitshur dmitshur added OS-Windows NeedsFix The path to resolution is known, but the work has not been done. labels Jun 20, 2023
@dmitshur dmitshur added this to the Go1.21 milestone Jun 20, 2023
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jun 20, 2023
@dmitshur dmitshur moved this to In Progress in Go Release Jun 20, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/504517 mentions this issue: internal/task/releaselet: discard metadata in VERSION file

@dmitshur dmitshur self-assigned this Jun 22, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Go Release Jun 22, 2023
@golang golang locked and limited conversation to collaborators Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Windows
Projects
Archived in project
Development

No branches or pull requests

2 participants