Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/mail: mail.ReadMessage in 1.20 cannot parse mbox headers [1.20 backport] #60874

Closed
gopherbot opened this issue Jun 19, 2023 · 2 comments
Closed

net/mail: mail.ReadMessage in 1.20 cannot parse mbox headers [1.20 backport] #60874

gopherbot opened this issue Jun 19, 2023 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases
Milestone
Go1.20.6

Comments

@gopherbot
Copy link

@ianlancetaylor requested issue #60332 to be considered for backport to the next 1.20 minor release.

@gopherbot Please open backport to 1.20.

This stopped working due to the changes in #53188, but those changes don't apply to net/mail.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jun 19, 2023
@gopherbot gopherbot mentioned this issue Jun 19, 2023
Closed
@gopherbot gopherbot added this to the Go1.20.6 milestone Jun 19, 2023
@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Jun 21, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/504881 mentions this issue: [release-branch.go1.20] net/mail: permit more characters in mail headers

gopherbot pushed a commit that referenced this issue Jun 21, 2023
@ianlancetaylor
[release-branch.go1.20] net/mail: permit more characters in mail headers
b59efe6 
We parse mail messages using net/textproto. For #53188, we tightened
up the bytes permitted by net/textproto to match RFC 7230.
However, this package uses RFC 5322 which is more permissive.
Restore the permisiveness we used to have, so that older code
continues to work.

For #58862
For #60332
Fixes #60874
Fixes #60875

Change-Id: I5437f5e18a756f6ca61c13c4d8ba727be73eff9a
Reviewed-on: https://go-review.googlesource.com/c/go/+/504881
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
@gopherbot
Copy link
Author

Closed by merging b59efe6 to release-branch.go1.20.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases
Projects
None yet
Milestone
Go1.20.6
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot