Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: enable LocalMode #60872

Closed
amine7536 opened this issue Jun 19, 2023 · 4 comments
Closed

x/pkgsite: enable LocalMode #60872

amine7536 opened this issue Jun 19, 2023 · 4 comments
Labels
pkgsite
Milestone
pkgsite/backlog

Comments

@amine7536
Copy link

What is the URL of the page with the issue?

Self-Hosted

What is your user agent?

Any

What did you do?

Launch cmd/frontend/main.go, navigate to localhost:8080.

The site shows the same frontend as the public site pkg.go.dev with links to go.dev, blogs ...

What did you expect to see?

Run the frontend in "LocalMode" (same as pkgsite).

Screenshot 2023-06-19 at 20 10 00

Proposal

When running pkgsite locally, it runs by default in LocalMode, which hides items in the header and removes the footer completely. Running the frontend in LocalMode is particularly beneficial for those who wish to run the frontend locally or self-host documentation for their internal packages.
@gopherbot gopherbot added this to the Unreleased milestone Jun 19, 2023
@amine7536
Copy link
Author

I can work on enabling LocalMode for the frontend :)

@amine7536 amine7536 mentioned this issue Jun 19, 2023
Closed
@amine7536
Copy link
Author

golang/pkgsite#66

@findleyr
Copy link
Contributor

Thanks! Makes sense to me. We'll review.

@findleyr findleyr modified the milestones: Unreleased, pkgsite/later Jun 21, 2023
@gopherbot
Copy link

Change https://go.dev/cl/504336 mentions this issue: cmd/frontend: add -local flag to run frontend in LocalMode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pkgsite
Projects
None yet
Milestone
pkgsite/backlog
Development

Successfully merging a pull request may close this issue.

cmd/frontend: add -local flag to run frontend in LocalMode amine7536/pkgsite
3 participants
@amine7536 @gopherbot @findleyr