Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/internal/relui/sign: TestUpdateSigningStatusError failures #60854

Closed
gopherbot opened this issue Jun 17, 2023 · 2 comments
Closed

x/build/internal/relui/sign: TestUpdateSigningStatusError failures #60854

gopherbot opened this issue Jun 17, 2023 · 2 comments
Assignees
@dmitshur
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unreleased

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "golang.org/x/build/internal/relui/sign" && test == "TestUpdateSigningStatusError"

Issue created automatically to collect these failures.

Example (log):

2023/06/16 22:55:10 SigningServer: a client connected (iap = &{Email:accounts.google.com:example@gmail.com ID:accounts.google.com:randomuuidstuff})
2023/06/16 22:55:10 SigningServer: successfully round-tripped message="afbffb3c-2e98-4bf4-8cd8-3c234399cdb5" in 6.464134ms:
  req = message_id:"afbffb3c-2e98-4bf4-8cd8-3c234399cdb5"  sign:{build_type:BUILD_TYPE_MACOS  gcs_uri:"gs://foo/bar.tar.gz"}
  resp = message_id:"afbffb3c-2e98-4bf4-8cd8-3c234399cdb5"  started:{job_id:"55d5ad23-419a-4e9f-a499-cd5eecbbd745"}
2023/06/16 22:55:10 SigningServer: successfully round-tripped message="a06ba776-ec2b-40e4-943e-fae903727696" in 6.700842ms:
  req = message_id:"a06ba776-ec2b-40e4-943e-fae903727696"  sign:{build_type:BUILD_TYPE_WINDOWS  gcs_uri:"gs://foo/bar.tar.gz"}
  resp = message_id:"a06ba776-ec2b-40e4-943e-fae903727696"  started:{job_id:"e1294960-45ca-4ea0-b6fa-c309e3916933"}
2023/06/16 22:55:10 SigningServer: successfully round-tripped message="e2451be2-079c-4f08-bcf7-0f249f97f0fa" in 6.624819ms:
  req = message_id:"e2451be2-079c-4f08-bcf7-0f249f97f0fa"  sign:{build_type:BUILD_TYPE_GPG  gcs_uri:"gs://foo/bar.tar.gz"}
  resp = message_id:"e2451be2-079c-4f08-bcf7-0f249f97f0fa"  started:{job_id:"a52f4365-7031-4699-9b75-349bb668d797"}
...
2023/06/16 22:55:10 SigningServer: successfully round-tripped message="6c6f62ff-53fa-436d-a00d-43157949ac24" in 4.183783ms:
  req = message_id:"6c6f62ff-53fa-436d-a00d-43157949ac24"  status:{job_id:"a52f4365-7031-4699-9b75-349bb668d797"}
  resp = message_id:"6c6f62ff-53fa-436d-a00d-43157949ac24"  completed:{gcs_uri:"gs://private-bucket/some-file.tar.gz"}
2023/06/16 22:55:10 SigningServer: successfully round-tripped message="4e176497-43c0-47b1-bba2-5f186d53a01d" in 4.172125ms:
  req = message_id:"4e176497-43c0-47b1-bba2-5f186d53a01d"  status:{job_id:"55d5ad23-419a-4e9f-a499-cd5eecbbd745"}
  resp = message_id:"4e176497-43c0-47b1-bba2-5f186d53a01d"  completed:{gcs_uri:"gs://private-bucket/some-file.tar.gz"}
2023/06/16 22:55:10 SigningServer: a client disconnected after 16.672037ms (err = rpc error: code = Canceled desc = context canceled)
--- FAIL: TestUpdateSigningStatusError (1.00s)
    --- FAIL: TestUpdateSigningStatusError/unauthenticated_client (1.00s)
        server_test.go:170: grpc.Dial(127.0.0.1:49411, [0xc000394108 0xc000394110]) = nil, context deadline exceeded; want no error

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 17, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/build/internal/relui/sign" && test == "TestUpdateSigningStatusError"
2023-06-16 15:34 darwin-amd64-12_0 build@7234808b go@4eceefa3 x/build/internal/relui/sign.TestUpdateSigningStatusError (log) 
2023/06/16 22:55:10 SigningServer: a client connected (iap = &{Email:accounts.google.com:example@gmail.com ID:accounts.google.com:randomuuidstuff})
2023/06/16 22:55:10 SigningServer: successfully round-tripped message="afbffb3c-2e98-4bf4-8cd8-3c234399cdb5" in 6.464134ms:
  req = message_id:"afbffb3c-2e98-4bf4-8cd8-3c234399cdb5"  sign:{build_type:BUILD_TYPE_MACOS  gcs_uri:"gs://foo/bar.tar.gz"}
  resp = message_id:"afbffb3c-2e98-4bf4-8cd8-3c234399cdb5"  started:{job_id:"55d5ad23-419a-4e9f-a499-cd5eecbbd745"}
2023/06/16 22:55:10 SigningServer: successfully round-tripped message="a06ba776-ec2b-40e4-943e-fae903727696" in 6.700842ms:
  req = message_id:"a06ba776-ec2b-40e4-943e-fae903727696"  sign:{build_type:BUILD_TYPE_WINDOWS  gcs_uri:"gs://foo/bar.tar.gz"}
  resp = message_id:"a06ba776-ec2b-40e4-943e-fae903727696"  started:{job_id:"e1294960-45ca-4ea0-b6fa-c309e3916933"}
2023/06/16 22:55:10 SigningServer: successfully round-tripped message="e2451be2-079c-4f08-bcf7-0f249f97f0fa" in 6.624819ms:
  req = message_id:"e2451be2-079c-4f08-bcf7-0f249f97f0fa"  sign:{build_type:BUILD_TYPE_GPG  gcs_uri:"gs://foo/bar.tar.gz"}
  resp = message_id:"e2451be2-079c-4f08-bcf7-0f249f97f0fa"  started:{job_id:"a52f4365-7031-4699-9b75-349bb668d797"}
...
2023/06/16 22:55:10 SigningServer: successfully round-tripped message="6c6f62ff-53fa-436d-a00d-43157949ac24" in 4.183783ms:
  req = message_id:"6c6f62ff-53fa-436d-a00d-43157949ac24"  status:{job_id:"a52f4365-7031-4699-9b75-349bb668d797"}
  resp = message_id:"6c6f62ff-53fa-436d-a00d-43157949ac24"  completed:{gcs_uri:"gs://private-bucket/some-file.tar.gz"}
2023/06/16 22:55:10 SigningServer: successfully round-tripped message="4e176497-43c0-47b1-bba2-5f186d53a01d" in 4.172125ms:
  req = message_id:"4e176497-43c0-47b1-bba2-5f186d53a01d"  status:{job_id:"55d5ad23-419a-4e9f-a499-cd5eecbbd745"}
  resp = message_id:"4e176497-43c0-47b1-bba2-5f186d53a01d"  completed:{gcs_uri:"gs://private-bucket/some-file.tar.gz"}
2023/06/16 22:55:10 SigningServer: a client disconnected after 16.672037ms (err = rpc error: code = Canceled desc = context canceled)
--- FAIL: TestUpdateSigningStatusError (1.00s)
    --- FAIL: TestUpdateSigningStatusError/unauthenticated_client (1.00s)
        server_test.go:170: grpc.Dial(127.0.0.1:49411, [0xc000394108 0xc000394110]) = nil, context deadline exceeded; want no error

— watchflakes

@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jun 17, 2023
@gopherbot gopherbot added this to the Unreleased milestone Jun 17, 2023
@dmitshur dmitshur self-assigned this Jun 17, 2023
@dmitshur dmitshur added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jun 17, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/504495 mentions this issue: internal/relui/sign: delete constant timeouts to deflake tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmitshur dmitshur

Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Go Release
Archived in project
Test Flakes
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot