Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/dist: distpack-generated module files can't be downloaded with go mod download #60847

Closed
heschi opened this issue Jun 16, 2023 · 4 comments
Closed

cmd/dist: distpack-generated module files can't be downloaded with go mod download #60847

heschi opened this issue Jun 16, 2023 · 4 comments
Assignees
@rsc
Labels
NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.21

Comments

@heschi
Copy link
Contributor

heschi commented Jun 16, 2023

While trying to release 1.21rc1 we hit this error from proxy.golang.org:

not found: unzip /tmp/gopath/pkg/mod/cache/download/golang.org/toolchain/@v/v0.0.1-go1.21rc1.linux-amd64.zip: golang.org/toolchain@v0.0.1-go1.21rc1.linux-amd64/src/cmd/go.mod: go.mod file not in module root directory
golang.org/toolchain@v0.0.1-go1.21rc1.linux-amd64/src/cmd/objdump/testdata/testfilenum/go.mod: go.mod file not in module root directory
golang.org/toolchain@v0.0.1-go1.21rc1.linux-amd64/src/crypto/internal/bigmod/_asm/go.mod: go.mod file not in module root directory
golang.org/toolchain@v0.0.1-go1.21rc1.linux-amd64/src/crypto/internal/edwards25519/field/_asm/go.mod: go.mod file not in module root directory
golang.org/toolchain@v0.0.1-go1.21rc1.linux-amd64/src/go.mod: go.mod file not in module root directory

dl2mod renamed go.mod files, but distpack doesn't.

cc @rsc
@heschi heschi added NeedsFix The path to resolution is known, but the work has not been done. release-blocker labels Jun 16, 2023
@heschi heschi added this to the Go1.21 milestone Jun 16, 2023
@rsc rsc self-assigned this Jun 16, 2023
@gopherbot
Copy link

Change https://go.dev/cl/503978 mentions this issue: cmd/go: disable sumdb less often for toolchain downloads

@gopherbot
Copy link

Change https://go.dev/cl/503979 mentions this issue: cmd/distpack: rename go.mod to _go.mod in toolchain modules

@gopherbot
Copy link

Change https://go.dev/cl/504529 mentions this issue: internal/relui: add check that toolchain module works via GOTOOLCHAIN

@gopherbot
Copy link

Change https://go.dev/cl/504528 mentions this issue: internal/relui: skip waiting on proxy for Go 1.21 RC 1

gopherbot pushed a commit that referenced this issue Jun 20, 2023
@rsc @gopherbot
cmd/go: disable sumdb less often for toolchain downloads
6459494 
There is a chicken and egg problem with always requiring
the checksum database for toolchain module downloads, since the
checksum database populates its entry by doing its own module
download.

Don't require the checksum database for GOPROXY=file:/// (for local testing)
and when running on the Go module mirror.

For #60847.

Change-Id: I5d67d585169ae0fa73109df233baae8ba5fe5dd3
Reviewed-on: https://go-review.googlesource.com/c/go/+/503978
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
@heschi heschi mentioned this issue Jun 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rsc rsc

Labels
NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
Go1.21
Development

No branches or pull requests
3 participants
@rsc @gopherbot @heschi