Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: cookie disclaimer shows on every printed page of effective go #60820

Closed
traviscj opened this issue Jun 15, 2023 · 1 comment
Closed

x/website: cookie disclaimer shows on every printed page of effective go #60820

traviscj opened this issue Jun 15, 2023 · 1 comment
Assignees
@jamalc
Labels
FrozenDueToAge website
Milestone
website/backlog

Comments

@traviscj
Copy link

What is the URL of the page with the issue?

https://go.dev/doc/effective_go

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/114.0.0.0 Safari/537.36

Screenshot

IMG_1067

What did you do?

Printed "Effective Go"

What did you expect to see?

No cookie disclaimer in printed media, or at least only a single cookie warning at the end of the printed document, or at the very least, not covering the bottom couple of lines of text on every single page.

What did you see instead?

a cookie disclaimer that obscured text on each of the 55 pages of my printout
@gopherbot gopherbot added this to the Unreleased milestone Jun 15, 2023
@traviscj traviscj changed the title x/website: x/website: cookie disclaimer shows on every page of effective go Jun 15, 2023
@traviscj traviscj changed the title x/website: cookie disclaimer shows on every page of effective go x/website: cookie disclaimer shows on every printed page of effective go Jun 15, 2023
@jamalc jamalc self-assigned this Jun 15, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/503879 mentions this issue: _content/css: hide cookie banner in print view

@findleyr findleyr modified the milestones: Unreleased, website/later Jun 21, 2023
@jamalc jamalc closed this as completed Jun 21, 2023
gopherbot pushed a commit to golang/website that referenced this issue Jun 21, 2023
@jamalc
_content/css: hide cookie banner in print view
cf517d8 
Fixes golang/go#60820.

Change-Id: I99943604c8588264f2898b0011b0135778a15628
Reviewed-on: https://go-review.googlesource.com/c/website/+/503879
Run-TryBot: Jamal Carvalho <jamal@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
@golang golang locked and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jamalc jamalc

Labels
FrozenDueToAge website
Projects
None yet
Milestone
website/backlog
Development

No branches or pull requests
4 participants
@traviscj @gopherbot @jamalc @findleyr