Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: add test coverage for Fetch API-based Transport when viable #60810

Open
dmitshur opened this issue Jun 15, 2023 · 0 comments
Open

net/http: add test coverage for Fetch API-based Transport when viable #60810

dmitshur opened this issue Jun 15, 2023 · 0 comments
Labels
arch-wasm WebAssembly issues NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-JS Suggested Issues that may be good for new contributors looking for work to do. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@dmitshur
Copy link
Contributor

In #57613 (comment), I wrote:

[...] the main reason the fake socket path was used is because that was the easiest path forward at the time. Back then, the NaCL port had the fake socket code implemented, and Node didn't support fetch. By now, with NaCL port being long gone and Node supporting fetch, it might be net simpler to start using fetch. But that is fine to investigate and consider doing if desired later.

Just disabling fetch during tests with Node 18 as done in CL 463976 is good to resolve the immediate issue. Thanks.

Now that the immediate issue is resolved, this is the tracking issue for the "investigate and consider doing" part.

In addition to possibly being simpler, I think the main benefit here would be if it lets us have coverage for the Fetch API-based Transport on the builders, and help catch regressions like:

CC @golang/js, @golang/wasm.

@dmitshur dmitshur added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. arch-wasm WebAssembly issues OS-JS labels Jun 15, 2023
@dmitshur dmitshur modified the milestones: Backlog, Unplanned Jun 15, 2023
@dmitshur dmitshur added the Suggested Issues that may be good for new contributors looking for work to do. label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-wasm WebAssembly issues NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-JS Suggested Issues that may be good for new contributors looking for work to do. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

1 participant