Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/review: flaky mock Gerrit errors on dragonfly-amd64-622 (one NetBSD/FreeBSD) #60796

Closed
prattmic opened this issue Jun 14, 2023 · 4 comments
Closed

x/review: flaky mock Gerrit errors on dragonfly-amd64-622 (one NetBSD/FreeBSD) #60796

prattmic opened this issue Jun 14, 2023 · 4 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Dragonfly OS-FreeBSD OS-NetBSD
Milestone
Unreleased

Comments

@prattmic
Copy link
Member 

#!watchflakes
post <- `Gerrit response:`

Existing failures:

2023-06-14T17:09:34-d285cae-0a48e5c/dragonfly-amd64-622

git-codereview: fetch /a/changes/?o=DETAILED_LABELS&o=CURRENT_REVISION&o=MESSAGES&o=DETAILED_ACCOUNTS&q=change%3Atmp%2Fworkdir%2Ftmp%2Fgit-codereview-test3062096014%2Fgit-origin~main~I123456789: Get "/a/changes/?o=DETAILED_LABELS&o=CURRENT_REVISION&o=MESSAGES&o=DETAILED_ACCOUNTS&q=change%3Atmp%2Fworkdir%2Ftmp%2Fgit-codereview-test3062096014%2Fgit-origin~main~I123456789": unsupported protocol scheme ""
git-codereview: fetch /a/changes/?o=DETAILED_LABELS&o=CURRENT_REVISION&o=MESSAGES&o=DETAILED_ACCOUNTS&q=change%3Atmp%2Fworkdir%2Ftmp%2Fgit-codereview-test3062096014%2Fgit-origin~main~I123456789: Get "/a/changes/?o=DETAILED_LABELS&o=CURRENT_REVISION&o=MESSAGES&o=DETAILED_ACCOUNTS&q=change%3Atmp%2Fworkdir%2Ftmp%2Fgit-codereview-test3062096014%2Fgit-origin~main~I123456789": unsupported protocol scheme ""
git-codereview: fetch /a/changes/?o=DETAILED_LABELS&o=CURRENT_REVISION&o=MESSAGES&o=DETAILED_ACCOUNTS&q=change%3Atmp%2Fworkdir%2Ftmp%2Fgit-codereview-test3062096014%2Fgit-origin~main~I123456789: Get "/a/changes/?o=DETAILED_LABELS&o=CURRENT_REVISION&o=MESSAGES&o=DETAILED_ACCOUNTS&q=change%3Atmp%2Fworkdir%2Ftmp%2Fgit-codereview-test3062096014%2Fgit-origin~main~I123456789": unsupported protocol scheme ""
git-codereview: fetch /a/changes/?o=DETAILED_LABELS&o=CURRENT_REVISION&o=MESSAGES&o=DETAILED_ACCOUNTS&q=change%3Atmp%2Fworkdir%2Ftmp%2Fgit-codereview-test3062096014%2Fgit-origin~main~I123456789: Get "/a/changes/?o=DETAILED_LABELS&o=CURRENT_REVISION&o=MESSAGES&o=DETAILED_ACCOUNTS&q=change%3Atmp%2Fworkdir%2Ftmp%2Fgit-codereview-test3062096014%2Fgit-origin~main~I123456789": unsupported protocol scheme ""
git-codereview: fetch /a/changes/proj~main~I123456789?o=LABELS&o=CURRENT_REVISION: change not found on Gerrit server
Gerrit response:
404 page not found

git-codereview: fetch /a/changes/proj~main~I123456789?o=LABELS&o=CURRENT_REVISION: http://127.0.0.1:58744/a/changes/proj~main~I123456789?o=LABELS&o=CURRENT_REVISION: malformed json response
Gerrit response:
)]}'
XXX
git-codereview: fetch /a/changes/proj~main~I0000001?o=LABELS&o=CURRENT_REVISION: change not found on Gerrit server
Gerrit response:
404 page not found

--- FAIL: TestSubmitMultiple (0.43s)
    submit_test.go:247: git-codereview submit
    submit_test.go:186: git-codereview submit 8424805d8f31e84f2f307f32d71c37360d9fcbcf 8f4ae862b6fe90e35b238e117c6f2114c479836a
    util_test.go:360: died
        stdout:
        stderr:
        git-codereview: submitting 8424805 msg
        git-codereview: change not found on Gerrit server
FAIL
FAIL	golang.org/x/review/git-codereview	55.083s
FAIL

2023-06-01T22:32:26-1970062-7183e77/dragonfly-amd64-622
2023-06-01T17:13:46-1970062-691b6ca/dragonfly-amd64-622
2023-04-10T15:50:11-1970062-a3dd959/dragonfly-amd64-622
2023-04-07T20:44:50-1970062-46a49eb/dragonfly-amd64-622
2022-12-07T00:25:27-1970062-10bb003/netbsd-386-9_0
2022-09-06T11:14:09-0c548b8-1c50484/dragonfly-amd64-622
2022-09-05T21:39:28-0c548b8-4c1ca42/dragonfly-amd64-622
2022-09-03T18:29:30-0c548b8-2392b70/dragonfly-amd64-622
2022-08-12T17:54:26-0c548b8-7f3569c/dragonfly-amd64-622
2022-08-12T16:22:39-0c548b8-2cf49a7/dragonfly-amd64-622
2022-06-07T17:44:51-5579f24-69bb7c6/dragonfly-amd64
2022-06-07T16:07:58-5579f24-d2630aa/freebsd-arm64-dmgk

If I understand correctly here, "Gerrit" in these tests is a mock server listening on a localhost port.

cc @golang/dragonfly @golang/freebsd
@prattmic prattmic added OS-Dragonfly OS-FreeBSD NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jun 14, 2023
@prattmic prattmic added this to the Unreleased milestone Jun 14, 2023
@prattmic prattmic changed the title x/review: flaky mock Gerrit errors on dragonfly-amd64-622 (one FreeBSD) x/review: flaky mock Gerrit errors on dragonfly-amd64-622 (one NetBSD/FreeBSD) Jun 14, 2023
@prattmic
Copy link
Member Author

cc @golang/netbsd

@bcmills
Copy link
Contributor

bcmills commented Jun 14, 2023

Duplicate of #49899

@bcmills bcmills marked this as a duplicate of #49899 Jun 14, 2023
@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Jun 14, 2023
@bcmills
Copy link
Contributor

bcmills commented Jun 14, 2023

Duplicate of #56221

@bcmills bcmills marked this as a duplicate of #56221 Jun 14, 2023
@bcmills bcmills closed this as completed Jun 14, 2023
@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Jun 14, 2023
@gopherbot gopherbot reopened this Jun 30, 2023
@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- `Gerrit response:`
2023-06-26 16:37 dragonfly-amd64-622 review@99fd4b8d go@79d4defa x/review/git-codereview.TestSubmitErrors (log) 
git-codereview: fetch /a/changes/?o=DETAILED_LABELS&o=CURRENT_REVISION&o=MESSAGES&o=DETAILED_ACCOUNTS&q=change%3Atmp%2Fworkdir%2Ftmp%2Fgit-codereview-test2690252729%2Fgit-origin~main~I123456789: Get "/a/changes/?o=DETAILED_LABELS&o=CURRENT_REVISION&o=MESSAGES&o=DETAILED_ACCOUNTS&q=change%3Atmp%2Fworkdir%2Ftmp%2Fgit-codereview-test2690252729%2Fgit-origin~main~I123456789": unsupported protocol scheme ""
git-codereview: fetch /a/changes/?o=DETAILED_LABELS&o=CURRENT_REVISION&o=MESSAGES&o=DETAILED_ACCOUNTS&q=change%3Atmp%2Fworkdir%2Ftmp%2Fgit-codereview-test2690252729%2Fgit-origin~main~I123456789: Get "/a/changes/?o=DETAILED_LABELS&o=CURRENT_REVISION&o=MESSAGES&o=DETAILED_ACCOUNTS&q=change%3Atmp%2Fworkdir%2Ftmp%2Fgit-codereview-test2690252729%2Fgit-origin~main~I123456789": unsupported protocol scheme ""
git-codereview: fetch /a/changes/?o=DETAILED_LABELS&o=CURRENT_REVISION&o=MESSAGES&o=DETAILED_ACCOUNTS&q=change%3Atmp%2Fworkdir%2Ftmp%2Fgit-codereview-test2690252729%2Fgit-origin~main~I123456789: Get "/a/changes/?o=DETAILED_LABELS&o=CURRENT_REVISION&o=MESSAGES&o=DETAILED_ACCOUNTS&q=change%3Atmp%2Fworkdir%2Ftmp%2Fgit-codereview-test2690252729%2Fgit-origin~main~I123456789": unsupported protocol scheme ""
git-codereview: fetch /a/changes/?o=DETAILED_LABELS&o=CURRENT_REVISION&o=MESSAGES&o=DETAILED_ACCOUNTS&q=change%3Atmp%2Fworkdir%2Ftmp%2Fgit-codereview-test2690252729%2Fgit-origin~main~I123456789: Get "/a/changes/?o=DETAILED_LABELS&o=CURRENT_REVISION&o=MESSAGES&o=DETAILED_ACCOUNTS&q=change%3Atmp%2Fworkdir%2Ftmp%2Fgit-codereview-test2690252729%2Fgit-origin~main~I123456789": unsupported protocol scheme ""
git-codereview: fetch /a/changes/proj~main~I123456789?o=LABELS&o=CURRENT_REVISION: change not found on Gerrit server
Gerrit response:
404 page not found

git-codereview: fetch /a/changes/proj~main~I123456789?o=LABELS&o=CURRENT_REVISION: change not found on Gerrit server
Gerrit response:
404 page not found

--- FAIL: TestSubmitErrors (0.27s)
    submit_test.go:21: > no commit
    submit_test.go:22: git-codereview submit
    submit_test.go:29: > do not submit
    submit_test.go:30: git-codereview submit
    submit_test.go:34: > staged changes
    submit_test.go:37: git-codereview submit
    submit_test.go:42: > unstaged changes
    submit_test.go:44: git-codereview submit
    submit_test.go:52: > not found
    submit_test.go:53: git-codereview submit
    submit_test.go:58: > malformed json
    submit_test.go:60: git-codereview submit
    submit_test.go:62: wrong output
        stderr does not contain "malformed json response"
        stderr:
        git-codereview: submitting f7bf39e msg
        git-codereview: change not found on Gerrit server

— watchflakes

@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Dragonfly OS-FreeBSD OS-NetBSD
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@prattmic @bcmills @gopherbot