Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/mod/zip: TestCreateFromDirSpecial/ignore_symlink failing on wasip1-wasm-wasmtime #60795

Closed
prattmic opened this issue Jun 14, 2023 · 3 comments
Closed

x/mod/zip: TestCreateFromDirSpecial/ignore_symlink failing on wasip1-wasm-wasmtime #60795

prattmic opened this issue Jun 14, 2023 · 3 comments
Labels
arch-wasm WebAssembly issues NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unreleased

Comments

@prattmic
Copy link
Member

This test is failing consistently, see https://build.golang.org/?repo=golang.org%2fx%2fmod.

Sample: https://build.golang.org/log/ee8bf87a4deeaf417d36761289c1fb43ff648869

--- FAIL: TestCreateFromDirSpecial (0.01s)
    --- FAIL: TestCreateFromDirSpecial/ignore_symlink (0.00s)
        zip_test.go:543: symlink /tmp/TestCreateFromDirSpecialignore_symlink3388003329/001 /tmp/TestCreateFromDirSpecialignore_symlink3388003329/001/link: Operation not permitted
FAIL
FAIL	golang.org/x/mod/zip	6.086s
FAIL

Note that wasip1-wasm-wazero is OK.

cc @golang/wasm
@prattmic prattmic added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. arch-wasm WebAssembly issues labels Jun 14, 2023
@prattmic prattmic added this to the Backlog milestone Jun 14, 2023
@johanbrandhorst
Copy link
Member

Hm, symlink tests should be disabled on the wasmtime runner, courtesy of https://go.googlesource.com/go/+/refs/heads/master/src/internal/testenv/testenv_notwin.go#16. Does this test check for symlink support before running?

@bcmills
Copy link
Contributor

bcmills commented Jun 14, 2023

Does this test check for symlink support before running?

It checks after the fact, with the operation allowed to fail after the fact based on a hard-coded list of runtime.GOOS:
https://cs.opensource.google/go/x/mod/+/master:zip/zip_test.go;l=538-545;drc=ad6fd61f94f8fdf6926f5dee6e45bdd13add2f9f

Probably that list should explicitly list the GOOS values for which Symlink is expected to always succeed, instead of its current behavior of explicitly listing the ones for which it is allowed to fail. That would make it more robust to new GOOS values going forward.

@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. labels Jun 14, 2023
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 14, 2023
@bcmills bcmills changed the title x/mod: TestCreateFromDirSpecial/ignore_symlink failing on wasip1-wasm-wasmtime x/mod/zip: TestCreateFromDirSpecial/ignore_symlink failing on wasip1-wasm-wasmtime Jun 16, 2023
@gopherbot
Copy link

Change https://go.dev/cl/504075 mentions this issue: zip: fix TestCreateFromDirSpecial/ignore_symlink on wasmtime

@dmitshur dmitshur modified the milestones: Backlog, Unreleased Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arch-wasm WebAssembly issues NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@prattmic @dmitshur @bcmills @johanbrandhorst @gopherbot