Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: go list -export -e outputs errors to stderr and has non-zero exit code [1.19 backport] #60710

Closed
gopherbot opened this issue Jun 9, 2023 · 6 comments
Closed

cmd/go: go list -export -e outputs errors to stderr and has non-zero exit code [1.19 backport] #60710

gopherbot opened this issue Jun 9, 2023 · 6 comments
Assignees
@bcmills
Labels
CherryPickApproved Used during the release process for point releases GoCommand cmd/go release-blocker
Milestone
Go1.19.11

Comments

@gopherbot
Copy link

@bcmills requested issue #25842 to be considered for backport to the next 1.19 minor release.

@gopherbot, please backport to Go 1.19. This is needed to fix #60650.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jun 9, 2023
@gopherbot gopherbot mentioned this issue Jun 9, 2023
Open
@gopherbot gopherbot added this to the Go1.19.11 milestone Jun 9, 2023
@bcmills bcmills self-assigned this Jun 9, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/502195 mentions this issue: [release-branch.go1.19] cmd/go: do not exit with non-zero code from go list -e -export

@gopherbot
Copy link
Author

Change https://go.dev/cl/502196 mentions this issue: [release-branch.go1.19] cmd/go/internal/work: make formatOutput return an error that includes the import path

@bcmills bcmills added the CherryPickApproved Used during the release process for point releases label Jun 9, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jun 9, 2023
@bcmills
Copy link
Contributor

bcmills commented Jun 9, 2023

Approving as necessary to fix a regression reported in x/tools.

@dmitshur dmitshur added the GoCommand cmd/go label Jun 9, 2023
@prattmic
Copy link
Member

The CL stack at https://go.dev/cl/502196 contains 6 CLs, but only 2 mention this issue. Just to confirm, all 6 are required for this backport, correct?

@bcmills
Copy link
Contributor

bcmills commented Jun 13, 2023

Probably only two are required for this particular issue, but they all ought to be merged before the next release either way.

@gopherbot
Copy link
Author

Closed by merging c045822 to release-branch.go1.19.

gopherbot pushed a commit that referenced this issue Jun 13, 2023
@matloob @prattmic
[release-branch.go1.19] cmd/go: do not exit with non-zero code from g…
c045822 
…o list -e -export

go list -e -export puts errors running build actions on the load.Package
corresponding to the failed action rather than exiting with a non zero
exit code.

Fixes #60710.
Fixes #60650.
Updates #25842.

Change-Id: I1fea85cc5a0557f514fe9d4ed3b6a858376fdcde
Reviewed-on: https://go-review.googlesource.com/c/go/+/437298
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Michael Matloob <matloob@golang.org>
Reviewed-on: https://go-review.googlesource.com/c/go/+/502195
TryBot-Bypass: Bryan Mills <bcmills@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
gopherbot pushed a commit that referenced this issue Jun 13, 2023
@prattmic
[release-branch.go1.19] cmd/go/internal/work: make formatOutput retur…
7d6517c 
…n an error that includes the import path

This refines the error output that was previously adjusted in CL 437298.

Longer term, we should consider unraveling the call chains involving
formatOutput to avoid passing so many parameters through so many
different formatting functions.

Updates #60710.
Updates #60650.
Updates #25842.

Change-Id: I3b9d03bf5968902d8ccc4841ab4dbe114a2239e4
Reviewed-on: https://go-review.googlesource.com/c/go/+/451218
Reviewed-by: Bryan Mills <bcmills@google.com>
Auto-Submit: Russ Cox <rsc@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-on: https://go-review.googlesource.com/c/go/+/502196
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Bypass: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Michael Matloob <matloob@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bcmills bcmills

Labels
CherryPickApproved Used during the release process for point releases GoCommand cmd/go release-blocker
Projects
None yet
Milestone
Go1.19.11
Development

No branches or pull requests
4 participants
@prattmic @dmitshur @bcmills @gopherbot