Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/vuln: TestStaticCheck failures #60687

Open
gopherbot opened this issue Jun 8, 2023 · 12 comments
Open

x/vuln: TestStaticCheck failures #60687

gopherbot opened this issue Jun 8, 2023 · 12 comments
Assignees
@zpavlinovic
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Milestone
vuln/unplanned

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "golang.org/x/vuln" && test == "TestStaticCheck"

Issue created automatically to collect these failures.

Example (log):

go mod tidy

govulncheck is an experimental tool. Share feedback at https://go.dev/s/govulncheck-feedback.

Using devel 1bbf55c2bb4aa9725202584621ed85a27695958c and vuln@v0.0.0 with vulnerability data from https://vuln.go.dev (last modified 2023-06-07 14:33:24 +0000 UTC).

Scanning your code and 203 packages across 5 dependent modules for known vulnerabilities...


No vulnerabilities found.
--- FAIL: TestStaticCheck (30.11s)
    all_test.go:101: 
        go: downloading honnef.co/go/tools v0.4.3
        go: honnef.co/go/tools/cmd/staticcheck@v0.4.3: honnef.co/go/tools@v0.4.3: verifying module: honnef.co/go/tools@v0.4.3: Get "https://sum.golang.org/lookup/honnef.co/go/tools@v0.4.3": dial tcp 172.217.212.141:443: i/o timeout

    all_test.go:101: command had non zero exit code

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 8, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/vuln" && test == "TestStaticCheck"
2023-06-02 04:04 linux-arm64-longtest vuln@be19afd8 go@1bbf55c2 x/vuln.TestStaticCheck (log) 
go mod tidy

govulncheck is an experimental tool. Share feedback at https://go.dev/s/govulncheck-feedback.

Using devel 1bbf55c2bb4aa9725202584621ed85a27695958c and vuln@v0.0.0 with vulnerability data from https://vuln.go.dev (last modified 2023-06-07 14:33:24 +0000 UTC).

Scanning your code and 203 packages across 5 dependent modules for known vulnerabilities...


No vulnerabilities found.
--- FAIL: TestStaticCheck (30.11s)
    all_test.go:101: 
        go: downloading honnef.co/go/tools v0.4.3
        go: honnef.co/go/tools/cmd/staticcheck@v0.4.3: honnef.co/go/tools@v0.4.3: verifying module: honnef.co/go/tools@v0.4.3: Get "https://sum.golang.org/lookup/honnef.co/go/tools@v0.4.3": dial tcp 172.217.212.141:443: i/o timeout

    all_test.go:101: command had non zero exit code

— watchflakes

@gopherbot gopherbot added the vulncheck or vulndb Issues for the x/vuln or x/vulndb repo label Jun 8, 2023
@gopherbot gopherbot modified the milestones: Unreleased, vuln/unplanned Jun 8, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/vuln" && test == "TestStaticCheck"
2023-06-22 22:41 darwin-amd64-longtest vuln@9eaf6cb1 go@6dce882b x/vuln.TestStaticCheck (log) 
go mod tidy

govulncheck is an experimental tool. Share feedback at https://go.dev/s/govulncheck-feedback.

Using devel 6dce882b3aad86b8c3e2928d3be6a87e425c1754
 and vuln@v0.0.0 with vulnerability data from https://vuln.go.dev (last modified 2023-06-22 16:44:55 +0000 UTC).

Scanning your code and 203 packages across 5 dependent modules for known vulnerabilities...

--- FAIL: TestStaticCheck (32.04s)
    all_test.go:101: 
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/vulncheck/witness.go:291:10: unnecessary assignment to the blank identifier (S1005)
        exit status 1

    all_test.go:101: command had non zero exit code
2023-06-22 22:41 darwin-amd64-longtest vuln@9eaf6cb1 go@164aceea x/vuln.TestStaticCheck (log) 
go mod tidy

govulncheck is an experimental tool. Share feedback at https://go.dev/s/govulncheck-feedback.

Using devel 164aceea08a4c56b9bf451e315c5dbe3f4727971
 and vuln@v0.0.0 with vulnerability data from https://vuln.go.dev (last modified 2023-06-22 16:44:55 +0000 UTC).

Scanning your code and 203 packages across 5 dependent modules for known vulnerabilities...

--- FAIL: TestStaticCheck (23.28s)
    all_test.go:101: 
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/vulncheck/witness.go:291:10: unnecessary assignment to the blank identifier (S1005)
        exit status 1

    all_test.go:101: command had non zero exit code
2023-06-22 22:41 darwin-amd64-longtest vuln@9eaf6cb1 go@25e46693 x/vuln.TestStaticCheck (log) 
go mod tidy

govulncheck is an experimental tool. Share feedback at https://go.dev/s/govulncheck-feedback.

Using devel 25e46693a1085f604a9c92ee26afed2b4d45a9dd
 and vuln@v0.0.0 with vulnerability data from https://vuln.go.dev (last modified 2023-06-22 16:44:55 +0000 UTC).

Scanning your code and 203 packages across 5 dependent modules for known vulnerabilities...

--- FAIL: TestStaticCheck (32.06s)
    all_test.go:101: 
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/vulncheck/witness.go:291:10: unnecessary assignment to the blank identifier (S1005)
        exit status 1

    all_test.go:101: command had non zero exit code
2023-06-22 22:41 linux-386-longtest vuln@9eaf6cb1 go@6dce882b x/vuln.TestStaticCheck (log) 
go mod tidy

govulncheck is an experimental tool. Share feedback at https://go.dev/s/govulncheck-feedback.

Using devel 6dce882b3aad86b8c3e2928d3be6a87e425c1754
 and vuln@v0.0.0 with vulnerability data from https://vuln.go.dev (last modified 2023-06-22 16:44:55 +0000 UTC).

Scanning your code and 200 packages across 5 dependent modules for known vulnerabilities...

--- FAIL: TestStaticCheck (12.60s)
    all_test.go:101: 
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/vulncheck/witness.go:291:10: unnecessary assignment to the blank identifier (S1005)
        exit status 1

    all_test.go:101: command had non zero exit code
2023-06-22 22:41 linux-386-longtest vuln@9eaf6cb1 go@164aceea x/vuln.TestStaticCheck (log) 
go mod tidy

govulncheck is an experimental tool. Share feedback at https://go.dev/s/govulncheck-feedback.

Using devel 164aceea08a4c56b9bf451e315c5dbe3f4727971
 and vuln@v0.0.0 with vulnerability data from https://vuln.go.dev (last modified 2023-06-22 16:44:55 +0000 UTC).

Scanning your code and 200 packages across 5 dependent modules for known vulnerabilities...

--- FAIL: TestStaticCheck (12.97s)
    all_test.go:101: 
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/vulncheck/witness.go:291:10: unnecessary assignment to the blank identifier (S1005)
        exit status 1

    all_test.go:101: command had non zero exit code
2023-06-22 22:41 linux-386-longtest vuln@9eaf6cb1 go@25e46693 x/vuln.TestStaticCheck (log) 
go mod tidy

govulncheck is an experimental tool. Share feedback at https://go.dev/s/govulncheck-feedback.

Using devel 25e46693a1085f604a9c92ee26afed2b4d45a9dd
 and vuln@v0.0.0 with vulnerability data from https://vuln.go.dev (last modified 2023-06-22 16:44:55 +0000 UTC).

Scanning your code and 200 packages across 5 dependent modules for known vulnerabilities...

--- FAIL: TestStaticCheck (8.70s)
    all_test.go:101: 
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/vulncheck/witness.go:291:10: unnecessary assignment to the blank identifier (S1005)
        exit status 1

    all_test.go:101: command had non zero exit code
2023-06-22 22:41 linux-amd64-longtest vuln@9eaf6cb1 go@6dce882b x/vuln.TestStaticCheck (log) 
go mod tidy

govulncheck is an experimental tool. Share feedback at https://go.dev/s/govulncheck-feedback.

Using devel 6dce882b3aad86b8c3e2928d3be6a87e425c1754
 and vuln@v0.0.0 with vulnerability data from https://vuln.go.dev (last modified 2023-06-22 16:44:55 +0000 UTC).

Scanning your code and 202 packages across 5 dependent modules for known vulnerabilities...

--- FAIL: TestStaticCheck (13.15s)
    all_test.go:101: 
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/vulncheck/witness.go:291:10: unnecessary assignment to the blank identifier (S1005)
        exit status 1

    all_test.go:101: command had non zero exit code
2023-06-22 22:41 linux-amd64-longtest vuln@9eaf6cb1 go@164aceea x/vuln.TestStaticCheck (log) 
go mod tidy

govulncheck is an experimental tool. Share feedback at https://go.dev/s/govulncheck-feedback.

Using devel 164aceea08a4c56b9bf451e315c5dbe3f4727971
 and vuln@v0.0.0 with vulnerability data from https://vuln.go.dev (last modified 2023-06-22 16:44:55 +0000 UTC).

Scanning your code and 202 packages across 5 dependent modules for known vulnerabilities...

--- FAIL: TestStaticCheck (11.82s)
    all_test.go:101: 
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/vulncheck/witness.go:291:10: unnecessary assignment to the blank identifier (S1005)
        exit status 1

    all_test.go:101: command had non zero exit code
2023-06-22 22:41 linux-amd64-longtest vuln@9eaf6cb1 go@25e46693 x/vuln.TestStaticCheck (log) 
go mod tidy

govulncheck is an experimental tool. Share feedback at https://go.dev/s/govulncheck-feedback.

Using devel 25e46693a1085f604a9c92ee26afed2b4d45a9dd
 and vuln@v0.0.0 with vulnerability data from https://vuln.go.dev (last modified 2023-06-22 16:44:55 +0000 UTC).

Scanning your code and 202 packages across 5 dependent modules for known vulnerabilities...

--- FAIL: TestStaticCheck (11.38s)
    all_test.go:101: 
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/mod v0.7.0
        go: downloading golang.org/x/sys v0.3.0
        internal/vulncheck/witness.go:291:10: unnecessary assignment to the blank identifier (S1005)
        exit status 1

    all_test.go:101: command had non zero exit code
2023-06-22 22:41 linux-amd64-longtest-race vuln@9eaf6cb1 go@6dce882b x/vuln.TestStaticCheck (log) 
go mod tidy

govulncheck is an experimental tool. Share feedback at https://go.dev/s/govulncheck-feedback.

Using devel 6dce882b3aad86b8c3e2928d3be6a87e425c1754
 and vuln@v0.0.0 with vulnerability data from https://vuln.go.dev (last modified 2023-06-22 16:44:55 +0000 UTC).

Scanning your code and 202 packages across 5 dependent modules for known vulnerabilities...

--- FAIL: TestStaticCheck (16.72s)
    all_test.go:101: 
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/vulncheck/witness.go:291:10: unnecessary assignment to the blank identifier (S1005)
        exit status 1

    all_test.go:101: command had non zero exit code
2023-06-22 22:41 linux-amd64-longtest-race vuln@9eaf6cb1 go@164aceea x/vuln.TestStaticCheck (log) 
go mod tidy

govulncheck is an experimental tool. Share feedback at https://go.dev/s/govulncheck-feedback.

Using devel 164aceea08a4c56b9bf451e315c5dbe3f4727971
 and vuln@v0.0.0 with vulnerability data from https://vuln.go.dev (last modified 2023-06-22 16:44:55 +0000 UTC).

Scanning your code and 202 packages across 5 dependent modules for known vulnerabilities...

--- FAIL: TestStaticCheck (13.20s)
    all_test.go:101: 
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/vulncheck/witness.go:291:10: unnecessary assignment to the blank identifier (S1005)
        exit status 1

    all_test.go:101: command had non zero exit code
2023-06-22 22:41 linux-amd64-longtest-race vuln@9eaf6cb1 go@25e46693 x/vuln.TestStaticCheck (log) 
go mod tidy

govulncheck is an experimental tool. Share feedback at https://go.dev/s/govulncheck-feedback.

Using devel 25e46693a1085f604a9c92ee26afed2b4d45a9dd
 and vuln@v0.0.0 with vulnerability data from https://vuln.go.dev (last modified 2023-06-22 16:44:55 +0000 UTC).

Scanning your code and 202 packages across 5 dependent modules for known vulnerabilities...

--- FAIL: TestStaticCheck (13.67s)
    all_test.go:101: 
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/mod v0.7.0
        go: downloading golang.org/x/sys v0.3.0
        internal/vulncheck/witness.go:291:10: unnecessary assignment to the blank identifier (S1005)
        exit status 1

    all_test.go:101: command had non zero exit code
2023-06-22 22:41 linux-arm64-longtest vuln@9eaf6cb1 go@6dce882b x/vuln.TestStaticCheck (log) 
go mod tidy

govulncheck is an experimental tool. Share feedback at https://go.dev/s/govulncheck-feedback.

Using devel 6dce882b3aad86b8c3e2928d3be6a87e425c1754
 and vuln@v0.0.0 with vulnerability data from https://vuln.go.dev (last modified 2023-06-22 16:44:55 +0000 UTC).

Scanning your code and 201 packages across 5 dependent modules for known vulnerabilities...

--- FAIL: TestStaticCheck (8.33s)
    all_test.go:101: 
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/mod v0.7.0
        go: downloading golang.org/x/sys v0.3.0
        internal/vulncheck/witness.go:291:10: unnecessary assignment to the blank identifier (S1005)
        exit status 1

    all_test.go:101: command had non zero exit code
2023-06-22 22:41 linux-arm64-longtest vuln@9eaf6cb1 go@164aceea x/vuln.TestStaticCheck (log) 
go mod tidy

govulncheck is an experimental tool. Share feedback at https://go.dev/s/govulncheck-feedback.

Using devel 164aceea08a4c56b9bf451e315c5dbe3f4727971
 and vuln@v0.0.0 with vulnerability data from https://vuln.go.dev (last modified 2023-06-22 16:44:55 +0000 UTC).

Scanning your code and 201 packages across 5 dependent modules for known vulnerabilities...

--- FAIL: TestStaticCheck (7.70s)
    all_test.go:101: 
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/vulncheck/witness.go:291:10: unnecessary assignment to the blank identifier (S1005)
        exit status 1

    all_test.go:101: command had non zero exit code
2023-06-22 22:41 linux-arm64-longtest vuln@9eaf6cb1 go@25e46693 x/vuln.TestStaticCheck (log) 
go mod tidy

govulncheck is an experimental tool. Share feedback at https://go.dev/s/govulncheck-feedback.

Using devel 25e46693a1085f604a9c92ee26afed2b4d45a9dd
 and vuln@v0.0.0 with vulnerability data from https://vuln.go.dev (last modified 2023-06-22 16:44:55 +0000 UTC).

Scanning your code and 201 packages across 5 dependent modules for known vulnerabilities...

--- FAIL: TestStaticCheck (7.94s)
    all_test.go:101: 
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/vulncheck/witness.go:291:10: unnecessary assignment to the blank identifier (S1005)
        exit status 1

    all_test.go:101: command had non zero exit code

— watchflakes

@zpavlinovic zpavlinovic self-assigned this Oct 9, 2023
@zpavlinovic
Copy link
Contributor

Seems to be gone now.

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/vuln" && test == "TestStaticCheck"
2024-01-31 21:29 x_vuln-go1.21-darwin-amd64-longtest vuln@e215a3d1 release-branch.go1.21@916e6cdd x/vuln.TestStaticCheck (log) 
=== RUN   TestStaticCheck
    all_test.go:107: 
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/vulncheck/binary.go:162:6: should replace loop with pkgSymbols[p.Path] = append(pkgSymbols[p.Path], syms...) (S1011)
        exit status 1
        
    all_test.go:107: command had non zero exit code
--- FAIL: TestStaticCheck (12.26s)
2024-01-31 21:48 x_vuln-go1.21-darwin-amd64-longtest vuln@3fe4ad41 release-branch.go1.21@916e6cdd x/vuln.TestStaticCheck (log) 
=== RUN   TestStaticCheck
    all_test.go:107: 
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/sys v0.3.0
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/mod v0.7.0
        internal/vulncheck/binary.go:162:6: should replace loop with pkgSymbols[p.Path] = append(pkgSymbols[p.Path], syms...) (S1011)
        exit status 1
        
    all_test.go:107: command had non zero exit code
--- FAIL: TestStaticCheck (10.23s)
2024-01-31 22:15 x_vuln-go1.21-darwin-amd64-longtest vuln@3e072dae release-branch.go1.21@2fdad8af x/vuln.TestStaticCheck (log) 
=== RUN   TestStaticCheck
    all_test.go:107: 
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/vulncheck/binary.go:162:6: should replace loop with pkgSymbols[p.Path] = append(pkgSymbols[p.Path], syms...) (S1011)
        exit status 1
        
    all_test.go:107: command had non zero exit code
--- FAIL: TestStaticCheck (16.92s)

— watchflakes

@gopherbot gopherbot reopened this Feb 6, 2024
@zpavlinovic
Copy link
Contributor

The fix for this landed on Feb 5th. Will keep it open for a bit.

@gopherbot gopherbot reopened this Mar 6, 2024
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/vuln" && test == "TestStaticCheck"
2024-03-06 21:44 darwin-amd64-longtest vuln@0c4448e1 go@70fbc882 x/vuln.TestStaticCheck (log) 
--- FAIL: TestStaticCheck (63.87s)
    all_test.go:88: /tmp/buildlet/go/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/scan/flags.go:185:5: error var flagParseError should have name of the form errFoo (ST1012)
        exit status 1
2024-03-06 21:44 linux-386-longtest vuln@0c4448e1 go@70fbc882 x/vuln.TestStaticCheck (log) 
--- FAIL: TestStaticCheck (9.03s)
    all_test.go:88: /workdir/go/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/mod v0.7.0
        go: downloading golang.org/x/sys v0.3.0
        internal/scan/flags.go:185:5: error var flagParseError should have name of the form errFoo (ST1012)
        exit status 1
2024-03-06 21:44 linux-amd64-longtest vuln@0c4448e1 go@70fbc882 x/vuln.TestStaticCheck (log) 
--- FAIL: TestStaticCheck (8.61s)
    all_test.go:88: /workdir/go/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/scan/flags.go:185:5: error var flagParseError should have name of the form errFoo (ST1012)
        exit status 1
2024-03-06 21:44 linux-amd64-longtest-race vuln@0c4448e1 go@70fbc882 x/vuln.TestStaticCheck (log) 
--- FAIL: TestStaticCheck (11.63s)
    all_test.go:88: /workdir/go/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/scan/flags.go:185:5: error var flagParseError should have name of the form errFoo (ST1012)
        exit status 1
2024-03-06 21:44 linux-arm64-longtest vuln@0c4448e1 go@70fbc882 x/vuln.TestStaticCheck (log) 
--- FAIL: TestStaticCheck (7.81s)
    all_test.go:88: /tmp/workdir/go/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/scan/flags.go:185:5: error var flagParseError should have name of the form errFoo (ST1012)
        exit status 1
2024-03-06 21:45 darwin-amd64-longtest vuln@334df71c go@70fbc882 x/vuln.TestStaticCheck (log) 
--- FAIL: TestStaticCheck (35.18s)
    all_test.go:88: /tmp/buildlet/go/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/scan/flags.go:187:5: error var flagParseError should have name of the form errFoo (ST1012)
        exit status 1
2024-03-06 21:45 linux-386-longtest vuln@334df71c go@70fbc882 x/vuln.TestStaticCheck (log) 
--- FAIL: TestStaticCheck (12.94s)
    all_test.go:88: /workdir/go/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/scan/flags.go:187:5: error var flagParseError should have name of the form errFoo (ST1012)
        exit status 1
2024-03-06 21:45 linux-amd64-longtest vuln@334df71c go@70fbc882 x/vuln.TestStaticCheck (log) 
--- FAIL: TestStaticCheck (9.80s)
    all_test.go:88: /workdir/go/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/scan/flags.go:187:5: error var flagParseError should have name of the form errFoo (ST1012)
        exit status 1
2024-03-06 21:45 linux-amd64-longtest-race vuln@334df71c go@70fbc882 x/vuln.TestStaticCheck (log) 
--- FAIL: TestStaticCheck (18.28s)
    all_test.go:88: /workdir/go/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/scan/flags.go:187:5: error var flagParseError should have name of the form errFoo (ST1012)
        exit status 1
2024-03-06 21:45 linux-arm64-longtest vuln@334df71c go@70fbc882 x/vuln.TestStaticCheck (log) 
--- FAIL: TestStaticCheck (8.13s)
    all_test.go:88: /tmp/workdir/go/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/scan/flags.go:187:5: error var flagParseError should have name of the form errFoo (ST1012)
        exit status 1
2024-03-06 21:45 darwin-amd64-longtest vuln@b51a8ac3 go@70fbc882 x/vuln.TestStaticCheck (log) 
--- FAIL: TestStaticCheck (64.77s)
    all_test.go:88: /tmp/buildlet/go/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/scan/flags.go:187:5: error var flagParseError should have name of the form errFoo (ST1012)
        exit status 1
2024-03-06 21:45 linux-386-longtest vuln@b51a8ac3 go@70fbc882 x/vuln.TestStaticCheck (log) 
--- FAIL: TestStaticCheck (8.87s)
    all_test.go:88: /workdir/go/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/scan/flags.go:187:5: error var flagParseError should have name of the form errFoo (ST1012)
        exit status 1
2024-03-06 21:45 linux-amd64-longtest vuln@b51a8ac3 go@70fbc882 x/vuln.TestStaticCheck (log) 
--- FAIL: TestStaticCheck (12.48s)
    all_test.go:88: /workdir/go/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/scan/flags.go:187:5: error var flagParseError should have name of the form errFoo (ST1012)
        exit status 1
2024-03-06 21:45 linux-amd64-longtest-race vuln@b51a8ac3 go@70fbc882 x/vuln.TestStaticCheck (log) 
--- FAIL: TestStaticCheck (19.84s)
    all_test.go:88: /workdir/go/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/scan/flags.go:187:5: error var flagParseError should have name of the form errFoo (ST1012)
        exit status 1
2024-03-06 21:45 linux-arm64-longtest vuln@b51a8ac3 go@70fbc882 x/vuln.TestStaticCheck (log) 
--- FAIL: TestStaticCheck (7.72s)
    all_test.go:88: /tmp/workdir/go/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/scan/flags.go:187:5: error var flagParseError should have name of the form errFoo (ST1012)
        exit status 1

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/vuln" && test == "TestStaticCheck"
2024-03-06 21:44 x_vuln-go1.21-darwin-amd64-longtest vuln@0c4448e1 release-branch.go1.21@63992def x/vuln.TestStaticCheck (log) 
=== RUN   TestStaticCheck
    all_test.go:88: /Users/swarming/.swarming/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/scan/flags.go:185:5: error var flagParseError should have name of the form errFoo (ST1012)
        exit status 1
--- FAIL: TestStaticCheck (12.75s)
2024-03-06 21:44 x_vuln-go1.21-linux-amd64-longtest vuln@0c4448e1 release-branch.go1.21@63992def x/vuln.TestStaticCheck (log) 
=== RUN   TestStaticCheck
    all_test.go:88: /home/swarming/.swarming/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/scan/flags.go:185:5: error var flagParseError should have name of the form errFoo (ST1012)
        exit status 1
--- FAIL: TestStaticCheck (13.12s)
2024-03-06 21:44 x_vuln-go1.21-linux-amd64-longtest-race vuln@0c4448e1 release-branch.go1.21@63992def x/vuln.TestStaticCheck (log) 
=== RUN   TestStaticCheck
    all_test.go:88: /home/swarming/.swarming/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/scan/flags.go:185:5: error var flagParseError should have name of the form errFoo (ST1012)
        exit status 1
--- FAIL: TestStaticCheck (18.68s)
2024-03-06 21:44 x_vuln-go1.22-darwin-amd64-longtest vuln@0c4448e1 release-branch.go1.22@db6097f8 x/vuln.TestStaticCheck (log) 
=== RUN   TestStaticCheck
    all_test.go:88: /Users/swarming/.swarming/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/sys v0.3.0
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/mod v0.7.0
        internal/scan/flags.go:185:5: error var flagParseError should have name of the form errFoo (ST1012)
        exit status 1
--- FAIL: TestStaticCheck (13.02s)
2024-03-06 21:44 x_vuln-go1.22-linux-amd64-longtest vuln@0c4448e1 release-branch.go1.22@db6097f8 x/vuln.TestStaticCheck (log) 
=== RUN   TestStaticCheck
    all_test.go:88: /home/swarming/.swarming/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/scan/flags.go:185:5: error var flagParseError should have name of the form errFoo (ST1012)
        exit status 1
--- FAIL: TestStaticCheck (12.29s)
2024-03-06 21:44 x_vuln-go1.22-linux-amd64-longtest-race vuln@0c4448e1 release-branch.go1.22@db6097f8 x/vuln.TestStaticCheck (log) 
=== RUN   TestStaticCheck
    all_test.go:88: /home/swarming/.swarming/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/scan/flags.go:185:5: error var flagParseError should have name of the form errFoo (ST1012)
        exit status 1
--- FAIL: TestStaticCheck (17.42s)
2024-03-06 21:44 x_vuln-gotip-darwin-amd64-longtest vuln@0c4448e1 go@70fbc882 x/vuln.TestStaticCheck (log) 
=== RUN   TestStaticCheck
    all_test.go:88: /Volumes/Work/s/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/scan/flags.go:185:5: error var flagParseError should have name of the form errFoo (ST1012)
        exit status 1
--- FAIL: TestStaticCheck (13.19s)
2024-03-06 21:44 x_vuln-gotip-linux-amd64-longtest vuln@0c4448e1 go@70fbc882 x/vuln.TestStaticCheck (log) 
=== RUN   TestStaticCheck
    all_test.go:88: /home/swarming/.swarming/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/scan/flags.go:185:5: error var flagParseError should have name of the form errFoo (ST1012)
        exit status 1
--- FAIL: TestStaticCheck (12.60s)
2024-03-06 21:44 x_vuln-gotip-linux-amd64-longtest-race vuln@0c4448e1 go@70fbc882 x/vuln.TestStaticCheck (log) 
=== RUN   TestStaticCheck
    all_test.go:88: /home/swarming/.swarming/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/scan/flags.go:185:5: error var flagParseError should have name of the form errFoo (ST1012)
        exit status 1
--- FAIL: TestStaticCheck (12.98s)
2024-03-06 21:45 x_vuln-go1.21-darwin-amd64-longtest vuln@334df71c release-branch.go1.21@63992def x/vuln.TestStaticCheck (log) 
=== RUN   TestStaticCheck
    all_test.go:88: /Users/swarming/.swarming/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/scan/flags.go:187:5: error var flagParseError should have name of the form errFoo (ST1012)
        exit status 1
--- FAIL: TestStaticCheck (13.02s)
2024-03-06 21:45 x_vuln-go1.21-linux-amd64-longtest vuln@334df71c release-branch.go1.21@63992def x/vuln.TestStaticCheck (log) 
=== RUN   TestStaticCheck
    all_test.go:88: /home/swarming/.swarming/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/scan/flags.go:187:5: error var flagParseError should have name of the form errFoo (ST1012)
        exit status 1
--- FAIL: TestStaticCheck (11.90s)
2024-03-06 21:45 x_vuln-go1.21-linux-amd64-longtest-race vuln@334df71c release-branch.go1.21@63992def x/vuln.TestStaticCheck (log) 
=== RUN   TestStaticCheck
    all_test.go:88: /home/swarming/.swarming/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/scan/flags.go:187:5: error var flagParseError should have name of the form errFoo (ST1012)
        exit status 1
--- FAIL: TestStaticCheck (18.79s)
2024-03-06 21:45 x_vuln-go1.22-darwin-amd64-longtest vuln@334df71c release-branch.go1.22@db6097f8 x/vuln.TestStaticCheck (log) 
=== RUN   TestStaticCheck
    all_test.go:88: /Users/swarming/.swarming/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/sys v0.3.0
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/mod v0.7.0
        internal/scan/flags.go:187:5: error var flagParseError should have name of the form errFoo (ST1012)
        exit status 1
--- FAIL: TestStaticCheck (13.52s)
2024-03-06 21:45 x_vuln-go1.22-linux-amd64-longtest vuln@334df71c release-branch.go1.22@db6097f8 x/vuln.TestStaticCheck (log) 
=== RUN   TestStaticCheck
    all_test.go:88: /home/swarming/.swarming/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/mod v0.7.0
        go: downloading golang.org/x/sys v0.3.0
        internal/scan/flags.go:187:5: error var flagParseError should have name of the form errFoo (ST1012)
        exit status 1
--- FAIL: TestStaticCheck (13.51s)
2024-03-06 21:45 x_vuln-go1.22-linux-amd64-longtest-race vuln@334df71c release-branch.go1.22@db6097f8 x/vuln.TestStaticCheck (log) 
=== RUN   TestStaticCheck
    all_test.go:88: /home/swarming/.swarming/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/mod v0.7.0
        go: downloading golang.org/x/sys v0.3.0
        internal/scan/flags.go:187:5: error var flagParseError should have name of the form errFoo (ST1012)
        exit status 1
--- FAIL: TestStaticCheck (18.54s)
2024-03-06 21:45 x_vuln-gotip-darwin-amd64-longtest vuln@334df71c go@70fbc882 x/vuln.TestStaticCheck (log) 
=== RUN   TestStaticCheck
    all_test.go:88: /Users/swarming/.swarming/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/scan/flags.go:187:5: error var flagParseError should have name of the form errFoo (ST1012)
        exit status 1
--- FAIL: TestStaticCheck (13.48s)
2024-03-06 21:45 x_vuln-gotip-linux-amd64-longtest vuln@334df71c go@70fbc882 x/vuln.TestStaticCheck (log) 
=== RUN   TestStaticCheck
    all_test.go:88: /home/swarming/.swarming/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/scan/flags.go:187:5: error var flagParseError should have name of the form errFoo (ST1012)
        exit status 1
--- FAIL: TestStaticCheck (11.95s)
2024-03-06 21:45 x_vuln-gotip-linux-amd64-longtest-race vuln@334df71c go@70fbc882 x/vuln.TestStaticCheck (log) 
=== RUN   TestStaticCheck
    all_test.go:88: /home/swarming/.swarming/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/scan/flags.go:187:5: error var flagParseError should have name of the form errFoo (ST1012)
        exit status 1
--- FAIL: TestStaticCheck (17.51s)
2024-03-06 21:45 x_vuln-go1.21-darwin-amd64-longtest vuln@b51a8ac3 release-branch.go1.21@63992def x/vuln.TestStaticCheck (log) 
=== RUN   TestStaticCheck
    all_test.go:88: /Users/swarming/.swarming/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/scan/flags.go:187:5: error var flagParseError should have name of the form errFoo (ST1012)
        exit status 1
--- FAIL: TestStaticCheck (13.43s)
2024-03-06 21:45 x_vuln-go1.21-linux-amd64-longtest vuln@b51a8ac3 release-branch.go1.21@63992def x/vuln.TestStaticCheck (log) 
=== RUN   TestStaticCheck
    all_test.go:88: /home/swarming/.swarming/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/scan/flags.go:187:5: error var flagParseError should have name of the form errFoo (ST1012)
        exit status 1
--- FAIL: TestStaticCheck (12.79s)
2024-03-06 21:45 x_vuln-go1.21-linux-amd64-longtest-race vuln@b51a8ac3 release-branch.go1.21@63992def x/vuln.TestStaticCheck (log) 
=== RUN   TestStaticCheck
    all_test.go:88: /home/swarming/.swarming/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/scan/flags.go:187:5: error var flagParseError should have name of the form errFoo (ST1012)
        exit status 1
--- FAIL: TestStaticCheck (18.11s)
2024-03-06 21:45 x_vuln-go1.22-darwin-amd64-longtest vuln@b51a8ac3 release-branch.go1.22@db6097f8 x/vuln.TestStaticCheck (log) 
=== RUN   TestStaticCheck
    all_test.go:88: /Users/swarming/.swarming/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/scan/flags.go:187:5: error var flagParseError should have name of the form errFoo (ST1012)
        exit status 1
--- FAIL: TestStaticCheck (10.04s)
2024-03-06 21:45 x_vuln-go1.22-linux-amd64-longtest vuln@b51a8ac3 release-branch.go1.22@db6097f8 x/vuln.TestStaticCheck (log) 
=== RUN   TestStaticCheck
    all_test.go:88: /home/swarming/.swarming/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/scan/flags.go:187:5: error var flagParseError should have name of the form errFoo (ST1012)
        exit status 1
--- FAIL: TestStaticCheck (12.51s)
2024-03-06 21:45 x_vuln-go1.22-linux-amd64-longtest-race vuln@b51a8ac3 release-branch.go1.22@db6097f8 x/vuln.TestStaticCheck (log) 
=== RUN   TestStaticCheck
    all_test.go:88: /home/swarming/.swarming/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/scan/flags.go:187:5: error var flagParseError should have name of the form errFoo (ST1012)
        exit status 1
--- FAIL: TestStaticCheck (18.29s)
2024-03-06 21:45 x_vuln-gotip-darwin-amd64-longtest vuln@b51a8ac3 go@70fbc882 x/vuln.TestStaticCheck (log) 
=== RUN   TestStaticCheck
    all_test.go:88: /Volumes/Work/s/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/scan/flags.go:187:5: error var flagParseError should have name of the form errFoo (ST1012)
        exit status 1
--- FAIL: TestStaticCheck (10.83s)
2024-03-06 21:45 x_vuln-gotip-linux-amd64-longtest vuln@b51a8ac3 go@70fbc882 x/vuln.TestStaticCheck (log) 
=== RUN   TestStaticCheck
    all_test.go:88: /home/swarming/.swarming/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/scan/flags.go:187:5: error var flagParseError should have name of the form errFoo (ST1012)
        exit status 1
--- FAIL: TestStaticCheck (14.49s)
2024-03-06 21:45 x_vuln-gotip-linux-amd64-longtest-race vuln@b51a8ac3 go@70fbc882 x/vuln.TestStaticCheck (log) 
=== RUN   TestStaticCheck
    all_test.go:88: /home/swarming/.swarming/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        internal/scan/flags.go:187:5: error var flagParseError should have name of the form errFoo (ST1012)
        exit status 1
--- FAIL: TestStaticCheck (20.68s)

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/vuln" && test == "TestStaticCheck"
2024-03-28 20:35 linux-386-longtest vuln@efaa3cef go@8f618c1f x/vuln.TestStaticCheck (log) 
--- FAIL: TestStaticCheck (14.11s)
    all_test.go:88: /workdir/go/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        cmd/govulncheck/test_utils.go:121:9: unnecessary assignment to the blank identifier (S1005)
        exit status 1
2024-03-28 20:35 linux-386-longtest vuln@efaa3cef go@3f90ba7f x/vuln.TestStaticCheck (log) 
--- FAIL: TestStaticCheck (8.95s)
    all_test.go:88: /workdir/go/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        cmd/govulncheck/test_utils.go:121:9: unnecessary assignment to the blank identifier (S1005)
        exit status 1
2024-03-28 20:35 linux-386-longtest vuln@efaa3cef go@33fd95b8 x/vuln.TestStaticCheck (log) 
--- FAIL: TestStaticCheck (14.48s)
    all_test.go:88: /workdir/go/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        cmd/govulncheck/test_utils.go:121:9: unnecessary assignment to the blank identifier (S1005)
        exit status 1
2024-03-28 20:35 linux-amd64-longtest vuln@efaa3cef go@8f618c1f x/vuln.TestStaticCheck (log) 
--- FAIL: TestStaticCheck (14.35s)
    all_test.go:88: /workdir/go/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        cmd/govulncheck/test_utils.go:121:9: unnecessary assignment to the blank identifier (S1005)
        exit status 1
2024-03-28 20:35 linux-amd64-longtest vuln@efaa3cef go@3f90ba7f x/vuln.TestStaticCheck (log) 
--- FAIL: TestStaticCheck (12.63s)
    all_test.go:88: /workdir/go/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        cmd/govulncheck/test_utils.go:121:9: unnecessary assignment to the blank identifier (S1005)
        exit status 1
2024-03-28 20:35 linux-amd64-longtest vuln@efaa3cef go@33fd95b8 x/vuln.TestStaticCheck (log) 
--- FAIL: TestStaticCheck (15.56s)
    all_test.go:88: /workdir/go/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/mod v0.7.0
        go: downloading golang.org/x/sys v0.3.0
        cmd/govulncheck/test_utils.go:121:9: unnecessary assignment to the blank identifier (S1005)
        exit status 1
2024-03-28 20:35 linux-amd64-longtest-race vuln@efaa3cef go@8f618c1f x/vuln.TestStaticCheck (log) 
--- FAIL: TestStaticCheck (14.40s)
    all_test.go:88: /workdir/go/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        cmd/govulncheck/test_utils.go:121:9: unnecessary assignment to the blank identifier (S1005)
        exit status 1
2024-03-28 20:35 linux-amd64-longtest-race vuln@efaa3cef go@3f90ba7f x/vuln.TestStaticCheck (log) 
--- FAIL: TestStaticCheck (25.30s)
    all_test.go:88: /workdir/go/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        cmd/govulncheck/test_utils.go:121:9: unnecessary assignment to the blank identifier (S1005)
        exit status 1
2024-03-28 20:35 linux-amd64-longtest-race vuln@efaa3cef go@33fd95b8 x/vuln.TestStaticCheck (log) 
--- FAIL: TestStaticCheck (26.35s)
    all_test.go:88: /workdir/go/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        cmd/govulncheck/test_utils.go:121:9: unnecessary assignment to the blank identifier (S1005)
        exit status 1
2024-03-28 20:35 linux-arm64-longtest vuln@efaa3cef go@8f618c1f x/vuln.TestStaticCheck (log) 
--- FAIL: TestStaticCheck (8.01s)
    all_test.go:88: /tmp/workdir/go/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        cmd/govulncheck/test_utils.go:121:9: unnecessary assignment to the blank identifier (S1005)
        exit status 1
2024-03-28 20:35 linux-arm64-longtest vuln@efaa3cef go@3f90ba7f x/vuln.TestStaticCheck (log) 
--- FAIL: TestStaticCheck (8.28s)
    all_test.go:88: /tmp/workdir/go/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        cmd/govulncheck/test_utils.go:121:9: unnecessary assignment to the blank identifier (S1005)
        exit status 1
2024-03-28 20:35 linux-arm64-longtest vuln@efaa3cef go@33fd95b8 x/vuln.TestStaticCheck (log) 
--- FAIL: TestStaticCheck (8.02s)
    all_test.go:88: /tmp/workdir/go/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        cmd/govulncheck/test_utils.go:121:9: unnecessary assignment to the blank identifier (S1005)
        exit status 1

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/vuln" && test == "TestStaticCheck"
2024-03-28 20:35 darwin-amd64-longtest vuln@efaa3cef go@33fd95b8 x/vuln.TestStaticCheck (log) 
--- FAIL: TestStaticCheck (46.23s)
    all_test.go:88: /tmp/buildlet/go/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        cmd/govulncheck/test_utils.go:121:9: unnecessary assignment to the blank identifier (S1005)
        exit status 1

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/vuln" && test == "TestStaticCheck"
2024-03-28 20:35 darwin-amd64-longtest vuln@efaa3cef go@8f618c1f x/vuln.TestStaticCheck (log) 
--- FAIL: TestStaticCheck (27.61s)
    all_test.go:88: /tmp/buildlet/go/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        cmd/govulncheck/test_utils.go:121:9: unnecessary assignment to the blank identifier (S1005)
        exit status 1

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/vuln" && test == "TestStaticCheck"
2024-03-28 20:35 darwin-amd64-longtest vuln@efaa3cef go@3f90ba7f x/vuln.TestStaticCheck (log) 
--- FAIL: TestStaticCheck (35.05s)
    all_test.go:88: /tmp/buildlet/go/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        cmd/govulncheck/test_utils.go:121:9: unnecessary assignment to the blank identifier (S1005)
        exit status 1

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/vuln" && test == "TestStaticCheck"
2024-03-28 20:35 x_vuln-go1.21-darwin-amd64-longtest vuln@efaa3cef release-branch.go1.21@30d85506 x/vuln.TestStaticCheck (log) 
=== RUN   TestStaticCheck
    all_test.go:88: /Users/swarming/.swarming/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        cmd/govulncheck/test_utils.go:121:9: unnecessary assignment to the blank identifier (S1005)
        exit status 1
--- FAIL: TestStaticCheck (10.52s)
2024-03-28 20:35 x_vuln-go1.21-linux-amd64-longtest vuln@efaa3cef release-branch.go1.21@30d85506 x/vuln.TestStaticCheck (log) 
=== RUN   TestStaticCheck
    all_test.go:88: /home/swarming/.swarming/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        cmd/govulncheck/test_utils.go:121:9: unnecessary assignment to the blank identifier (S1005)
        exit status 1
--- FAIL: TestStaticCheck (13.14s)
2024-03-28 20:35 x_vuln-go1.21-linux-amd64-longtest-race vuln@efaa3cef release-branch.go1.21@30d85506 x/vuln.TestStaticCheck (log) 
=== RUN   TestStaticCheck
    all_test.go:88: /home/swarming/.swarming/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        cmd/govulncheck/test_utils.go:121:9: unnecessary assignment to the blank identifier (S1005)
        exit status 1
--- FAIL: TestStaticCheck (21.09s)
2024-03-28 20:35 x_vuln-go1.22-darwin-amd64-longtest vuln@efaa3cef release-branch.go1.22@4edf4bb2 x/vuln.TestStaticCheck (log) 
=== RUN   TestStaticCheck
    all_test.go:88: /Volumes/Work/s/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        cmd/govulncheck/test_utils.go:121:9: unnecessary assignment to the blank identifier (S1005)
        exit status 1
--- FAIL: TestStaticCheck (16.93s)
2024-03-28 20:35 x_vuln-go1.22-linux-amd64-longtest vuln@efaa3cef release-branch.go1.22@4edf4bb2 x/vuln.TestStaticCheck (log) 
=== RUN   TestStaticCheck
    all_test.go:88: /home/swarming/.swarming/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        cmd/govulncheck/test_utils.go:121:9: unnecessary assignment to the blank identifier (S1005)
        exit status 1
--- FAIL: TestStaticCheck (13.03s)
2024-03-28 20:35 x_vuln-go1.22-linux-amd64-longtest-race vuln@efaa3cef release-branch.go1.22@4edf4bb2 x/vuln.TestStaticCheck (log) 
=== RUN   TestStaticCheck
    all_test.go:88: /home/swarming/.swarming/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        cmd/govulncheck/test_utils.go:121:9: unnecessary assignment to the blank identifier (S1005)
        exit status 1
--- FAIL: TestStaticCheck (21.24s)
2024-03-28 20:35 x_vuln-gotip-darwin-amd64-longtest vuln@efaa3cef go@3f90ba7f x/vuln.TestStaticCheck (log) 
=== RUN   TestStaticCheck
    all_test.go:88: /Users/swarming/.swarming/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        cmd/govulncheck/test_utils.go:121:9: unnecessary assignment to the blank identifier (S1005)
        exit status 1
--- FAIL: TestStaticCheck (23.94s)
2024-03-28 20:35 x_vuln-gotip-linux-amd64-longtest vuln@efaa3cef go@8f618c1f x/vuln.TestStaticCheck (log) 
=== RUN   TestStaticCheck
    all_test.go:88: /home/swarming/.swarming/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        cmd/govulncheck/test_utils.go:121:9: unnecessary assignment to the blank identifier (S1005)
        exit status 1
--- FAIL: TestStaticCheck (14.08s)
2024-03-28 20:35 x_vuln-gotip-linux-amd64-longtest-race vuln@efaa3cef go@8f618c1f x/vuln.TestStaticCheck (log) 
=== RUN   TestStaticCheck
    all_test.go:88: /home/swarming/.swarming/w/ir/x/w/goroot/bin/go run honnef.co/go/tools/cmd/staticcheck@v0.4.3 ./...: exit status 1
        go: downloading honnef.co/go/tools v0.4.3
        go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
        go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
        go: downloading github.com/BurntSushi/toml v1.2.1
        go: downloading golang.org/x/sys v0.3.0
        go: downloading golang.org/x/mod v0.7.0
        cmd/govulncheck/test_utils.go:121:9: unnecessary assignment to the blank identifier (S1005)
        exit status 1
--- FAIL: TestStaticCheck (22.45s)

— watchflakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zpavlinovic zpavlinovic

Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Projects
Test Flakes
Status: Done
Milestone
vuln/unplanned
Development

No branches or pull requests
2 participants
@zpavlinovic @gopherbot