-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build: productionize coverage that golangbuild provides for main + golang.org/x repos #60666
Comments
Change https://go.dev/cl/508276 mentions this issue: |
It worked in https://ci.chromium.org/b/8776284364679766577. Turn it on in x/build as a first step in a gradual rollout. For golang/go#60666. Change-Id: I00296436c52faf0f4b6738bbd7cd035a8a37ce7c Reviewed-on: https://go-review.googlesource.com/c/build/+/508276 Reviewed-by: Heschi Kreinick <heschi@google.com> TryBot-Bypass: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
By now I think all of the shortcuts we've taken during the prototyping stage that have reduced test coverage have been addressed, such that we can rely on test coverage provided by golangbuild not to drop compared to what we have today with x/build's cmd/coordinator. There are some remaining nice-to-haves (such as test result streaming, keep-going in main repo), finishing checks (e.g., no-network check still needs to be turned up for main repo), some adjacent issues (such as #37827 that are more relevant to builder configuration policy), and some lower-priority exotic edge cases (empty repo, top-level module not having go.mod file, etc.). They can all be better tracked in other individual issues, so closing this as done. Done:
|
golangbuild
, our LUCI Executable ("luciexe") command intentionally limited scope during the LUCI prototype stage: it left out some known test coverage that we wish to have and is provided by the current build system (plus some more we'd like to add, such as #34352), to be done after the prototype.This is the tracking issue to address the remaining gaps in test coverage and get it to a point where it's viable to switch over to relying on it as the canonical source of Go project testing. This applies for the main Go repo and the golang.org/x repos, and most of the remaining work is in the latter category (e.g., running tests for nested modules, etc.).
CC @golang/release, @mknyszek.
The text was updated successfully, but these errors were encountered: