Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/cgo: only create _cgo_flags for -compiler=gccgo #60642

Closed
ianlancetaylor opened this issue Jun 6, 2023 · 1 comment
Closed

cmd/cgo: only create _cgo_flags for -compiler=gccgo #60642

ianlancetaylor opened this issue Jun 6, 2023 · 1 comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. ToolSpeed
Milestone
Go1.22

Comments

@ianlancetaylor
Copy link
Member

Currently cmd/cgo creates a _cgo_flags file every time it is run. However, that file is only used when cmd/go is invoked with -compiler=gccgo. In the default case we should stop generating _cgo_flags, as it is wasted effort.
@ianlancetaylor ianlancetaylor added the NeedsFix The path to resolution is known, but the work has not been done. label Jun 6, 2023
@ianlancetaylor ianlancetaylor added this to the Go1.22 milestone Jun 6, 2023
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jun 6, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/524556 mentions this issue: cmd/cgo: only write _cgo_flags for gccgo

@github-project-automation github-project-automation bot moved this from Todo to Done in Go Compiler / Runtime Aug 30, 2023
@golang golang locked and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. ToolSpeed
Projects
None yet
Milestone
Go1.22
Development

No branches or pull requests
3 participants
@ianlancetaylor @bcmills @gopherbot