Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/pprof: skip TestDisasm flaky failures on linux/arm64 [1.19 backport] #60637

Closed
mknyszek opened this issue Jun 6, 2023 · 3 comments
Closed

cmd/pprof: skip TestDisasm flaky failures on linux/arm64 [1.19 backport] #60637

mknyszek opened this issue Jun 6, 2023 · 3 comments
Assignees
@cherrymui
Labels
arch-arm64 CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. OS-Linux Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.19.11

Comments

@mknyszek
Copy link
Contributor

mknyszek commented Jun 6, 2023

Example failure: https://storage.googleapis.com/go-build-log/494193b0/linux-arm64_396f56ff.log

Possibly related to #47024.
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jun 6, 2023
@mknyszek mknyszek added this to the Go1.19.11 milestone Jun 7, 2023
@mknyszek
Copy link
Contributor Author

mknyszek commented Jun 7, 2023

According to @cherrymui #56574 is likely related. She fixed it for Go 1.20. But 1.19 is also going out of support soon. Maybe we just add a test skip?

@cherrymui cherrymui added the CherryPickCandidate Used during the release process for point releases label Jun 8, 2023
@gopherbot
Copy link

Change https://go.dev/cl/501824 mentions this issue: [release-branch.go1.19] cmd/pprof: skip TestDisasm on ARM64

@prattmic prattmic added the CherryPickApproved Used during the release process for point releases label Jun 14, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jun 14, 2023
@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Jun 14, 2023
@dmitshur dmitshur changed the title cmd/pprof: TestDisasm flake on linux/arm64 on Go 1.19.x cmd/pprof: skip TestDisasm flaky failures on linux/arm64 [1.19 backport] Jun 19, 2023
@gopherbot
Copy link

Closed by merging 606a5a6 to release-branch.go1.19.

gopherbot pushed a commit that referenced this issue Jun 19, 2023
@cherrymui @gopherbot
[release-branch.go1.19] cmd/pprof: skip TestDisasm on ARM64
606a5a6 
The test is fixed at tip, but it is non-trivial enough to backport
to (potentionally the last) Go 1.19 minor release. Skip the test.

Fixes #60637.

Change-Id: I0425b703a5270b680346b63ab38c47b890a3a3bf
Reviewed-on: https://go-review.googlesource.com/c/go/+/501824
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cherrymui cherrymui

Labels
arch-arm64 CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. OS-Linux Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.19.11
Development

No branches or pull requests
5 participants
@mknyszek @prattmic @dmitshur @gopherbot @cherrymui