Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: missing references to methods on generic types #60622

Closed
findleyr opened this issue Jun 6, 2023 · 2 comments
Closed

x/tools/gopls: missing references to methods on generic types #60622

findleyr opened this issue Jun 6, 2023 · 2 comments
Assignees
@adonovan
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.13.0

Comments

@findleyr
Copy link
Contributor

findleyr commented Jun 6, 2023

Repro:

CC @adonovan
@findleyr findleyr added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 6, 2023
@findleyr findleyr added this to the gopls/v0.12.3 milestone Jun 6, 2023
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jun 6, 2023
@adonovan
Copy link
Member

The root cause is failure of objectpath.For for the MustUnwrap method object during index construction (xrefs.Index).

@gopherbot
Copy link

Change https://go.dev/cl/506939 mentions this issue: gopls/internal/lsp/source/xrefs: include refs to methods of generics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adonovan adonovan

Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.13.0
Development

No branches or pull requests
3 participants
@adonovan @gopherbot @findleyr