Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/telemetry: tests fail for openbsd #60614

Open
pjweinb opened this issue Jun 5, 2023 · 2 comments
Open

x/telemetry: tests fail for openbsd #60614

pjweinb opened this issue Jun 5, 2023 · 2 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. telemetry x/telemetry issues
Milestone

Comments

@pjweinb
Copy link

pjweinb commented Jun 5, 2023

This is a placeholder to note that in the telemetry package, two tests are skipped if runtime.GOOS is openbsd.

@gopherbot gopherbot added this to the Unreleased milestone Jun 5, 2023
@jamalc jamalc added the telemetry x/telemetry issues label Jun 8, 2023
@prattmic prattmic added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 12, 2023
@findleyr
Copy link
Member

findleyr commented Jun 4, 2024

Here is a CL with failing tests: https://go.dev/cl/589939

@lcheylus
Copy link

Additional tests to fix this support of x/telemetry on OpenBSD.

  • Clone x/telemetry sources from https://go.googlesource.com/telemetry

  • OK Build telemetry on OpenBSD/amd64 (current version) with Go 1.23.1 (package/port go installed for OpenBSD/amd64)

  • Patch internal/telemetry/dir.go to enable OpenBSD platform:

--- /tmp/dir.go.orig    Thu Sep 26 15:21:22 2024
+++ /tmp/dir.go Thu Sep 26 15:21:09 2024
@@ -152,7 +152,7 @@
 // TODO(rfindley): move to a more appropriate file.
 const DisabledOnPlatform = false ||
        // The following platforms could potentially be supported in the future:
-       runtime.GOOS == "openbsd" || // #60614
+       // runtime.GOOS == "openbsd" || // #60614
        runtime.GOOS == "solaris" || // #60968 #60970
        runtime.GOOS == "android" || // #60967
        runtime.GOOS == "illumos" || // #65544
  • Tests failure in internal/counter
$ cd internal/counter
$ go test | grep FAIL
--- FAIL: TestBasic (0.00s)
--- FAIL: TestMissingLocalDir (0.02s)
--- FAIL: TestParallel (0.01s)
--- FAIL: TestLarge (0.07s)
--- FAIL: TestStack (0.00s)
--- FAIL: TestRotateCounters (0.02s)
FAIL
FAIL    golang.org/x/telemetry/internal/counter 2.849s

Full log tests failure in internal/counter with go test: telemetry-test.log

After some analysis/debug, it seems than there is an issue with:

  • Parse function in internal/counter/parse.go
  • ReadStack function in internal/counter/stackcounter.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. telemetry x/telemetry issues
Projects
None yet
Development

No branches or pull requests

6 participants