Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: TestServeFileNotModified failures #60609

Closed
gopherbot opened this issue Jun 5, 2023 · 3 comments
Closed

net/http: TestServeFileNotModified failures #60609

gopherbot opened this issue Jun 5, 2023 · 3 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "net/http" && test == "TestServeFileNotModified"

Issue created automatically to collect these failures.

Example (log):

1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
--- FAIL: TestServeFileNotModified (0.00s)
    --- FAIL: TestServeFileNotModified/h2 (4.29s)
        clientserver_test.go:210: server log: timeout waiting for SETTINGS frames from 127.0.0.1:57105
        fs_test.go:625: Get "https://127.0.0.1:57104": unexpected EOF
1 second passes in backend, proxygone= false

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 5, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestServeFileNotModified"
2023-06-05 03:11 freebsd-arm-paulzhol go@96d16803 net/http.TestServeFileNotModified (log) 
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
--- FAIL: TestServeFileNotModified (0.00s)
    --- FAIL: TestServeFileNotModified/h2 (4.29s)
        clientserver_test.go:210: server log: timeout waiting for SETTINGS frames from 127.0.0.1:57105
        fs_test.go:625: Get "https://127.0.0.1:57104": unexpected EOF
1 second passes in backend, proxygone= false

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented Jun 13, 2023

(attn @neild)

Is there some reason the SETTINGS frame timeout needs to be so short? Seems like this could just be a slow builder.

@bcmills bcmills added this to the Backlog milestone Jun 13, 2023
@bcmills
Copy link
Contributor

bcmills commented Jun 13, 2023

Duplicate of #60359

@bcmills bcmills marked this as a duplicate of #60359 Jun 13, 2023
@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@bcmills @gopherbot