Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: typerefs: move BuildPackageGraph into tests #60598

Closed
adonovan opened this issue Jun 5, 2023 · 1 comment
Closed

x/tools/gopls: typerefs: move BuildPackageGraph into tests #60598

adonovan opened this issue Jun 5, 2023 · 1 comment
Assignees
@adonovan
Labels
gopls Issues related to the Go language server, gopls.
Milestone
gopls/v0.14.0

Comments

@adonovan
Copy link
Member

adonovan commented Jun 5, 2023 •
edited

The BuildPackageGraph function, and many related ones, are used only from the test, though it is hard to deduce that (and it looks like production code). The reason is that this package was designed test-first, with instructions for how to productionize it; that has since been done.

We should move it all the test-only code into a _test.go file, for clarity.
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jun 5, 2023
@adonovan adonovan removed the Tools This label describes issues relating to any tools in the x/tools repository. label Jun 5, 2023
@gopherbot gopherbot added this to the Unreleased milestone Jun 5, 2023
@adonovan adonovan self-assigned this Jun 5, 2023
@findleyr findleyr modified the milestones: Unreleased, gopls/v0.13.0 Jun 5, 2023
@gopherbot
Copy link

Change https://go.dev/cl/502536 mentions this issue: gopls/internal/lsp/source/typerefs: move test into _test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adonovan adonovan

Labels
gopls Issues related to the Go language server, gopls.
Projects
None yet
Milestone
gopls/v0.14.0
Development

No branches or pull requests
3 participants
@adonovan @gopherbot @findleyr