Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: doc of FormValue does not mention PATCH #60585

Closed
gazerro opened this issue Jun 3, 2023 · 4 comments
Closed

net/http: doc of FormValue does not mention PATCH #60585

gazerro opened this issue Jun 3, 2023 · 4 comments
Labels
Documentation NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Comments

@gazerro
Copy link
Contributor

gazerro commented Jun 3, 2023

The documentation of the (*Request).FormValue method does not mention the PATCH method:

// POST and PUT body parameters take precedence over URL query string values.

It should be:

// POST, PATCH, and PUT body parameters take precedence over URL query string values.

Similarly, commit 0979767 fixed PostFormValue.
@dr2chase dr2chase added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 5, 2023
@dr2chase
Copy link
Contributor

dr2chase commented Jun 5, 2023

@neild @rsc

@shani34
Copy link

shani34 commented Jul 5, 2023

Hi everyone , can someone /assing this issue to me

eduardbme added a commit to eduardbme/go that referenced this issue Jul 26, 2023
@eduardbme
net/http: fix doc comment on FormValue function
3a477ea 
This function checks Request.Form, which now includes values parsed
from a PATCH request.

Fixes golang#60585
@eduardbme eduardbme mentioned this issue Jul 26, 2023
Closed
@gopherbot
Copy link

Change https://go.dev/cl/513435 mentions this issue: net/http: fix doc comment on FormValue function

@eduardbme
Copy link
Contributor

Both Request.PostFormValue and Request.FormValue referring to Request.ParseForm, so it's seems like a valid improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

net/http: fix doc comment on FormValue function eduardbme/go
6 participants
@gazerro @dr2chase @gopherbot @eduardbme @seankhliao @shani34