Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: release version v0.12.1 = v0.12.2 #60563

Closed
8 of 9 tasks
findleyr opened this issue Jun 1, 2023 · 6 comments
Closed
8 of 9 tasks

x/tools/gopls: release version v0.12.1 = v0.12.2 #60563

findleyr opened this issue Jun 1, 2023 · 6 comments
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.12.1

Comments

@findleyr
Copy link
Contributor

findleyr commented Jun 1, 2023 •
edited by adonovan

This issue tracks progress toward releasing gopls@v0.12.1.

  • merge master into gopls-release-branch.0.12
  • update hard-coded version
  • update go.mod/go.sum (remove x/tools replace, update x/tools version)
  • tag gopls/v0.12.1-pre.1
  • update Github milestone
  • write release notes
  • smoke test features
  • tag gopls/v0.12.1 https://github.com/golang/tools/releases/tag/gopls%2Fv0.12.1
  • update dependencies in master for the next release

NOTE: As a defensive measure for an incident during the release, we also released v0.12.2 as an alias for v0.12.1. The tools are identical and report their version as v0.12.1. (We are investigating.)
@findleyr findleyr added this to the gopls/v0.12.1 milestone Jun 1, 2023
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jun 1, 2023
@gopherbot
Copy link

Change https://go.dev/cl/500056 mentions this issue: all: merge master (86c93e8) into gopls-release-branch.0.12

@gopherbot
Copy link

Change https://go.dev/cl/500057 mentions this issue: internal/lsp/debug: update hard-coded version for v0.12.1

gopherbot pushed a commit to golang/tools that referenced this issue Jun 1, 2023
@findleyr
all: merge master (86c93e8) into gopls-release-branch.0.12
e31f9e9 
Also add back the x/tools replace directive.

For golang/go#60563

Merge List:

+ 2023-06-01 86c93e8 gopls: unimported completion should use the completion matcher
+ 2023-06-01 04ceacb gopls/internal/lsp/source: fix panic in typeDefinition on comparable
+ 2023-06-01 947adca gopls/internal/lsp/source/methodsets: comparable also has no package
+ 2023-06-01 c35c44f gopls/internal/lsp/cache: add assertions
+ 2023-06-01 0b4461b internal/diff: fix LineEdits bug in slow path
+ 2023-06-01 1943c1e internal/diff: fix LineEdits bug in fast path
+ 2023-06-01 c6d86c4 go/pointer: delete package
+ 2023-06-01 77fd064 go/types/objectpath: remove unnecessary unsafe import
+ 2023-06-01 0dda7d6 go/pointer: remove replace directive
+ 2023-05-31 98f1b4d gopls/internal/lsp/cache: check number of orphaned files after filtering
+ 2023-05-31 a260315 go/pointer: create submodule
+ 2023-05-31 96844c3 cmd/{guru,callgraph}: stop using go/pointer
+ 2023-05-31 cd694d8 go/packages: include "unsafe".GoFiles=["unsafe.go"]
+ 2023-05-30 33c741d gopls/internal/lsp: add min/max builtin
+ 2023-05-30 933c7cc internal/lsp/source: use exact match in import highlighting
+ 2023-05-26 5974258 gopls/internal/lsp: clear vuln diagnostics on config changes
+ 2023-05-26 f3faea1 go/packages: pass -pgo=off on go1.21 and later
+ 2023-05-26 5f74ec7 internal/lsp/debug: add links to profiles and GC
+ 2023-05-25 ed90c6d internal/diff: unexport various identifiers
+ 2023-05-25 827f5aa gopls/internal/lsp/source: test references bug on struct{p.T}
+ 2023-05-24 a12e1a6 go/ssa/interp: implement min/max builtins

Change-Id: I1987a4b6f6d3b2727976a7a8f5766921738eb7f7
gopherbot pushed a commit to golang/tools that referenced this issue Jun 1, 2023
@findleyr
internal/lsp/debug: update hard-coded version for v0.12.1
41a7dc7 
For golang/go#60563

Change-Id: Ia24ed24a72e7fa55a21d793d9419bfc1570b1267
Reviewed-on: https://go-review.googlesource.com/c/tools/+/500057
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Bypass: Robert Findley <rfindley@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
@gopherbot
Copy link

Change https://go.dev/cl/500058 mentions this issue: gopls: update go.mod for v0.12.1

gopherbot pushed a commit to golang/tools that referenced this issue Jun 1, 2023
@findleyr
gopls: update go.mod for v0.12.1
e839744 
Remove the replace directive and update x/tools.

For golang/go#60563

Change-Id: I6c2a4d750cd98c56b3baaa907ce7d6e2d890b4fc
Reviewed-on: https://go-review.googlesource.com/c/tools/+/500058
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
@findleyr findleyr modified the milestones: gopls/v0.12.1, gopls/v0.12.2 Jun 2, 2023
@adonovan adonovan changed the title x/tools/gopls: release version v0.12.1 x/tools/gopls: release version v0.12.1 = v0.12.2 Jun 2, 2023
@adonovan adonovan closed this as completed Jun 2, 2023
@adonovan
Copy link
Member

adonovan commented Jun 2, 2023 

$ go run golang.org/x/tools/gopls@latest version
golang.org/x/tools/gopls v0.12.1
    golang.org/x/tools/gopls@v0.12.2 h1:s4mznBqCHVHeuTYjxGYJhsW3Wp4FYon8YAqiJlwlpTY=

@justfalter
Copy link

justfalter commented Jun 2, 2023 •
edited

NOTE: As a defensive measure for an incident during the release, we also released v0.12.2 as an alias for v0.12.1. The tools are identical and report their version as v0.12.1. (We are investigating.)

@findleyr @adonovan Any update on this investigation or the nature of the incident? Is this security-related?

@adonovan
Copy link
Member

adonovan commented Jun 2, 2023

Any update on this investigation or the nature of the incident? Is this security-related?

Not security related. The sumdb was briefly serving a cached 404 for the v0.12.1 release, preventing download of that module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.12.1
Development

No branches or pull requests
4 participants
@justfalter @adonovan @gopherbot @findleyr