Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/internal/task: TestAnnounceRelease failures #60541

Closed
gopherbot opened this issue May 31, 2023 · 3 comments
Closed

x/build/internal/task: TestAnnounceRelease failures #60541

gopherbot opened this issue May 31, 2023 · 3 comments
Assignees
@dmitshur
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unreleased

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "golang.org/x/build/internal/task" && test == "TestAnnounceRelease"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestAnnounceRelease (6.15s)
    --- FAIL: TestAnnounceRelease/minor (6.15s)
        announce_test.go:268: task function returned non-nil error: stopping early due to error checking for an existing Google Groups thread: did not get acceptable status code: 500 Internal Server Error body: "<html lang=en><meta charset=utf-8><meta name=viewport content=\"initial-scale=1, minimum-scale=1, width=device-width\"><title>Error 500 (Server Error)!!1</title><style nonce=\"XpIID1qMa_IQPOWo6RpA6Q\">*{margin:0;padding:0}html,code{font:15px/22px arial,sans-serif}html{background:#fff;color:#222;padding:15px}body{color:#222;text-align:unset;margin:7% auto 0;max-width:390px;min-height:180px;padding:30px 0 15px;}* > body{background:url(//www.google.com/images/errors/robot.png) 100% 5px no-repeat;padding-right:205px}p{margin:11px 0 22px;overflow:hidden}pre{white-space:pre-wrap;}ins{color:#777;text-decoration:none}a img{border:0}@media screen and (max-width:772px){body{background:none;margin-top:0;max-width:none;padding-right:0}}#logo{background:url(//www.google.com/images/branding/googlelogo/1x/googlelogo_color_150x54dp.png) no-repeat;margin-left:-5px}@media only screen and (min-resolution:192dpi){#logo{background:url(//www.google.com/images/branding/googlelogo/2x/googlelogo_color_150x54dp.png) no-repeat 0% 0%/100% 100%;-moz-border-image:url(//www.google.com/images/branding/googlelogo/2x/googlelogo_color_150x54dp.png) 0}}@media only screen and (-webkit-min-device-pixel-ratio:2){#logo{background:url(//www.google.com/images/branding/googlelogo/2x/googlelogo_color_150x54dp.png) no-repeat;-webkit-background-size:100% 100%}}#logo{display:inline-block;height:54px;width:150px}</style><main id=\"af-error-container\" role=\"main\"><a href=//www.google.com><span id=logo aria-label=Google role=img></span></a><p><b>500.</b> <ins>That’s an error.</ins><p>There was an error. Please try again later. <ins>That’s all we know.</ins></main>"
2023/05/31 19:27:21 extracted tarball into /workdir/tmp/TestTagXRepos2037754116/001/linux-amd64-longtest/0: 1 files, 1 dirs (341.23µs)
2023/05/31 19:27:21 extracted tarball into /workdir/tmp/TestTagXRepos2037754116/001/linux-amd64-longtest/0/repo: 4 files, 2 dirs (181.24µs)
2023/05/31 19:27:21 extracted tarball into /workdir/tmp/TestTagSingleRepo1185458338/001/linux-amd64-longtest/0: 1 files, 1 dirs (299.14µs)
2023/05/31 19:27:21 extracted tarball into /workdir/tmp/TestTagSingleRepo1185458338/001/linux-amd64-longtest/0/repo: 3 files, 1 dirs (172.16µs)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 31, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/build/internal/task" && test == "TestAnnounceRelease"
2023-05-31 15:16 linux-amd64-longtest build@756b7f55 go@4406e8ef x/build/internal/task.TestAnnounceRelease (log) 
--- FAIL: TestAnnounceRelease (6.15s)
    --- FAIL: TestAnnounceRelease/minor (6.15s)
        announce_test.go:268: task function returned non-nil error: stopping early due to error checking for an existing Google Groups thread: did not get acceptable status code: 500 Internal Server Error body: "<html lang=en><meta charset=utf-8><meta name=viewport content=\"initial-scale=1, minimum-scale=1, width=device-width\"><title>Error 500 (Server Error)!!1</title><style nonce=\"XpIID1qMa_IQPOWo6RpA6Q\">*{margin:0;padding:0}html,code{font:15px/22px arial,sans-serif}html{background:#fff;color:#222;padding:15px}body{color:#222;text-align:unset;margin:7% auto 0;max-width:390px;min-height:180px;padding:30px 0 15px;}* > body{background:url(//www.google.com/images/errors/robot.png) 100% 5px no-repeat;padding-right:205px}p{margin:11px 0 22px;overflow:hidden}pre{white-space:pre-wrap;}ins{color:#777;text-decoration:none}a img{border:0}@media screen and (max-width:772px){body{background:none;margin-top:0;max-width:none;padding-right:0}}#logo{background:url(//www.google.com/images/branding/googlelogo/1x/googlelogo_color_150x54dp.png) no-repeat;margin-left:-5px}@media only screen and (min-resolution:192dpi){#logo{background:url(//www.google.com/images/branding/googlelogo/2x/googlelogo_color_150x54dp.png) no-repeat 0% 0%/100% 100%;-moz-border-image:url(//www.google.com/images/branding/googlelogo/2x/googlelogo_color_150x54dp.png) 0}}@media only screen and (-webkit-min-device-pixel-ratio:2){#logo{background:url(//www.google.com/images/branding/googlelogo/2x/googlelogo_color_150x54dp.png) no-repeat;-webkit-background-size:100% 100%}}#logo{display:inline-block;height:54px;width:150px}</style><main id=\"af-error-container\" role=\"main\"><a href=//www.google.com><span id=logo aria-label=Google role=img></span></a><p><b>500.</b> <ins>That’s an error.</ins><p>There was an error. Please try again later. <ins>That’s all we know.</ins></main>"
2023/05/31 19:27:21 extracted tarball into /workdir/tmp/TestTagXRepos2037754116/001/linux-amd64-longtest/0: 1 files, 1 dirs (341.23µs)
2023/05/31 19:27:21 extracted tarball into /workdir/tmp/TestTagXRepos2037754116/001/linux-amd64-longtest/0/repo: 4 files, 2 dirs (181.24µs)
2023/05/31 19:27:21 extracted tarball into /workdir/tmp/TestTagSingleRepo1185458338/001/linux-amd64-longtest/0: 1 files, 1 dirs (299.14µs)
2023/05/31 19:27:21 extracted tarball into /workdir/tmp/TestTagSingleRepo1185458338/001/linux-amd64-longtest/0/repo: 3 files, 1 dirs (172.16µs)

— watchflakes

@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label May 31, 2023
@gopherbot gopherbot added this to the Unreleased milestone May 31, 2023
@dmitshur dmitshur self-assigned this May 31, 2023
@dmitshur dmitshur added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels May 31, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/499680 mentions this issue: internal/task: deflake release announcement tests

@gopherbot
Copy link
Author

Change https://go.dev/cl/501195 mentions this issue: internal/task: parse HTML in parallel with network fetch

gopherbot pushed a commit to golang/build that referenced this issue Jun 7, 2023
@dmitshur @gopherbot
internal/task: parse HTML in parallel with network fetch
36d61c7 
CL 499680 made findGoogleGroupsThread wait for the fetch to complete
before starting to parse HTML. This was only so that it'd be easy to
detect if reading resp.Body fails (as opposed to parsing its content).
But it's also easy to do by wrapping around the resp.Body instead.

For golang/go#60541.

Change-Id: Iab1457de3242ecc90a4f7a0330c82363bdb157c2
Reviewed-on: https://go-review.googlesource.com/c/build/+/501195
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmitshur dmitshur

Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Go Release
Archived in project
Test Flakes
Status: Done
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot