Skip to content

x/telemetry/godev/internal/storage: test persistently failing on js/wasm and wasip1/wasm #60533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bcmills opened this issue May 31, 2023 · 2 comments
Closed

x/telemetry/godev/internal/storage: test persistently failing on js/wasm and wasip1/wasm #60533

bcmills opened this issue May 31, 2023 · 2 comments
Labels
arch-wasm WebAssembly issues FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented May 31, 2023

https://build.golang.org/log/60d86555660660741387b17d37b06604b9de9ff7:

--- FAIL: TestGCStore (0.00s)
    storage_test.go:38: failed to listen on addr localhost:8081: listen tcp: lookup localhost: Protocol not available
FAIL
FAIL	golang.org/x/telemetry/godev/internal/storage	0.673s

This is probably due to a bug in the wasm implementation of net.Listen (#59718). The test should probably be skipped on this platform — or perhaps these builders should be configured not to test the telemetry repo at all?

(attn @jamalc @hyangah @pjweinbgo)
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. arch-wasm WebAssembly issues labels May 31, 2023
@gopherbot gopherbot added this to the Unreleased milestone May 31, 2023
@bcmills bcmills mentioned this issue May 31, 2023
Closed
@hyangah
Copy link
Contributor

hyangah commented May 31, 2023

For x/telemetry/godev module, excluding wasm makes sense. However, for x/telemetry module in the same repo, it would be nice if we can test on as many platforms as possible. (even though I am not sure how far we can go with the mmap based counter library implementation yet)

I will make the godev tests skip on platforms other than linux/windows/darwin.

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/499596 mentions this issue: godev/internal/storage: skip TestGCStore when there is no network

@golang golang locked and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-wasm WebAssembly issues FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@hyangah @bcmills @gopherbot