Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: can't see assembly implementation of functions w/o body #60531

Open
inliquid opened this issue May 31, 2023 · 8 comments
Open

x/tools/gopls: can't see assembly implementation of functions w/o body #60531

inliquid opened this issue May 31, 2023 · 8 comments
Labels
FeatureRequest gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/backlog

Comments

@inliquid
Copy link

inliquid commented May 31, 2023 •
edited

What did you do?

I'm using VS Code. Until some moment it was possible to see the assembly implementation of a function without body by Ctrl-Click or F12, etc. I just found that it's not possible anymore.

For instance when I try to see implementation of atomic.AddInt32 I'm just switching between its signature and a method where it's used.
изображение

What did you expect to see?

See the assembly code of a function.

What did you see instead?

Switching between function signature and it's only reference in a package.

Build info

golang.org/x/tools/gopls master
    golang.org/x/tools/gopls@(devel)
    github.com/BurntSushi/toml@v1.2.1 h1:9F2/+DoOYIOksmaJFPw1tGFy1eDnIJXg+UHjuD8lTak=
    github.com/google/go-cmp@v0.5.9 h1:O2Tfq5qg4qc4AmwVlvv0oLiVAGB7enBSJ2x2DqQFi38=
    github.com/sergi/go-diff@v1.1.0 h1:we8PVUC3FE2uYfodKH/nBHMSetSfHDR6scGdBi+erh0=
    golang.org/x/exp@v0.0.0-20220722155223-a9213eeb770e h1:+WEEuIdZHnUeJJmEUjyYC2gfUMj69yZXw17EnHg/otA=
    golang.org/x/exp/typeparams@v0.0.0-20221212164502-fae10dda9338 h1:2O2DON6y3XMJiQRAS1UWU+54aec2uopH3x7MAiqGW6Y=
    golang.org/x/mod@v0.10.0 h1:lFO9qtOdlre5W1jxS3r/4szv2/6iXxScdzjoBMXNhYk=
    golang.org/x/sync@v0.2.0 h1:PUR+T4wwASmuSTYdKjYHI5TD22Wy5ogLU5qZCOLxBrI=
    golang.org/x/sys@v0.8.0 h1:EBmGv8NaZBZTWvrbjNoL6HVt+IVy3QDQpJs7VRIw3tU=
    golang.org/x/text@v0.9.0 h1:2sjJmO8cDvYveuX97RDLsxlyUxLl+GHoLxBiRdHllBE=
    golang.org/x/tools@v0.6.0 => ../
    golang.org/x/vuln@v0.0.0-20230110180137-6ad3e3d07815 h1:A9kONVi4+AnuOr1dopsibH6hLi1Huy54cbeJxnq4vmU=
    honnef.co/go/tools@v0.4.2 h1:6qXr+R5w+ktL5UkwEbPp+fEvfyoMPche6GkOpGHZcLc=
    mvdan.cc/gofumpt@v0.4.0 h1:JVf4NN1mIpHogBj7ABpgOyZc65/UUOkKQFkoURsz4MM=
    mvdan.cc/xurls/v2@v2.4.0 h1:tzxjVAj+wSBmDcF6zBB7/myTy3gX9xvi8Tyr28AuQgc=
go: go1.20.4
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels May 31, 2023
@gopherbot gopherbot added this to the Unreleased milestone May 31, 2023
@inliquid
Copy link
Author

@Nasfame thanks! Yea, I know it's possible to view *.s files but as I remember previously it was possible to navigate from function declarations.

@inliquid
Copy link
Author

I can't say unfortunately.

@jamalc
Copy link

jamalc commented Jun 1, 2023

We don't recall having this feature. Is it possible this was implemented by some other extension?

@inliquid
Copy link
Author

inliquid commented Jun 2, 2023

I didn't use this feature on a regular basis, so can't say when exactly it last worked, but I'm pretty sure that it worked. I don't think it was any side extension. I do use Go Asm extension, however, but AFAIK it only provides syntax highlighting.

@findleyr
Copy link
Contributor

We're pretty sure that we never did this, so I'm going to switch this to a feature request :)

@findleyr findleyr modified the milestones: Unreleased, gopls/later Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FeatureRequest gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/backlog
Development

No branches or pull requests
5 participants
@inliquid @gopherbot @jamalc @findleyr and others