Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/image/font: the term 'dot' in the comments is confusing #60501

Open
hajimehoshi opened this issue May 30, 2023 · 1 comment
Open

x/image/font: the term 'dot' in the comments is confusing #60501

hajimehoshi opened this issue May 30, 2023 · 1 comment
Labels
Documentation help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@hajimehoshi
Copy link
Member

hajimehoshi commented May 30, 2023 •
edited

In the comments of the x/image/font package, the term 'dot' is used as the origin position of rendering. I thought the 'dot' indicated the position of the glyph of the period . (e.g. the center of the period glyph would be (0, 0)), but actually this was not with most fonts. Apparently, the dot indicates the origin position in this figure: https://developer.apple.com/library/archive/documentation/TextFonts/Conceptual/CocoaTextArchitecture/Art/glyphterms_2x.png Is the 'dot' a usual term for typography? If not, I hope the comments would be updated to clarify the things.

/CC @nigeltao
@gopherbot gopherbot added this to the Unreleased milestone May 30, 2023
@hajimehoshi hajimehoshi mentioned this issue May 30, 2023
Closed
@mknyszek mknyszek added Documentation NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. help wanted labels May 30, 2023
@tinne26
Copy link

tinne26 commented May 31, 2023

From https://freetype.org/freetype2/docs/glyphs/glyphs-3.html, which is probably one of the best references on the topic available on the web:

Moreover, to render text, a virtual point, located on the baseline, called the pen position or origin, is used to locate glyphs.

tinne26 added a commit to tinne26/etxt that referenced this issue May 31, 2023
@tinne26
Prefer 'origin' to 'dot'.
18b152d 
Motivated by golang/go#60501.
@hajimehoshi hajimehoshi mentioned this issue May 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@hajimehoshi @mknyszek @gopherbot @tinne26