Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/fuzz: enable fuzz testing on OpenBSD #60491

Open
macie opened this issue May 29, 2023 · 5 comments · May be fixed by #60520
Open

internal/fuzz: enable fuzz testing on OpenBSD #60491

macie opened this issue May 29, 2023 · 5 comments · May be fixed by #60520
Labels
FeatureRequest NeedsFix The path to resolution is known, but the work has not been done. OS-OpenBSD
Milestone
Go1.23

Comments

@macie
Copy link

macie commented May 29, 2023 •
edited

On current version of OpenBSD you cannot run fuzz tests:

$ go test -fuzz .
-fuzz flag is not supported on openbsd/amd64

It looks like artificial restriction (comment by @dr2chase in #46554 (comment)):

I don't think it was tested across all the other OSes (yet), so "supported" might be too strong a word just yet. Good to know that it works, though.

After extending platform.FuzzSupported(goos, goarch string) and build tags inside src/internal/fuzz/ directory, I can run all.bash with success and use newly built executable to run fuzz tests.

I've read contribution rules, but I'm not sure what should I do next. Is it enough to create pull request with this change?

What version of Go are you using (go version)?

$ go version
go version go1.20.1 openbsd/amd64

Does this issue reproduce with the latest release?

I suppose
@seankhliao seankhliao added OS-OpenBSD NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels May 29, 2023
@seankhliao
Copy link
Member

cc @golang/openbsd

macie added a commit to macie/go that referenced this issue May 29, 2023
@macie
cmd/go: enable fuzz testing on OpenBSD
0c89adb 
This change provides support for -fuzz flag on OpenBSD. According to golang#46554 flag was
unsupported because of lack of testing on all OSes.

Fixes: golang#60491
@bcmills bcmills added this to the Backlog milestone May 30, 2023
@bcmills bcmills added help wanted compiler/runtime Issues related to the Go compiler and/or runtime. and removed help wanted labels May 30, 2023
@qbit
Copy link
Member

qbit commented May 30, 2023

Is it enough to create pull request with this change?

Yep! https://go.dev/doc/contribute#sending_a_change_github

macie added a commit to macie/go that referenced this issue May 30, 2023
@macie
cmd/go: enable fuzz testing on OpenBSD
c49c88b 
This change provides support for -fuzz flag on OpenBSD. According to golang#46554
the flag was unsupported because of lack of proper testing on all OSes.

Fixes: golang#60491
macie added a commit to macie/go that referenced this issue May 30, 2023
@macie
cmd/go: enable fuzz testing on OpenBSD
c81bd81 
This change provides support for -fuzz flag on OpenBSD. According to golang#46554
the flag was unsupported on some OSes due to lack of proper testing.

Fixes: golang#60491
@macie macie linked a pull request May 30, 2023 that will close this issue
Open
macie added a commit to macie/go that referenced this issue May 30, 2023
@macie
cmd/go: enable fuzz testing on OpenBSD
f697a3c 
This change provides support for -fuzz flag on OpenBSD. According to golang#46554
the flag was unsupported on some OSes due to lack of proper testing.

Fixes: golang#60491
@gopherbot
Copy link

Change https://go.dev/cl/499335 mentions this issue: cmd/go: enable fuzz testing on OpenBSD

@macie
Copy link
Author

macie commented May 30, 2023

Is it enough to create pull request with this change?

Yep! https://go.dev/doc/contribute#sending_a_change_github

I also needed to sign CLA and change email in commit from github private to the same as in CLA.

@mknyszek mknyszek changed the title cmd/go: enable fuzz testing on OpenBSD internal/fuzz: enable fuzz testing on OpenBSD May 31, 2023
@mknyszek mknyszek removed the compiler/runtime Issues related to the Go compiler and/or runtime. label May 31, 2023
@bcmills bcmills modified the milestones: Backlog, Go1.21, Go1.22 Jun 1, 2023
@bcmills
Copy link
Contributor

bcmills commented Jun 1, 2023

This will need to wait until the development window reopens after the release of Go 1.21.

@bcmills bcmills added the NeedsFix The path to resolution is known, but the work has not been done. label Jun 1, 2023
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 1, 2023
@gopherbot gopherbot modified the milestones: Go1.22, Go1.23 Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FeatureRequest NeedsFix The path to resolution is known, but the work has not been done. OS-OpenBSD
Projects
None yet
Milestone
Go1.23
Development

Successfully merging a pull request may close this issue.

cmd/go: enable fuzz testing on OpenBSD macie/go
6 participants
@qbit @mknyszek @bcmills @macie @gopherbot @seankhliao