Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/dist: modify all.bash to no longer skip testing packages without tests #60463

Closed
dmitshur opened this issue May 26, 2023 · 9 comments
Closed
Assignees
Labels
early-in-cycle A change that should be done early in the 3 month dev cycle. NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@dmitshur
Copy link
Contributor

dmitshur commented May 26, 2023

CL 10492 in 2015 applied a change to have all.bash skip testing Go packages in the standard library (those matched by go list std cmd) that have no tests. Sadly, the commit message doesn't specify what exactly motivated the change. A guess based on review comments is that it may have been to avoid doing unnecessary work and speed things up, as well as possibly to reduce verbosity of all.bash output.

By now, running go test on a Go package without tests can still produce useful information, such as the high-confidence vet checks that run (e.g., it would've caught an unused printf argument in TryBots), the fact that the package builds successfully, and so on. Furthermore, we have been generally wanting for all.bash not to miss any legitimate problems that a user running go test -short std cmd locally might find.

So we can revisit this. Some things worth considering here:

  • measure a bit on how much time it adds to all.bash (both locally and on TryBots)
  • think if the vendored packages should or shouldn't be included
    • their upstream tests do not get vendored into GOROOT, and by definition are already tested in the repos where their upstream source lives
    • having them in all.bash output adds quite a few lines

CC @golang/release, @aclements, @bcmills.

@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 26, 2023
@dmitshur dmitshur added this to the Backlog milestone May 26, 2023
@gopherbot
Copy link

Change https://go.dev/cl/498270 mentions this issue: cmd/go/internal/modget: remove unused base.Errorf argument

gopherbot pushed a commit that referenced this issue May 26, 2023
Found by the vet check that runs with 'go test cmd/go/internal/modget'.

For #57001.
For #60463.

Change-Id: I4be94f7156724459a5c47bb9745cbb5651fb972c
Reviewed-on: https://go-review.googlesource.com/c/go/+/498270
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
@aclements
Copy link
Member

One option, if we want to minimize output noise, is that dist could do some light filtering of the output to remove skipped package lines. It's a bit odd that the output of dist and go test diverge today, though. It seems annoying to have the skipped packages in the dist output, but I'm having trouble justifying why it would make a different decision about output than go test.

@dmitshur dmitshur modified the milestones: Backlog, Go1.22 May 30, 2023
@dmitshur dmitshur added the early-in-cycle A change that should be done early in the 3 month dev cycle. label May 30, 2023
Nasfame pushed a commit to golangFame/go that referenced this issue Jun 4, 2023
Found by the vet check that runs with 'go test cmd/go/internal/modget'.

For golang#57001.
For golang#60463.

Change-Id: I4be94f7156724459a5c47bb9745cbb5651fb972c
Reviewed-on: https://go-review.googlesource.com/c/go/+/498270
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
@aclements
Copy link
Member

Good example of an issue this would have caught: https://go.dev/cl/501220 introduced a malformed fmt.Fprintf in cmd/cgo. Since cmd/cgo has no test files, dist test skips it, even though go test would have run vet and caught this. (This is also https://go.dev/cl/501224 and https://go.dev/cl/501216)

@dmitshur
Copy link
Contributor Author

dmitshur commented Jun 6, 2023

We discussed this earlier and there was agreement the high-confidence vet coverage will almost certainly warrant doing this now, just need to sort out some of the small implementation details here.

@dmitshur dmitshur changed the title cmd/dist: revisit decision for all.bash to skip testing packages without tests cmd/dist: modify all.bash to no longer skip testing packages without tests Jun 6, 2023
@dmitshur dmitshur self-assigned this Jun 6, 2023
@aclements
Copy link
Member

I just chatted with Russ about this and he thinks we should just go ahead and do this, and not worry about the increased noise or excluding vendored packages (vendored packages all pass go vet right now, and we probably want to know if they stop passing vet).

@dmitshur
Copy link
Contributor Author

dmitshur commented Jun 13, 2023

Sounds good. Sent CL 503095.

The timing aspect of this seems reasonable. There are 164 normal and 96 vendored packages without tests at tip now. On my local machine, the first 'go test -short' run on them took 10 seconds, and the second run took 2.5 seconds. The value provided by this should outweigh that cost.

Package list
# Normal Go packages in std+cmd with no tests.
crypto/internal/boring/bbig
crypto/internal/boring/sig
crypto/internal/randutil
crypto/x509/internal/macos
crypto/x509/pkix
encoding
go/internal/typeparams
image/color/palette
image/internal/imageutil
internal/bisect
internal/bytealg
internal/cfg
internal/coverage
internal/coverage/calloc
internal/coverage/decodecounter
internal/coverage/decodemeta
internal/coverage/encodecounter
internal/coverage/encodemeta
internal/coverage/rtcov
internal/coverage/stringtab
internal/coverage/uleb128
internal/goarch
internal/goexperiment
internal/goos
internal/goroot
internal/goversion
internal/lazyregexp
internal/lazytemplate
internal/nettrace
internal/obscuretestdata
internal/oserror
internal/pkgbits
internal/platform
internal/race
internal/syscall/execenv
internal/syscall/unix
internal/sysinfo
internal/testlog
internal/testpty
internal/txtar
log/internal
log/slog/internal
log/slog/internal/slogtest
net/http/internal/testcert
reflect/internal/example1
reflect/internal/example2
runtime/race
testing/internal/testdeps
time/tzdata
unsafe
cmd/asm
cmd/asm/internal/arch
cmd/asm/internal/flags
cmd/buildid
cmd/cgo
cmd/cgo/internal/cgotest
cmd/cgo/internal/test/gcc68255
cmd/cgo/internal/test/issue23555a
cmd/cgo/internal/test/issue23555b
cmd/cgo/internal/test/issue24161arg
cmd/cgo/internal/test/issue24161e0
cmd/cgo/internal/test/issue24161e1
cmd/cgo/internal/test/issue24161e2
cmd/cgo/internal/test/issue24161res
cmd/cgo/internal/test/issue26213
cmd/cgo/internal/test/issue26430
cmd/cgo/internal/test/issue26743
cmd/cgo/internal/test/issue27054
cmd/cgo/internal/test/issue27340
cmd/cgo/internal/test/issue29563
cmd/cgo/internal/test/issue30527
cmd/cgo/internal/test/issue41761a
cmd/cgo/internal/test/issue43639
cmd/cgo/internal/test/issue52611a
cmd/cgo/internal/test/issue52611b
cmd/cgo/internal/test/issue8756
cmd/cgo/internal/test/issue8828
cmd/cgo/internal/test/issue9026
cmd/cgo/internal/test/issue9510a
cmd/cgo/internal/test/issue9510b
cmd/compile
cmd/compile/internal/abi
cmd/compile/internal/arm
cmd/compile/internal/arm64
cmd/compile/internal/bitvec
cmd/compile/internal/coverage
cmd/compile/internal/deadcode
cmd/compile/internal/devirtualize
cmd/compile/internal/escape
cmd/compile/internal/gc
cmd/compile/internal/inline
cmd/compile/internal/liveness
cmd/compile/internal/loong64
cmd/compile/internal/mips
cmd/compile/internal/mips64
cmd/compile/internal/objw
cmd/compile/internal/pgo
cmd/compile/internal/pgo/internal/graph
cmd/compile/internal/pkginit
cmd/compile/internal/ppc64
cmd/compile/internal/riscv64
cmd/compile/internal/s390x
cmd/compile/internal/ssagen
cmd/compile/internal/staticdata
cmd/compile/internal/staticinit
cmd/compile/internal/typebits
cmd/compile/internal/walk
cmd/compile/internal/wasm
cmd/compile/internal/x86
cmd/go/internal/base
cmd/go/internal/bug
cmd/go/internal/cfg
cmd/go/internal/clean
cmd/go/internal/cmdflag
cmd/go/internal/doc
cmd/go/internal/fix
cmd/go/internal/fmtcmd
cmd/go/internal/help
cmd/go/internal/list
cmd/go/internal/mmap
cmd/go/internal/modcmd
cmd/go/internal/modget
cmd/go/internal/modinfo
cmd/go/internal/robustio
cmd/go/internal/run
cmd/go/internal/script
cmd/go/internal/script/scripttest
cmd/go/internal/search
cmd/go/internal/test/internal/genflags
cmd/go/internal/tool
cmd/go/internal/trace
cmd/go/internal/version
cmd/go/internal/vet
cmd/go/internal/workcmd
cmd/internal/bio
cmd/internal/browser
cmd/internal/codesign
cmd/internal/gcprog
cmd/internal/obj/arm
cmd/internal/obj/loong64
cmd/internal/obj/mips
cmd/internal/obj/wasm
cmd/internal/objfile
cmd/internal/osinfo
cmd/internal/sys
cmd/internal/traceviewer
cmd/link/internal/amd64
cmd/link/internal/arm
cmd/link/internal/arm64
cmd/link/internal/dwtest
cmd/link/internal/loadelf
cmd/link/internal/loadmacho
cmd/link/internal/loadpe
cmd/link/internal/loadxcoff
cmd/link/internal/loong64
cmd/link/internal/mips
cmd/link/internal/mips64
cmd/link/internal/ppc64
cmd/link/internal/riscv64
cmd/link/internal/s390x
cmd/link/internal/sym
cmd/link/internal/wasm
cmd/link/internal/x86
cmd/test2json

# Vendored Go packages in std+cmd.
vendor/golang.org/x/crypto/chacha20
vendor/golang.org/x/crypto/chacha20poly1305
vendor/golang.org/x/crypto/cryptobyte
vendor/golang.org/x/crypto/cryptobyte/asn1
vendor/golang.org/x/crypto/hkdf
vendor/golang.org/x/crypto/internal/alias
vendor/golang.org/x/crypto/internal/poly1305
vendor/golang.org/x/net/dns/dnsmessage
vendor/golang.org/x/net/http/httpguts
vendor/golang.org/x/net/http/httpproxy
vendor/golang.org/x/net/http2/hpack
vendor/golang.org/x/net/idna
vendor/golang.org/x/net/nettest
vendor/golang.org/x/net/route
vendor/golang.org/x/sys/cpu
vendor/golang.org/x/text/secure/bidirule
vendor/golang.org/x/text/transform
vendor/golang.org/x/text/unicode/bidi
vendor/golang.org/x/text/unicode/norm
cmd/vendor/github.com/google/pprof/driver
cmd/vendor/github.com/google/pprof/internal/binutils
cmd/vendor/github.com/google/pprof/internal/driver
cmd/vendor/github.com/google/pprof/internal/elfexec
cmd/vendor/github.com/google/pprof/internal/graph
cmd/vendor/github.com/google/pprof/internal/measurement
cmd/vendor/github.com/google/pprof/internal/plugin
cmd/vendor/github.com/google/pprof/internal/report
cmd/vendor/github.com/google/pprof/internal/symbolizer
cmd/vendor/github.com/google/pprof/internal/symbolz
cmd/vendor/github.com/google/pprof/internal/transport
cmd/vendor/github.com/google/pprof/profile
cmd/vendor/github.com/google/pprof/third_party/d3flamegraph
cmd/vendor/github.com/google/pprof/third_party/svgpan
cmd/vendor/github.com/ianlancetaylor/demangle
cmd/vendor/golang.org/x/arch/arm/armasm
cmd/vendor/golang.org/x/arch/arm64/arm64asm
cmd/vendor/golang.org/x/arch/ppc64/ppc64asm
cmd/vendor/golang.org/x/arch/x86/x86asm
cmd/vendor/golang.org/x/mod/internal/lazyregexp
cmd/vendor/golang.org/x/mod/modfile
cmd/vendor/golang.org/x/mod/module
cmd/vendor/golang.org/x/mod/semver
cmd/vendor/golang.org/x/mod/sumdb
cmd/vendor/golang.org/x/mod/sumdb/dirhash
cmd/vendor/golang.org/x/mod/sumdb/note
cmd/vendor/golang.org/x/mod/sumdb/tlog
cmd/vendor/golang.org/x/mod/zip
cmd/vendor/golang.org/x/sync/semaphore
cmd/vendor/golang.org/x/sys/internal/unsafeheader
cmd/vendor/golang.org/x/sys/unix
cmd/vendor/golang.org/x/term
cmd/vendor/golang.org/x/tools/cover
cmd/vendor/golang.org/x/tools/go/analysis
cmd/vendor/golang.org/x/tools/go/analysis/internal/analysisflags
cmd/vendor/golang.org/x/tools/go/analysis/passes/asmdecl
cmd/vendor/golang.org/x/tools/go/analysis/passes/assign
cmd/vendor/golang.org/x/tools/go/analysis/passes/atomic
cmd/vendor/golang.org/x/tools/go/analysis/passes/bools
cmd/vendor/golang.org/x/tools/go/analysis/passes/buildtag
cmd/vendor/golang.org/x/tools/go/analysis/passes/cgocall
cmd/vendor/golang.org/x/tools/go/analysis/passes/composite
cmd/vendor/golang.org/x/tools/go/analysis/passes/copylock
cmd/vendor/golang.org/x/tools/go/analysis/passes/ctrlflow
cmd/vendor/golang.org/x/tools/go/analysis/passes/directive
cmd/vendor/golang.org/x/tools/go/analysis/passes/errorsas
cmd/vendor/golang.org/x/tools/go/analysis/passes/framepointer
cmd/vendor/golang.org/x/tools/go/analysis/passes/httpresponse
cmd/vendor/golang.org/x/tools/go/analysis/passes/ifaceassert
cmd/vendor/golang.org/x/tools/go/analysis/passes/inspect
cmd/vendor/golang.org/x/tools/go/analysis/passes/internal/analysisutil
cmd/vendor/golang.org/x/tools/go/analysis/passes/loopclosure
cmd/vendor/golang.org/x/tools/go/analysis/passes/lostcancel
cmd/vendor/golang.org/x/tools/go/analysis/passes/nilfunc
cmd/vendor/golang.org/x/tools/go/analysis/passes/printf
cmd/vendor/golang.org/x/tools/go/analysis/passes/shift
cmd/vendor/golang.org/x/tools/go/analysis/passes/sigchanyzer
cmd/vendor/golang.org/x/tools/go/analysis/passes/slog
cmd/vendor/golang.org/x/tools/go/analysis/passes/stdmethods
cmd/vendor/golang.org/x/tools/go/analysis/passes/stringintconv
cmd/vendor/golang.org/x/tools/go/analysis/passes/structtag
cmd/vendor/golang.org/x/tools/go/analysis/passes/testinggoroutine
cmd/vendor/golang.org/x/tools/go/analysis/passes/tests
cmd/vendor/golang.org/x/tools/go/analysis/passes/timeformat
cmd/vendor/golang.org/x/tools/go/analysis/passes/unmarshal
cmd/vendor/golang.org/x/tools/go/analysis/passes/unreachable
cmd/vendor/golang.org/x/tools/go/analysis/passes/unsafeptr
cmd/vendor/golang.org/x/tools/go/analysis/passes/unusedresult
cmd/vendor/golang.org/x/tools/go/analysis/unitchecker
cmd/vendor/golang.org/x/tools/go/ast/astutil
cmd/vendor/golang.org/x/tools/go/ast/inspector
cmd/vendor/golang.org/x/tools/go/cfg
cmd/vendor/golang.org/x/tools/go/types/objectpath
cmd/vendor/golang.org/x/tools/go/types/typeutil
cmd/vendor/golang.org/x/tools/internal/bisect
cmd/vendor/golang.org/x/tools/internal/facts
cmd/vendor/golang.org/x/tools/internal/typeparams

A note about vendored packages. They are already tested and vetted at their canonical upstream location (where their test source lives), but the doing it again in all.bash is comparatively inexpensive since their tests are skipped, and may report findings sooner when the behavior of 'go test' or vet itself changes in the main repo.

For reference, here's a sample all.bash output with the change applied. Seems not bad. An upside of this is that it lets one see a more complete picture of all packages in the main repo. And doesn't matter when looking at the structured test output in CI (#59990).

Sample all.bash output (with the change)
src $ ./all.bash
Building Go cmd/dist using /Users/gopher/sdk/go1.17.13. (go1.17.13 darwin/arm64)
Building Go toolchain1 using /Users/gopher/sdk/go1.17.13.
Building Go bootstrap cmd/go (go_bootstrap) using Go toolchain1.
Building Go toolchain2 using go_bootstrap and Go toolchain1.
Building Go toolchain3 using go_bootstrap and Go toolchain2.
Building packages and commands for darwin/arm64.

##### Test execution environment.
# GOARCH: arm64
# CPU: 
# GOOS: darwin
# OS Version: Darwin 22.5.0 Darwin Kernel Version 22.5.0: Mon Apr 24 20:52:24 PDT 2023; root:xnu-8796.121.2~5/RELEASE_ARM64_T6000 arm64

##### Testing packages.
ok  	archive/tar	0.188s
ok  	archive/zip	0.287s
ok  	bufio	0.192s
ok  	bytes	0.351s
ok  	cmp	0.421s
ok  	compress/bzip2	0.385s
ok  	compress/flate	0.616s
?   	crypto/internal/boring/bbig	[no test files]
?   	crypto/internal/boring/sig	[no test files]
?   	crypto/internal/randutil	[no test files]
ok  	compress/gzip	1.481s
ok  	compress/lzw	0.319s
ok  	compress/zlib	0.382s
ok  	container/heap	0.451s
ok  	container/list	0.501s
ok  	container/ring	0.503s
ok  	context	0.477s
ok  	crypto	0.518s
ok  	crypto/aes	0.542s
ok  	crypto/cipher	0.439s
ok  	crypto/des	0.476s
ok  	crypto/dsa	0.464s
ok  	crypto/ecdh	0.498s
ok  	crypto/ecdsa	0.461s
ok  	crypto/ed25519	0.487s
ok  	crypto/elliptic	0.488s
ok  	crypto/hmac	0.534s
ok  	crypto/internal/alias	0.523s
ok  	crypto/internal/bigmod	0.632s
ok  	crypto/internal/boring	0.535s
ok  	crypto/internal/boring/bcache	0.567s
?   	crypto/x509/internal/macos	[no test files]
?   	crypto/x509/pkix	[no test files]
?   	encoding	[no test files]
ok  	crypto/internal/edwards25519	2.337s
ok  	crypto/internal/edwards25519/field	2.545s
ok  	crypto/internal/nistec	0.538s
ok  	crypto/internal/nistec/fiat	0.507s [no tests to run]
ok  	crypto/md5	0.488s
ok  	crypto/rand	0.479s
ok  	crypto/rc4	0.480s
ok  	crypto/rsa	0.635s
ok  	crypto/sha1	0.519s
ok  	crypto/sha256	0.489s
ok  	crypto/sha512	0.412s
ok  	crypto/subtle	0.477s
ok  	crypto/tls	0.520s
ok  	crypto/x509	0.440s
ok  	database/sql	0.630s
ok  	database/sql/driver	0.252s
ok  	debug/buildinfo	0.291s
ok  	debug/dwarf	0.318s
ok  	debug/elf	0.366s
ok  	debug/gosym	0.296s
ok  	debug/macho	0.229s
ok  	debug/pe	0.302s
ok  	debug/plan9obj	0.342s
ok  	embed	0.351s [no tests to run]
ok  	embed/internal/embedtest	0.355s
ok  	encoding/ascii85	0.373s
ok  	encoding/asn1	0.411s
ok  	encoding/base32	0.430s
ok  	encoding/base64	0.412s
ok  	encoding/binary	0.413s
ok  	encoding/csv	0.465s
ok  	encoding/gob	0.901s
ok  	encoding/hex	0.444s
ok  	encoding/json	0.399s
ok  	encoding/pem	0.685s
ok  	encoding/xml	0.405s
ok  	errors	0.494s
ok  	expvar	0.452s
ok  	flag	0.539s
ok  	fmt	0.539s
ok  	go/ast	0.453s
?   	go/internal/typeparams	[no test files]
ok  	go/build	1.341s
ok  	go/build/constraint	0.427s
ok  	go/constant	0.435s
ok  	go/doc	0.441s
ok  	go/doc/comment	0.874s
ok  	go/format	0.443s
ok  	go/importer	0.624s
ok  	go/internal/gccgoimporter	0.466s
?   	image/color/palette	[no test files]
?   	image/internal/imageutil	[no test files]
?   	internal/bisect	[no test files]
?   	internal/bytealg	[no test files]
?   	internal/cfg	[no test files]
?   	internal/coverage	[no test files]
?   	internal/coverage/calloc	[no test files]
?   	internal/coverage/decodecounter	[no test files]
?   	internal/coverage/decodemeta	[no test files]
?   	internal/coverage/encodecounter	[no test files]
?   	internal/coverage/encodemeta	[no test files]
?   	internal/coverage/rtcov	[no test files]
ok  	go/internal/gcimporter	2.382s
?   	internal/coverage/stringtab	[no test files]
?   	internal/coverage/uleb128	[no test files]
?   	internal/goarch	[no test files]
?   	internal/goexperiment	[no test files]
?   	internal/goos	[no test files]
?   	internal/goroot	[no test files]
?   	internal/goversion	[no test files]
?   	internal/lazyregexp	[no test files]
?   	internal/lazytemplate	[no test files]
?   	internal/nettrace	[no test files]
?   	internal/obscuretestdata	[no test files]
?   	internal/oserror	[no test files]
?   	internal/pkgbits	[no test files]
?   	internal/platform	[no test files]
?   	internal/race	[no test files]
?   	internal/syscall/execenv	[no test files]
?   	internal/syscall/unix	[no test files]
?   	internal/sysinfo	[no test files]
?   	internal/testlog	[no test files]
?   	internal/testpty	[no test files]
?   	internal/txtar	[no test files]
?   	log/internal	[no test files]
?   	log/slog/internal	[no test files]
?   	log/slog/internal/slogtest	[no test files]
?   	net/http/internal/testcert	[no test files]
?   	reflect/internal/example1	[no test files]
?   	reflect/internal/example2	[no test files]
?   	runtime/race	[no test files]
ok  	go/internal/srcimporter	10.249s
ok  	go/parser	0.586s
ok  	go/printer	0.569s
ok  	go/scanner	0.529s
ok  	go/token	0.457s
ok  	go/types	3.956s
ok  	hash	0.288s
ok  	hash/adler32	0.254s
ok  	hash/crc32	0.263s
ok  	hash/crc64	0.311s
ok  	hash/fnv	0.339s
ok  	hash/maphash	0.435s
ok  	html	0.368s
ok  	html/template	0.341s
ok  	image	0.321s
ok  	image/color	0.306s
ok  	image/draw	0.326s
ok  	image/gif	0.375s
ok  	image/jpeg	0.321s
ok  	image/png	0.314s
ok  	index/suffixarray	0.368s
ok  	internal/abi	0.224s
ok  	internal/buildcfg	0.164s
ok  	internal/coverage/cformat	0.098s
ok  	internal/coverage/cmerge	0.150s
ok  	internal/coverage/pods	0.134s
ok  	internal/coverage/slicereader	0.108s
ok  	internal/coverage/slicewriter	0.172s
ok  	internal/coverage/test	0.231s
ok  	internal/cpu	0.091s
ok  	internal/dag	0.160s
ok  	internal/diff	0.296s
ok  	internal/fmtsort	0.231s
ok  	internal/fuzz	0.372s
ok  	internal/godebug	1.148s
ok  	internal/godebugs	0.477s
ok  	internal/intern	0.580s
ok  	internal/itoa	0.489s
ok  	internal/poll	0.389s
ok  	internal/profile	0.427s
ok  	internal/reflectlite	0.305s
ok  	internal/safefilepath	0.441s
ok  	internal/saferio	0.389s
ok  	internal/singleflight	0.441s
ok  	internal/testenv	0.547s
ok  	internal/trace	0.338s
ok  	internal/types/errors	0.574s
ok  	internal/unsafeheader	0.307s
ok  	internal/xcoff	0.374s
ok  	internal/zstd	0.366s
ok  	io	0.313s
ok  	io/fs	0.489s
ok  	io/ioutil	0.395s
ok  	log	0.366s
ok  	log/slog	0.249s
ok  	log/slog/internal/benchmarks	0.279s
ok  	log/slog/internal/buffer	0.280s
ok  	log/syslog	1.511s
ok  	maps	0.298s
ok  	math	0.196s
ok  	math/big	0.665s
ok  	math/bits	0.257s
ok  	math/cmplx	0.327s
ok  	math/rand	0.441s
ok  	mime	0.453s
ok  	mime/multipart	0.704s
ok  	mime/quotedprintable	0.456s
ok  	net	2.572s
ok  	net/http	2.987s
ok  	net/http/cgi	1.453s
ok  	net/http/cookiejar	0.204s
ok  	net/http/fcgi	0.322s
ok  	net/http/httptest	0.271s
ok  	net/http/httptrace	0.269s
ok  	net/http/httputil	0.793s
ok  	net/http/internal	0.284s
ok  	net/http/internal/ascii	0.195s
?   	testing/internal/testdeps	[no test files]
ok  	net/http/pprof	4.216s
ok  	net/internal/socktest	0.144s
ok  	net/mail	0.121s
ok  	net/netip	0.305s
ok  	net/rpc	0.318s
ok  	net/rpc/jsonrpc	0.119s
ok  	net/smtp	0.202s
ok  	net/textproto	0.366s
ok  	net/url	0.341s
ok  	os	0.844s
ok  	os/exec	0.526s
ok  	os/exec/internal/fdtest	0.261s
ok  	os/signal	2.850s
ok  	os/user	0.321s
ok  	path	0.346s
ok  	path/filepath	0.138s
ok  	plugin	0.124s
ok  	reflect	0.377s
ok  	regexp	0.391s
ok  	regexp/syntax	0.577s
?   	time/tzdata	[no test files]
?   	unsafe	[no test files]
?   	vendor/golang.org/x/crypto/chacha20	[no test files]
?   	vendor/golang.org/x/crypto/chacha20poly1305	[no test files]
?   	vendor/golang.org/x/crypto/cryptobyte	[no test files]
?   	vendor/golang.org/x/crypto/cryptobyte/asn1	[no test files]
?   	vendor/golang.org/x/crypto/hkdf	[no test files]
?   	vendor/golang.org/x/crypto/internal/alias	[no test files]
?   	vendor/golang.org/x/crypto/internal/poly1305	[no test files]
?   	vendor/golang.org/x/net/dns/dnsmessage	[no test files]
?   	vendor/golang.org/x/net/http2/hpack	[no test files]
?   	vendor/golang.org/x/net/idna	[no test files]
?   	vendor/golang.org/x/net/http/httpproxy	[no test files]
?   	vendor/golang.org/x/net/http/httpguts	[no test files]
?   	vendor/golang.org/x/net/nettest	[no test files]
?   	vendor/golang.org/x/net/route	[no test files]
?   	vendor/golang.org/x/sys/cpu	[no test files]
?   	vendor/golang.org/x/text/secure/bidirule	[no test files]
?   	vendor/golang.org/x/text/transform	[no test files]
?   	vendor/golang.org/x/text/unicode/bidi	[no test files]
?   	vendor/golang.org/x/text/unicode/norm	[no test files]
?   	cmd/asm	[no test files]
?   	cmd/asm/internal/arch	[no test files]
?   	cmd/asm/internal/flags	[no test files]
?   	cmd/buildid	[no test files]
?   	cmd/cgo	[no test files]
?   	cmd/cgo/internal/cgotest	[no test files]
?   	cmd/cgo/internal/test/gcc68255	[no test files]
?   	cmd/cgo/internal/test/issue23555a	[no test files]
?   	cmd/cgo/internal/test/issue23555b	[no test files]
?   	cmd/cgo/internal/test/issue24161arg	[no test files]
?   	cmd/cgo/internal/test/issue24161e0	[no test files]
?   	cmd/cgo/internal/test/issue24161e1	[no test files]
?   	cmd/cgo/internal/test/issue24161e2	[no test files]
?   	cmd/cgo/internal/test/issue24161res	[no test files]
?   	cmd/cgo/internal/test/issue26213	[no test files]
?   	cmd/cgo/internal/test/issue26430	[no test files]
?   	cmd/cgo/internal/test/issue26743	[no test files]
?   	cmd/cgo/internal/test/issue27054	[no test files]
?   	cmd/cgo/internal/test/issue27340	[no test files]
?   	cmd/cgo/internal/test/issue29563	[no test files]
?   	cmd/cgo/internal/test/issue30527	[no test files]
?   	cmd/cgo/internal/test/issue41761a	[no test files]
?   	cmd/cgo/internal/test/issue43639	[no test files]
?   	cmd/cgo/internal/test/issue52611a	[no test files]
?   	cmd/cgo/internal/test/issue52611b	[no test files]
?   	cmd/cgo/internal/test/issue8756	[no test files]
?   	cmd/cgo/internal/test/issue8828	[no test files]
?   	cmd/cgo/internal/test/issue9026	[no test files]
?   	cmd/cgo/internal/test/issue9510a	[no test files]
?   	cmd/cgo/internal/test/issue9510b	[no test files]
?   	cmd/compile	[no test files]
?   	cmd/compile/internal/abi	[no test files]
?   	cmd/compile/internal/arm	[no test files]
?   	cmd/compile/internal/arm64	[no test files]
?   	cmd/compile/internal/bitvec	[no test files]
?   	cmd/compile/internal/coverage	[no test files]
?   	cmd/compile/internal/deadcode	[no test files]
?   	cmd/compile/internal/devirtualize	[no test files]
?   	cmd/compile/internal/escape	[no test files]
?   	cmd/compile/internal/gc	[no test files]
?   	cmd/compile/internal/inline	[no test files]
?   	cmd/compile/internal/liveness	[no test files]
?   	cmd/compile/internal/loong64	[no test files]
?   	cmd/compile/internal/mips	[no test files]
?   	cmd/compile/internal/mips64	[no test files]
?   	cmd/compile/internal/objw	[no test files]
?   	cmd/compile/internal/pgo	[no test files]
?   	cmd/compile/internal/pgo/internal/graph	[no test files]
?   	cmd/compile/internal/pkginit	[no test files]
?   	cmd/compile/internal/ppc64	[no test files]
?   	cmd/compile/internal/riscv64	[no test files]
?   	cmd/compile/internal/s390x	[no test files]
?   	cmd/compile/internal/ssagen	[no test files]
?   	cmd/compile/internal/staticdata	[no test files]
?   	cmd/compile/internal/staticinit	[no test files]
?   	cmd/compile/internal/typebits	[no test files]
?   	cmd/compile/internal/walk	[no test files]
?   	cmd/compile/internal/wasm	[no test files]
?   	cmd/compile/internal/x86	[no test files]
?   	cmd/go/internal/base	[no test files]
?   	cmd/go/internal/bug	[no test files]
?   	cmd/go/internal/cfg	[no test files]
?   	cmd/go/internal/clean	[no test files]
?   	cmd/go/internal/cmdflag	[no test files]
?   	cmd/go/internal/doc	[no test files]
?   	cmd/go/internal/fix	[no test files]
?   	cmd/go/internal/fmtcmd	[no test files]
?   	cmd/go/internal/help	[no test files]
?   	cmd/go/internal/list	[no test files]
?   	cmd/go/internal/mmap	[no test files]
?   	cmd/go/internal/modcmd	[no test files]
ok  	runtime	20.067s
ok  	runtime/cgo	0.178s
ok  	runtime/coverage	0.252s
ok  	runtime/debug	0.382s
ok  	runtime/internal/atomic	0.518s
ok  	runtime/internal/math	0.503s
ok  	runtime/internal/sys	0.398s
ok  	runtime/internal/wasitest	0.419s
ok  	runtime/metrics	0.419s
ok  	runtime/pprof	5.912s
ok  	runtime/trace	1.379s
ok  	slices	0.301s
ok  	sort	0.228s
ok  	strconv	0.342s
ok  	strings	0.158s
ok  	sync	0.447s
ok  	sync/atomic	1.099s
ok  	syscall	0.303s
ok  	testing	1.090s
ok  	testing/fstest	0.097s
ok  	testing/iotest	0.113s
ok  	testing/quick	0.119s
ok  	testing/slogtest	0.126s
ok  	text/scanner	0.237s
ok  	text/tabwriter	0.200s
ok  	text/template	0.143s
ok  	text/template/parse	0.156s
ok  	time	2.559s
ok  	unicode	0.180s
ok  	unicode/utf16	0.243s
ok  	unicode/utf8	0.326s
ok  	cmd/addr2line	0.679s
?   	cmd/go/internal/modget	[no test files]
?   	cmd/go/internal/modinfo	[no test files]
?   	cmd/go/internal/robustio	[no test files]
?   	cmd/go/internal/run	[no test files]
?   	cmd/go/internal/script	[no test files]
?   	cmd/go/internal/script/scripttest	[no test files]
?   	cmd/go/internal/search	[no test files]
?   	cmd/go/internal/test/internal/genflags	[no test files]
?   	cmd/go/internal/tool	[no test files]
?   	cmd/go/internal/trace	[no test files]
?   	cmd/go/internal/version	[no test files]
?   	cmd/go/internal/vet	[no test files]
?   	cmd/go/internal/workcmd	[no test files]
?   	cmd/internal/bio	[no test files]
?   	cmd/internal/browser	[no test files]
?   	cmd/internal/codesign	[no test files]
?   	cmd/internal/gcprog	[no test files]
?   	cmd/internal/obj/arm	[no test files]
?   	cmd/internal/obj/loong64	[no test files]
?   	cmd/internal/obj/mips	[no test files]
?   	cmd/internal/obj/wasm	[no test files]
?   	cmd/internal/objfile	[no test files]
?   	cmd/internal/osinfo	[no test files]
?   	cmd/internal/sys	[no test files]
?   	cmd/internal/traceviewer	[no test files]
?   	cmd/link/internal/amd64	[no test files]
?   	cmd/link/internal/arm	[no test files]
?   	cmd/link/internal/arm64	[no test files]
?   	cmd/link/internal/dwtest	[no test files]
?   	cmd/link/internal/loadelf	[no test files]
?   	cmd/link/internal/loadmacho	[no test files]
?   	cmd/link/internal/loadpe	[no test files]
?   	cmd/link/internal/loadxcoff	[no test files]
?   	cmd/link/internal/loong64	[no test files]
?   	cmd/link/internal/mips	[no test files]
?   	cmd/link/internal/mips64	[no test files]
?   	cmd/link/internal/ppc64	[no test files]
?   	cmd/link/internal/riscv64	[no test files]
?   	cmd/link/internal/s390x	[no test files]
?   	cmd/link/internal/sym	[no test files]
?   	cmd/link/internal/wasm	[no test files]
?   	cmd/link/internal/x86	[no test files]
?   	cmd/test2json	[no test files]
?   	cmd/vendor/github.com/google/pprof/driver	[no test files]
?   	cmd/vendor/github.com/google/pprof/internal/binutils	[no test files]
?   	cmd/vendor/github.com/google/pprof/internal/driver	[no test files]
?   	cmd/vendor/github.com/google/pprof/internal/elfexec	[no test files]
?   	cmd/vendor/github.com/google/pprof/internal/graph	[no test files]
?   	cmd/vendor/github.com/google/pprof/internal/measurement	[no test files]
?   	cmd/vendor/github.com/google/pprof/internal/plugin	[no test files]
?   	cmd/vendor/github.com/google/pprof/internal/report	[no test files]
?   	cmd/vendor/github.com/google/pprof/internal/symbolizer	[no test files]
?   	cmd/vendor/github.com/google/pprof/internal/symbolz	[no test files]
?   	cmd/vendor/github.com/google/pprof/internal/transport	[no test files]
?   	cmd/vendor/github.com/google/pprof/profile	[no test files]
?   	cmd/vendor/github.com/google/pprof/third_party/d3flamegraph	[no test files]
?   	cmd/vendor/github.com/google/pprof/third_party/svgpan	[no test files]
?   	cmd/vendor/github.com/ianlancetaylor/demangle	[no test files]
?   	cmd/vendor/golang.org/x/arch/arm/armasm	[no test files]
?   	cmd/vendor/golang.org/x/arch/arm64/arm64asm	[no test files]
?   	cmd/vendor/golang.org/x/arch/ppc64/ppc64asm	[no test files]
?   	cmd/vendor/golang.org/x/arch/x86/x86asm	[no test files]
?   	cmd/vendor/golang.org/x/mod/internal/lazyregexp	[no test files]
?   	cmd/vendor/golang.org/x/mod/modfile	[no test files]
?   	cmd/vendor/golang.org/x/mod/module	[no test files]
?   	cmd/vendor/golang.org/x/mod/semver	[no test files]
?   	cmd/vendor/golang.org/x/mod/sumdb	[no test files]
?   	cmd/vendor/golang.org/x/mod/sumdb/dirhash	[no test files]
?   	cmd/vendor/golang.org/x/mod/sumdb/note	[no test files]
?   	cmd/vendor/golang.org/x/mod/sumdb/tlog	[no test files]
?   	cmd/vendor/golang.org/x/mod/zip	[no test files]
?   	cmd/vendor/golang.org/x/sync/semaphore	[no test files]
?   	cmd/vendor/golang.org/x/sys/internal/unsafeheader	[no test files]
?   	cmd/vendor/golang.org/x/sys/unix	[no test files]
?   	cmd/vendor/golang.org/x/term	[no test files]
?   	cmd/vendor/golang.org/x/tools/cover	[no test files]
?   	cmd/vendor/golang.org/x/tools/go/analysis	[no test files]
?   	cmd/vendor/golang.org/x/tools/go/analysis/internal/analysisflags	[no test files]
?   	cmd/vendor/golang.org/x/tools/go/analysis/passes/asmdecl	[no test files]
?   	cmd/vendor/golang.org/x/tools/go/analysis/passes/assign	[no test files]
?   	cmd/vendor/golang.org/x/tools/go/analysis/passes/atomic	[no test files]
?   	cmd/vendor/golang.org/x/tools/go/analysis/passes/bools	[no test files]
?   	cmd/vendor/golang.org/x/tools/go/analysis/passes/buildtag	[no test files]
?   	cmd/vendor/golang.org/x/tools/go/analysis/passes/cgocall	[no test files]
?   	cmd/vendor/golang.org/x/tools/go/analysis/passes/composite	[no test files]
?   	cmd/vendor/golang.org/x/tools/go/analysis/passes/copylock	[no test files]
?   	cmd/vendor/golang.org/x/tools/go/analysis/passes/ctrlflow	[no test files]
?   	cmd/vendor/golang.org/x/tools/go/analysis/passes/directive	[no test files]
?   	cmd/vendor/golang.org/x/tools/go/analysis/passes/errorsas	[no test files]
?   	cmd/vendor/golang.org/x/tools/go/analysis/passes/framepointer	[no test files]
?   	cmd/vendor/golang.org/x/tools/go/analysis/passes/httpresponse	[no test files]
?   	cmd/vendor/golang.org/x/tools/go/analysis/passes/ifaceassert	[no test files]
?   	cmd/vendor/golang.org/x/tools/go/analysis/passes/inspect	[no test files]
?   	cmd/vendor/golang.org/x/tools/go/analysis/passes/internal/analysisutil	[no test files]
?   	cmd/vendor/golang.org/x/tools/go/analysis/passes/loopclosure	[no test files]
?   	cmd/vendor/golang.org/x/tools/go/analysis/passes/lostcancel	[no test files]
?   	cmd/vendor/golang.org/x/tools/go/analysis/passes/nilfunc	[no test files]
?   	cmd/vendor/golang.org/x/tools/go/analysis/passes/printf	[no test files]
?   	cmd/vendor/golang.org/x/tools/go/analysis/passes/shift	[no test files]
?   	cmd/vendor/golang.org/x/tools/go/analysis/passes/sigchanyzer	[no test files]
?   	cmd/vendor/golang.org/x/tools/go/analysis/passes/slog	[no test files]
?   	cmd/vendor/golang.org/x/tools/go/analysis/passes/stdmethods	[no test files]
?   	cmd/vendor/golang.org/x/tools/go/analysis/passes/stringintconv	[no test files]
?   	cmd/vendor/golang.org/x/tools/go/analysis/passes/structtag	[no test files]
?   	cmd/vendor/golang.org/x/tools/go/analysis/passes/testinggoroutine	[no test files]
?   	cmd/vendor/golang.org/x/tools/go/analysis/passes/tests	[no test files]
?   	cmd/vendor/golang.org/x/tools/go/analysis/passes/timeformat	[no test files]
?   	cmd/vendor/golang.org/x/tools/go/analysis/passes/unmarshal	[no test files]
?   	cmd/vendor/golang.org/x/tools/go/analysis/passes/unreachable	[no test files]
?   	cmd/vendor/golang.org/x/tools/go/analysis/passes/unsafeptr	[no test files]
?   	cmd/vendor/golang.org/x/tools/go/analysis/passes/unusedresult	[no test files]
?   	cmd/vendor/golang.org/x/tools/go/analysis/unitchecker	[no test files]
?   	cmd/vendor/golang.org/x/tools/go/ast/astutil	[no test files]
?   	cmd/vendor/golang.org/x/tools/go/ast/inspector	[no test files]
?   	cmd/vendor/golang.org/x/tools/go/cfg	[no test files]
?   	cmd/vendor/golang.org/x/tools/go/types/objectpath	[no test files]
?   	cmd/vendor/golang.org/x/tools/go/types/typeutil	[no test files]
?   	cmd/vendor/golang.org/x/tools/internal/bisect	[no test files]
?   	cmd/vendor/golang.org/x/tools/internal/typeparams	[no test files]
?   	cmd/vendor/golang.org/x/tools/internal/facts	[no test files]
ok  	cmd/api	43.643s
ok  	cmd/asm/internal/asm	0.440s
ok  	cmd/asm/internal/lex	0.205s
ok  	cmd/cgo/internal/swig	0.124s
ok  	cmd/cgo/internal/test	0.352s
ok  	cmd/cgo/internal/testcarchive	0.102s
ok  	cmd/cgo/internal/testcshared	0.164s
ok  	cmd/cgo/internal/testerrors	21.664s
ok  	cmd/cgo/internal/testfortran	0.388s
ok  	cmd/cgo/internal/testgodefs	3.514s
ok  	cmd/cgo/internal/testlife	1.818s
ok  	cmd/cgo/internal/testnocgo	0.275s
ok  	cmd/cgo/internal/testplugin	0.302s
ok  	cmd/cgo/internal/testsanitizers	0.131s [no tests to run]
ok  	cmd/cgo/internal/testshared	0.101s
ok  	cmd/cgo/internal/testso	5.922s
ok  	cmd/cgo/internal/teststdio	5.507s
ok  	cmd/cgo/internal/testtls	0.158s
ok  	cmd/compile/internal/abt	0.113s
ok  	cmd/compile/internal/amd64	0.143s
ok  	cmd/compile/internal/base	0.318s
ok  	cmd/compile/internal/compare	0.157s
ok  	cmd/compile/internal/dwarfgen	1.342s
ok  	cmd/compile/internal/importer	5.924s
ok  	cmd/compile/internal/ir	0.115s
ok  	cmd/compile/internal/logopt	0.825s
ok  	cmd/compile/internal/loopvar	52.614s
ok  	cmd/compile/internal/noder	0.172s
ok  	cmd/compile/internal/reflectdata	0.120s [no tests to run]
ok  	cmd/compile/internal/ssa	41.103s
ok  	cmd/compile/internal/syntax	0.200s
ok  	cmd/compile/internal/test	8.540s
ok  	cmd/compile/internal/typecheck	1.118s
ok  	cmd/compile/internal/types	0.122s
ok  	cmd/compile/internal/types2	19.651s
ok  	cmd/covdata	0.158s
ok  	cmd/cover	3.528s
ok  	cmd/dist	0.128s
ok  	cmd/distpack	0.133s
ok  	cmd/doc	0.285s
ok  	cmd/fix	11.790s
ok  	cmd/go	50.675s
ok  	cmd/go/internal/auth	0.218s
ok  	cmd/go/internal/cache	0.556s
ok  	cmd/go/internal/envcmd	0.523s
ok  	cmd/go/internal/fsys	0.215s
ok  	cmd/go/internal/generate	0.208s
ok  	cmd/go/internal/get	0.207s
ok  	cmd/go/internal/gover	0.164s
ok  	cmd/go/internal/imports	0.151s
ok  	cmd/go/internal/load	0.162s
ok  	cmd/go/internal/lockedfile	0.176s
ok  	cmd/go/internal/lockedfile/internal/filelock	0.181s
ok  	cmd/go/internal/modconv	0.153s
ok  	cmd/go/internal/modfetch	0.220s
ok  	cmd/go/internal/modfetch/codehost	14.935s
ok  	cmd/go/internal/modfetch/zip_sum_test	0.180s
ok  	cmd/go/internal/modindex	0.242s
ok  	cmd/go/internal/modload	0.182s
ok  	cmd/go/internal/mvs	0.147s
ok  	cmd/go/internal/par	0.105s
ok  	cmd/go/internal/str	0.167s
ok  	cmd/go/internal/test	0.293s
ok  	cmd/go/internal/toolchain	0.184s
ok  	cmd/go/internal/vcs	0.156s
ok  	cmd/go/internal/vcweb	0.144s
ok  	cmd/go/internal/vcweb/vcstest	11.441s
ok  	cmd/go/internal/web	0.161s
ok  	cmd/go/internal/work	1.077s
ok  	cmd/gofmt	0.194s
ok  	cmd/internal/archive	4.005s
ok  	cmd/internal/bootstrap_test	0.194s
ok  	cmd/internal/buildid	0.169s
ok  	cmd/internal/cov	1.176s
ok  	cmd/internal/dwarf	0.152s
ok  	cmd/internal/edit	0.145s
ok  	cmd/internal/goobj	0.106s
ok  	cmd/internal/moddeps	2.637s
ok  	cmd/internal/notsha256	0.124s
ok  	cmd/internal/obj	1.172s
ok  	cmd/internal/obj/arm64	0.594s
ok  	cmd/internal/obj/ppc64	1.189s
ok  	cmd/internal/obj/riscv	0.532s
ok  	cmd/internal/obj/s390x	0.191s
ok  	cmd/internal/obj/x86	0.927s
ok  	cmd/internal/objabi	0.166s
ok  	cmd/internal/pkgpath	0.314s
ok  	cmd/internal/pkgpattern	0.108s
ok  	cmd/internal/quoted	0.157s
ok  	cmd/internal/src	0.151s
ok  	cmd/internal/test2json	0.189s
ok  	cmd/link	14.437s
ok  	cmd/link/internal/benchmark	0.260s
ok  	cmd/link/internal/ld	16.614s
ok  	cmd/link/internal/loader	0.191s
ok  	cmd/nm	4.294s
ok  	cmd/objdump	10.723s
ok  	cmd/pack	9.918s
ok  	cmd/pprof	0.180s
ok  	cmd/trace	0.204s
ok  	cmd/vet	9.577s

##### os/user with tag osusergo
ok  	os/user	0.104s

##### hash/maphash purego implementation
ok  	hash/maphash	0.134s

##### GOMAXPROCS=2 runtime -cpu=1,2,4 -quick
ok  	runtime	7.936s

##### Testing without libgcc.
ok  	net	0.134s
ok  	os/user	0.092s

##### internal linking of -buildmode=pie
ok  	reflect	0.198s
ok  	os/user	0.127s

##### sync -cpu=10
ok  	sync	0.670s

##### Testing race detector
ok  	runtime/race	5.369s
ok  	flag	1.107s
ok  	net	1.354s
ok  	os	1.195s
ok  	os/exec	2.171s
ok  	encoding/gob	1.152s
ok  	flag	1.146s
ok  	os/exec	2.167s

##### Testing cgo
ok  	cmd/cgo/internal/test	0.324s
ok  	cmd/cgo/internal/test	0.387s
ok  	cmd/cgo/internal/test	0.341s
ok  	cmd/cgo/internal/test	0.311s
ok  	cmd/cgo/internal/test	0.368s

##### ../test
ok  	cmd/internal/testdir	85.723s

##### API check
ok  	cmd/api	20.277s

ALL TESTS PASSED
---
Installed Go for darwin/arm64 in /Users/gopher/gotip
Installed commands in /Users/gopher/gotip/bin
*** You need to add /Users/gopher/gotip/bin to your PATH.
src $ 

@gopherbot
Copy link

Change https://go.dev/cl/503095 mentions this issue: cmd/dist: test all 'std cmd' packages, even ones without _test.go files

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. early-in-cycle A change that should be done early in the 3 month dev cycle. and removed early-in-cycle A change that should be done early in the 3 month dev cycle. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jun 13, 2023
@gopherbot
Copy link

Change https://go.dev/cl/503115 mentions this issue: cmd/dist: skip testing packages without tests in short test mode

@gopherbot
Copy link

This issue is currently labeled as early-in-cycle for Go 1.22.
That time is now, so a friendly reminder to look at it again.

gopherbot pushed a commit that referenced this issue Jul 27, 2023
For short all.bash, we can keep the small speedup of 2-10 seconds by
skipping 'go test' on packages without tests. This is viable without
coverage loss since the Go release process is guaranteed to run long
tests for all first class ports.

For #60463.

Change-Id: Ib5a6bd357d757141bc8f1c1dec148a6565726587
Reviewed-on: https://go-review.googlesource.com/c/go/+/503115
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
early-in-cycle A change that should be done early in the 3 month dev cycle. NeedsFix The path to resolution is known, but the work has not been done.
Projects
Archived in project
Development

No branches or pull requests

3 participants