Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: document GOROOT/bin/go PATH entry for go test and go generate [1.20 backport] #60458

Closed
gopherbot opened this issue May 26, 2023 · 2 comments
Closed

cmd/go: document GOROOT/bin/go PATH entry for go test and go generate [1.20 backport] #60458

gopherbot opened this issue May 26, 2023 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases Documentation GoCommand cmd/go
Milestone
Go1.20.5

Comments

@gopherbot
Copy link

gopherbot commented May 26, 2023 •
edited by dmitshur

@dmitshur requested issue #57050 to be considered for backport to the next 1.20 minor release.

@gopherbot Please consider this as a backport to Go 1.20 and 1.19.

This is a documentation-only fix to document a Go 1.19 feature added to go test and go generate. It'll be easier for users who wish to rely on it to do so when it's documented, and avoids confusion about it otherwise only appearing in cmd/go documentation in Go 1.21 onwards.
(I'm happy to help with preparing backport CLs if approved.)
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label May 26, 2023
@gopherbot gopherbot mentioned this issue May 26, 2023
Closed
@gopherbot gopherbot added this to the Go1.20.5 milestone May 26, 2023
@dmitshur dmitshur added the GoCommand cmd/go label May 26, 2023
@bcmills bcmills added the CherryPickApproved Used during the release process for point releases label May 26, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label May 26, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/499218 mentions this issue: [release-branch.go1.20] cmd/go/internal: update documentation of go test and go generate

@gopherbot
Copy link
Author

Closed by merging b249ec5 to release-branch.go1.20.

gopherbot pushed a commit that referenced this issue May 30, 2023
@shogohida @gopherbot
[release-branch.go1.20] cmd/go/internal: update documentation of go t…
b249ec5 
…est and go generate

For #57050.
Fixes #60458.

Change-Id: I46cac667ff78ac171c878f4366f8f01f58f1d27d
GitHub-Last-Rev: 697c255
GitHub-Pull-Request: #57814
Reviewed-on: https://go-review.googlesource.com/c/go/+/461683
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
(cherry picked from commit 93d9035)
Reviewed-on: https://go-review.googlesource.com/c/go/+/499218
Run-TryBot: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases Documentation GoCommand cmd/go
Projects
None yet
Milestone
Go1.20.5
Development

No branches or pull requests
3 participants
@dmitshur @bcmills @gopherbot