Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: import paths can contain the .test suffix, breaking the toolchain #60454

Open
dominikh opened this issue May 26, 2023 · 5 comments · May be fixed by #61610
Open

cmd/go: import paths can contain the .test suffix, breaking the toolchain #60454

dominikh opened this issue May 26, 2023 · 5 comments · May be fixed by #61610
Labels
GoCommand cmd/go help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@dominikh
Copy link
Member

What version of Go are you using (go version)?

$ go version
go version devel go1.21-231f290e51 Sat Apr 8 05:25:04 2023 +0000 linux/amd64

Does this issue reproduce with the latest release?

Yes

What did you do?

Given

-- foo/foo.go --
package foo

import _ "example.com/foo.test"
-- foo/foo_test.go --
package foo
-- foo.test/bar.go --
package bar
-- go.mod --
module example.com

go 1.21

run go test ./foo

What did you expect to see?

One of

  • no error
  • an explanation for the error
  • an explicit error forbidding using foo.test as an import path

What did you see instead?

/home/dominikh/prj/go/pkg/tool/linux_amd64/link: fingerprint mismatch: example.com/foo.test has 36b962da8ceb542c, import from example.com/foo expecting aa419b4c2ff8e5ed
@mvdan
Copy link
Member

mvdan commented May 26, 2023

an explicit error forbidding using foo.test as an import path

This would be my personal choice - even if supporting such package paths is technically possible, it feels like something we should strongly discourage due to the confusion it could cause.

We always have to worry about backwards compatibility, but... is anyone even declaring such packages today?

@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. GoCommand cmd/go labels May 26, 2023
@bcmills bcmills added this to the Backlog milestone May 26, 2023
@bcmills
Copy link
Contributor

bcmills commented May 26, 2023

(CC @matloob)

@egonelbre
Copy link
Contributor

an explicit error forbidding using foo.test as an import path

This would be my personal choice - even if supporting such package paths is technically possible, it feels like something we should strongly discourage due to the confusion it could cause.

We always have to worry about backwards compatibility, but... is anyone even declaring such packages today?

I've been using .test modules (note, not packages per se) for writing examples or tests, because that TLD is guaranteed not to exist (https://en.wikipedia.org/wiki/.test). But, it's also possible to .example or .invalid as an alternative.

@mvdan
Copy link
Member

mvdan commented May 26, 2023

@egonelbre you can just name those test/..., per #37641.

@qiulaidongfeng qiulaidongfeng linked a pull request Jul 27, 2023 that will close this issue
Open
@gopherbot
Copy link

Change https://go.dev/cl/513655 mentions this issue: cmd/go: reject import paths with suffix .test

@bcmills bcmills mentioned this issue Nov 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
GoCommand cmd/go help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

cmd/go: reject import paths with suffix .test qiulaidongfeng/go
5 participants
@dominikh @egonelbre @mvdan @bcmills @gopherbot