-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go: promote -fullpath from test flag to build flag #60451
Comments
Yup, that sounds about right. I think that would be worth doing. |
Sounds reasonable. This is essentially a revision on proposal #37708, so it should probably be a proposal itself. |
This proposal has been added to the active column of the proposals project |
I think this would mean making -fullpath a build flag (as opposed to a test flag) and then have base.ShortPath not shorten when the flag is set. Does anyone object to this? |
Based on the discussion above, this proposal seems like a likely accept. |
No change in consensus, so accepted. 🎉 |
If we add
What do you think if we just pass |
Change https://go.dev/cl/535075 mentions this issue: |
@quantonganh, if It isn't clear to me what |
Also: if |
I'm glad it's implemented now, but I can't figure out how to use |
To streamline editor error navigation, I've created a simple filter as a workaround. This tool reads stdin, replaces relative paths, and writes the modified output to stdout.
|
@karnigen This isn't implemented in the go command yet. There's a CL out for review but it hasn't been submitted or released. |
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
N/A
What did you do?
I ran this testscript:
What did you expect to see?
A passing test.
What did you see instead?
It seems to me that the intent of
-fullpath
is to cause all filenames to print in a way that's absolute, even when those errors come from the compiler rather than the test binary. I'd expect the compiler error to print an absolute path there too.The text was updated successfully, but these errors were encountered: