Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/crypto/acme: GetAuthorization will panic in some cases #60446

Open
TNED opened this issue May 26, 2023 · 0 comments
Open

x/crypto/acme: GetAuthorization will panic in some cases #60446

TNED opened this issue May 26, 2023 · 0 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@TNED
Copy link

TNED commented May 26, 2023

What version of Go are you using (go version)?

$ go version 1.20.3

Does this issue reproduce with the latest release?

When using method client.GetAuthorization , it will panic unmarshal field authorization: json: cannot unmarshal object into Go struct field Challenge.Challenges.Error of type error

response data

{
    "identifier": {
        "type": "dns",
        "value": "example.com"
    },
    "status": "invalid",
    "expires": "2023-06-01T01:13:43Z",
    "challenges": [
        {
            "type": "dns-01",
            "status": "invalid",
            "error": {
                "type": "urn:ietf:params:acme:error:unauthorized",
                "detail": "No TXT record found at _acme-challenge.example.com",
                "status": 403
            },
            "url": "-",
            "token": "-",
            "validated": "2023-05-25T05:30:57Z"
        }
    ]
}

What operating system and processor architecture are you using (go env)?

go env Output
$ go env

What did you do?

should fix it, this shouldn't panic.
@TNED TNED changed the title golang.org/x/crypto/acme: golang.org/x/crypto/acme: GetAuthorization will panic in some cases May 26, 2023
@mengzhuo mengzhuo changed the title golang.org/x/crypto/acme: GetAuthorization will panic in some cases x/crypto/acme: GetAuthorization will panic in some cases May 27, 2023
@gopherbot gopherbot added this to the Unreleased milestone May 27, 2023
@seankhliao seankhliao added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@gopherbot @seankhliao @TNED