Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

database/sql: TestContextCancelDuringRawBytesScan failures #60445

Closed
gopherbot opened this issue May 25, 2023 · 8 comments
Closed

database/sql: TestContextCancelDuringRawBytesScan failures #60445

gopherbot opened this issue May 25, 2023 · 8 comments
Labels
NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.21

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "database/sql" && test == "TestContextCancelDuringRawBytesScan"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestContextCancelDuringRawBytesScan (0.00s)
    sql_test.go:4416: read "Alice"
    sql_test.go:4416: read "Bob"
    sql_test.go:4411: expected closemu to be held
    sql_test.go:4414: context canceled

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 25, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "database/sql" && test == "TestContextCancelDuringRawBytesScan"
2023-05-25 21:01 linux-riscv64-unmatched go@01b5cce6 database/sql.TestContextCancelDuringRawBytesScan (log) 
--- FAIL: TestContextCancelDuringRawBytesScan (0.00s)
    sql_test.go:4416: read "Alice"
    sql_test.go:4416: read "Bob"
    sql_test.go:4411: expected closemu to be held
    sql_test.go:4414: context canceled

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "database/sql" && test == "TestContextCancelDuringRawBytesScan"
2023-06-01 23:34 windows-amd64-race go@40c7be9b database/sql.TestContextCancelDuringRawBytesScan (log) 
--- FAIL: TestContextCancelDuringRawBytesScan (0.00s)
    sql_test.go:4416: read "Alice"
    sql_test.go:4416: read "Bob"
    sql_test.go:4411: expected closemu to be held
    sql_test.go:4414: context canceled

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "database/sql" && test == "TestContextCancelDuringRawBytesScan"
2023-06-03 00:53 freebsd-amd64-race go@3fd867ce database/sql.TestContextCancelDuringRawBytesScan (log) 
--- FAIL: TestContextCancelDuringRawBytesScan (0.00s)
    sql_test.go:4416: read "Alice"
    sql_test.go:4416: read "Bob"
    sql_test.go:4411: expected closemu to be held
    sql_test.go:4414: context canceled

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented Jun 13, 2023

From the rate and timing of failures, this looks like a platform-independent regression during the Go 1.21 cycle. It should be diagnosed and either fixed or skipped before the release.

Marking as release-blocker until that happens.

(attn @bradfitz @kardianos @kevinburke per https://dev.golang.org/owners)

@golang/release, it appears this issue slipped through the cracks of triage; is there something we should do to make that less likely going forward?

@bcmills bcmills added this to the Go1.21 milestone Jun 13, 2023
@bcmills
Copy link
Contributor

bcmills commented Jun 13, 2023

There is another one of these on linux-amd64-longtest, which watchflakes hasn't posted yet but probably will soon:
https://build.golang.org/log/e69f3125cbdf586caed957a13c97eeb3b7044f55

@gopherbot
Copy link
Author

Change https://go.dev/cl/502876 mentions this issue: database/sql: fix flake in TestContextCancelDuringRawBytesScan

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "database/sql" && test == "TestContextCancelDuringRawBytesScan"
2023-06-13 17:40 linux-amd64-longtest-race go@ee5af610 database/sql.TestContextCancelDuringRawBytesScan (log) 
--- FAIL: TestContextCancelDuringRawBytesScan (0.00s)
    sql_test.go:4416: read "Alice"
    sql_test.go:4416: read "Bob"
    sql_test.go:4411: expected closemu to be held
    sql_test.go:4414: context canceled

— watchflakes

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jun 13, 2023
@gopherbot

This comment was marked as outdated.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
Test Flakes
Status: Done
Milestone
Go1.21
Development

No branches or pull requests
3 participants
@dmitshur @bcmills @gopherbot