Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/internal/bigmod: fix panic [freeze exception] #60422

Closed
rolandshoemaker opened this issue May 25, 2023 · 2 comments
Closed

crypto/internal/bigmod: fix panic [freeze exception] #60422

rolandshoemaker opened this issue May 25, 2023 · 2 comments
Labels
FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Milestone
Go1.21

Comments

@rolandshoemaker
Copy link
Member

#60411 was only filed today, as it was blocked by an internal security investigation. The CL (http://go.dev/cl/498035) was sent & reviewed, but just slipped the deadline for the freeze. The change is small, tested, and reviewed, so I don't think it poses a significant risk.

cc @golang/release
@rolandshoemaker rolandshoemaker added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label May 25, 2023
@dmitshur dmitshur added this to the Go1.21 milestone May 25, 2023
@ianlancetaylor
Copy link
Member

My understanding is that actual bug fixes (and doc changes) are OK at the moment. Freeze exceptions are required for new features.

(Please correct me if I am wrong.)

@rolandshoemaker
Copy link
Member Author

Oh I completely misread the change in the freeze policy, and this makes complete sense 🤦, ignore me!

@dmitshur dmitshur closed this as not planned Won't fix, can't repro, duplicate, stale May 25, 2023
@golang golang locked and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Projects
Go Release
Archived in project
Release: Freeze Exceptions
Archived in project
Milestone
Go1.21
Development

No branches or pull requests
4 participants
@dmitshur @ianlancetaylor @rolandshoemaker @gopherbot