Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: GOEXPERIMENT=gocacheprog [freeze exception] #60419

Closed
rsc opened this issue May 25, 2023 · 5 comments
Closed

cmd/go: GOEXPERIMENT=gocacheprog [freeze exception] #60419

rsc opened this issue May 25, 2023 · 5 comments
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.21

Comments

@rsc
Copy link
Contributor

rsc commented May 25, 2023

Requesting a freeze exception for CL 486715 for Brad's GOEXPERIMENT=cacheprog work. It's clean and well isolated and doesn't affect anything unless you explicitly set GOEXPERIMENT=cacheprog. We want to make it available in Go 1.21 as an experiment in order to get feedback for promoting it to a real feature. Thanks.
@dmitshur dmitshur mentioned this issue May 25, 2023
Closed
@dmitshur
Copy link
Contributor

Also copying @bradfitz's rationale from #60420:

I forgot to submit https://go-review.googlesource.com/c/go/+/486715 this morning after getting @bcmills's approval. I was going to spend the evening stress testing it more and then submit. I didn't know about this cycle's new freeze rules now including in-progress changes. 😬

CC @golang/release.

@dmitshur
Copy link
Contributor

That CL has some comments that need to be resolved. It also says "Updates #59719"—is there more that needs to happen for that proposal or is that CL fine to submit now and leave further changes for 1.22?

@dmitshur dmitshur added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label May 25, 2023
@dmitshur dmitshur added this to the Go1.21 milestone May 25, 2023
@bradfitz
Copy link
Contributor

bradfitz commented May 25, 2023 •
edited

It's all addressed now. I didn't say "Fixes" until it lands without an experiment, hopefully next cycle.

@bradfitz
Copy link
Contributor

(but I can also say "Fixes" here and file a new bug later... no preference.)

@dmitshur
Copy link
Contributor

The proposal was approved just today and this just missed the freeze by half an hour but is otherwise ready, so I can trivially approve this. Please feel free to go ahead with the CL, and thanks for letting us know.

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels May 25, 2023
@danp danp mentioned this issue Dec 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Milestone
Go1.21
Development

No branches or pull requests
3 participants
@bradfitz @rsc @dmitshur