Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/internal/bigmod: NewModulusFromBig(0) panics #60411

Closed
rolandshoemaker opened this issue May 24, 2023 · 1 comment
Closed

crypto/internal/bigmod: NewModulusFromBig(0) panics #60411

rolandshoemaker opened this issue May 24, 2023 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.21

Comments

@rolandshoemaker
Copy link
Member

Cannot be triggered by normally generated/parsed keys, only manually constructed ones, so minor impact.

It should probably be returning an error.

cc @FiloSottile
@rolandshoemaker rolandshoemaker added the NeedsFix The path to resolution is known, but the work has not been done. label May 24, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/498035 mentions this issue: crypto/internal/bigmod: don't panic on NewModulusFromBig(0)

@dmitshur dmitshur added this to the Go1.21 milestone May 25, 2023
@golang golang locked and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.21
Development

No branches or pull requests
3 participants
@dmitshur @rolandshoemaker @gopherbot