Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: CL 496958 breaks TestScript/build_pgo_auto_multi on windows-amd64-longtest #60408

Closed
prattmic opened this issue May 24, 2023 · 3 comments
Closed

cmd/go: CL 496958 breaks TestScript/build_pgo_auto_multi on windows-amd64-longtest #60408

prattmic opened this issue May 24, 2023 · 3 comments
Assignees
@prattmic
Labels
GoCommand cmd/go NeedsFix The path to resolution is known, but the work has not been done. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.21

Comments

@prattmic
Copy link
Member 

#!watchflakes
post <- pkg == "cmd/go" && test ~ `TestScript/build_pgo.*` && goos == "windows"

It is just bad path matching in the regular expressions.

        script_test.go:154: FAIL: build_pgo.txt:16: stdout -pgo=.*/prof: no match for `(?m)-pgo=.*/prof` in stdout
...
        script_test.go:154: FAIL: build_pgo_auto_multi.txt:40: stdout -pgo=.*a\default\.pgo: no match for `(?m)-pgo=.*a\default\.pgo` in stdout

FYI @bcmills
@prattmic prattmic added NeedsFix The path to resolution is known, but the work has not been done. release-blocker labels May 24, 2023
@prattmic prattmic added this to the Go1.21 milestone May 24, 2023
@prattmic prattmic self-assigned this May 24, 2023
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. GoCommand cmd/go labels May 24, 2023
@gopherbot
Copy link

Change https://go.dev/cl/497881 mentions this issue: cmd/go: fix PGO script flag matching

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/go" && test ~ `TestScript/build_pgo.*` && goos == "windows"
2024-01-22 21:47 gotip-windows-amd64-longtest go@b7ae16e0 cmd/go.TestScript/build_pgo (log) 
=== RUN   TestScript/build_pgo
=== PAUSE TestScript/build_pgo
=== CONT  TestScript/build_pgo
    script_test.go:132: 2024-01-22T22:08:43Z
    script_test.go:134: $WORK=C:\b\s\w\ir\x\t\cmd-go-test-3692776134\tmpdir2393186319\build_pgo3343780860
    script_test.go:156: 
        PATH=C:\b\s\w\ir\x\t\cmd-go-test-3692776134\tmpdir2393186319\testbin;C:\b\s\w\ir\x\w\goroot\bin;C:\b\s\w\ir\x\w\goroot\bin;C:\b\s\w\ir\x\w\goroot\bin;C:\b\s\w\ir\cache\tools\bin;C:\b\s\w\ir\bbagent_utility_packages;C:\b\s\w\ir\bbagent_utility_packages\bin;C:\b\s\w\ir\cipd_bin_packages;C:\b\s\w\ir\cipd_bin_packages\bin;C:\b\s\w\ir\cipd_bin_packages\cpython3;C:\b\s\w\ir\cipd_bin_packages\cpython3\bin;C:\b\s\w\ir\cache\cipd_client;C:\b\s\w\ir\cache\cipd_client\bin;C:\b\s\cipd_cache\bin;C:\Program Files\OpenSSH\;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Windows\System32\OpenSSH\;C:\Program Files\Puppet Labs\Puppet\bin;C:\b\s\w\ir\cache\tools\cc\windows\gcc64\bin
        USERPROFILE=/no-home
        CCACHE_DISABLE=1
        GOARCH=amd64
...
        echo '# import config' > $WORK\b007\importcfg # internal
        cd C:\b\s\w\ir\x\t\cmd-go-test-3692776134\tmpdir2393186319\build_pgo3343780860\gopath\src
        "C:\\b\\s\\w\\ir\\x\\w\\goroot\\pkg\\tool\\windows_amd64\\compile.exe" -o "$WORK\\b013\\_pkg_.a" -trimpath "$WORK\\b013=>" -p runtime/internal/atomic -std -buildid RSX-BHVAihmVPbq9ZPSI/RSX-BHVAihmVPbq9ZPSI "-pgoprofile=C:\\b\\s\\w\\ir\\x\\t\\cmd-go-test-3692776134\\tmpdir2393186319\\build_pgo3343780860\\gopath\\src\\prof" -symabis "$WORK\\b013\\symabis" -c=4 -nolocalimports -importcfg "$WORK\\b013\\importcfg" -pack -asmhdr "$WORK\\b013\\go_asm.h" "C:\\b\\s\\w\\ir\\x\\w\\goroot\\src\\runtime\\internal\\atomic\\atomic_amd64.go" "C:\\b\\s\\w\\ir\\x\\w\\goroot\\src\\runtime\\internal\\atomic\\doc.go" "C:\\b\\s\\w\\ir\\x\\w\\goroot\\src\\runtime\\internal\\atomic\\stubs.go" "C:\\b\\s\\w\\ir\\x\\w\\goroot\\src\\runtime\\internal\\atomic\\types.go" "C:\\b\\s\\w\\ir\\x\\w\\goroot\\src\\runtime\\internal\\atomic\\types_64bit.go" "C:\\b\\s\\w\\ir\\x\\w\\goroot\\src\\runtime\\internal\\atomic\\unaligned.go"
        "C:\\b\\s\\w\\ir\\x\\w\\goroot\\pkg\\tool\\windows_amd64\\compile.exe" -o "$WORK\\b007\\_pkg_.a" -trimpath "$WORK\\b007=>" -p internal/cpu -std -buildid DzPU9eAaseixnTstxR7z/DzPU9eAaseixnTstxR7z "-pgoprofile=C:\\b\\s\\w\\ir\\x\\t\\cmd-go-test-3692776134\\tmpdir2393186319\\build_pgo3343780860\\gopath\\src\\prof" -symabis "$WORK\\b007\\symabis" -c=4 -nolocalimports -importcfg "$WORK\\b007\\importcfg" -pack -asmhdr "$WORK\\b007\\go_asm.h" "C:\\b\\s\\w\\ir\\x\\w\\goroot\\src\\internal\\cpu\\cpu.go" "C:\\b\\s\\w\\ir\\x\\w\\goroot\\src\\internal\\cpu\\cpu_x86.go"
        # runtime/internal/atomic
        compile: C:\b\s\w\ir\x\t\cmd-go-test-3692776134\tmpdir2393186319\build_pgo3343780860\gopath\src\prof: PGO error: error opening profile: EOF
        # internal/cpu
        compile: C:\b\s\w\ir\x\t\cmd-go-test-3692776134\tmpdir2393186319\build_pgo3343780860\gopath\src\prof: PGO error: error opening profile: EOF
    script_test.go:156: FAIL: testdata\script\build_pgo.txt:11: go build -x -pgo=prof -o triv.exe triv.go: exit status 1
--- FAIL: TestScript/build_pgo (2.47s)
2024-01-22 21:47 gotip-windows-amd64-longtest go@c4696665 cmd/go.TestScript/build_pgo (log) 
=== RUN   TestScript/build_pgo
=== PAUSE TestScript/build_pgo
=== CONT  TestScript/build_pgo
    script_test.go:132: 2024-01-22T22:06:14Z
    script_test.go:134: $WORK=C:\b\s\w\ir\x\t\cmd-go-test-3825925210\tmpdir2995068005\build_pgo1271666269
    script_test.go:156: 
        PATH=C:\b\s\w\ir\x\t\cmd-go-test-3825925210\tmpdir2995068005\testbin;C:\b\s\w\ir\x\w\goroot\bin;C:\b\s\w\ir\x\w\goroot\bin;C:\b\s\w\ir\x\w\goroot\bin;C:\b\s\w\ir\cache\tools\bin;C:\b\s\w\ir\bbagent_utility_packages;C:\b\s\w\ir\bbagent_utility_packages\bin;C:\b\s\w\ir\cipd_bin_packages;C:\b\s\w\ir\cipd_bin_packages\bin;C:\b\s\w\ir\cipd_bin_packages\cpython3;C:\b\s\w\ir\cipd_bin_packages\cpython3\bin;C:\b\s\w\ir\cache\cipd_client;C:\b\s\w\ir\cache\cipd_client\bin;C:\b\s\cipd_cache\bin;C:\Program Files\OpenSSH\;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Windows\System32\OpenSSH\;C:\Program Files\Puppet Labs\Puppet\bin;C:\b\s\w\ir\cache\tools\cc\windows\gcc64\bin
        USERPROFILE=/no-home
        CCACHE_DISABLE=1
        GOARCH=amd64
...
        echo '# import config' > $WORK\b013\importcfg # internal
        cd C:\b\s\w\ir\x\t\cmd-go-test-3825925210\tmpdir2995068005\build_pgo1271666269\gopath\src
        "C:\\b\\s\\w\\ir\\x\\w\\goroot\\pkg\\tool\\windows_amd64\\compile.exe" -o "$WORK\\b007\\_pkg_.a" -trimpath "$WORK\\b007=>" -p internal/cpu -std -buildid nYiYaRV85u-Z4iwnRbfW/nYiYaRV85u-Z4iwnRbfW "-pgoprofile=C:\\b\\s\\w\\ir\\x\\t\\cmd-go-test-3825925210\\tmpdir2995068005\\build_pgo1271666269\\gopath\\src\\prof" -symabis "$WORK\\b007\\symabis" -c=4 -nolocalimports -importcfg "$WORK\\b007\\importcfg" -pack -asmhdr "$WORK\\b007\\go_asm.h" "C:\\b\\s\\w\\ir\\x\\w\\goroot\\src\\internal\\cpu\\cpu.go" "C:\\b\\s\\w\\ir\\x\\w\\goroot\\src\\internal\\cpu\\cpu_x86.go"
        "C:\\b\\s\\w\\ir\\x\\w\\goroot\\pkg\\tool\\windows_amd64\\compile.exe" -o "$WORK\\b013\\_pkg_.a" -trimpath "$WORK\\b013=>" -p runtime/internal/atomic -std -buildid JRbGHs6qcclYWsG59fOc/JRbGHs6qcclYWsG59fOc "-pgoprofile=C:\\b\\s\\w\\ir\\x\\t\\cmd-go-test-3825925210\\tmpdir2995068005\\build_pgo1271666269\\gopath\\src\\prof" -symabis "$WORK\\b013\\symabis" -c=4 -nolocalimports -importcfg "$WORK\\b013\\importcfg" -pack -asmhdr "$WORK\\b013\\go_asm.h" "C:\\b\\s\\w\\ir\\x\\w\\goroot\\src\\runtime\\internal\\atomic\\atomic_amd64.go" "C:\\b\\s\\w\\ir\\x\\w\\goroot\\src\\runtime\\internal\\atomic\\doc.go" "C:\\b\\s\\w\\ir\\x\\w\\goroot\\src\\runtime\\internal\\atomic\\stubs.go" "C:\\b\\s\\w\\ir\\x\\w\\goroot\\src\\runtime\\internal\\atomic\\types.go" "C:\\b\\s\\w\\ir\\x\\w\\goroot\\src\\runtime\\internal\\atomic\\types_64bit.go" "C:\\b\\s\\w\\ir\\x\\w\\goroot\\src\\runtime\\internal\\atomic\\unaligned.go"
        # internal/cpu
        compile: C:\b\s\w\ir\x\t\cmd-go-test-3825925210\tmpdir2995068005\build_pgo1271666269\gopath\src\prof: PGO error: error opening profile: EOF
        # runtime/internal/atomic
        compile: C:\b\s\w\ir\x\t\cmd-go-test-3825925210\tmpdir2995068005\build_pgo1271666269\gopath\src\prof: PGO error: error opening profile: EOF
    script_test.go:156: FAIL: testdata\script\build_pgo.txt:11: go build -x -pgo=prof -o triv.exe triv.go: exit status 1
--- FAIL: TestScript/build_pgo (2.98s)

— watchflakes

@gopherbot gopherbot reopened this Jan 25, 2024
@prattmic
Copy link
Member Author

Breakage reverted in https://go.dev/cl/557460.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prattmic prattmic

Labels
GoCommand cmd/go NeedsFix The path to resolution is known, but the work has not been done. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Test Flakes
Status: Done
Milestone
Go1.21
Development

No branches or pull requests
3 participants
@prattmic @bcmills @gopherbot