Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: go build either looks for go.mod in the directory specified by -C or doesn't depending on where -C appears relative to -gcflags #60392

Closed
aarzilli opened this issue May 24, 2023 · 3 comments
Closed

cmd/go: go build either looks for go.mod in the directory specified by -C or doesn't depending on where -C appears relative to -gcflags #60392

aarzilli opened this issue May 24, 2023 · 3 comments
Labels
GoCommand cmd/go NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Comments

@aarzilli
Copy link
Contributor

aarzilli commented May 24, 2023 •
edited 

$ go version
go version devel go1.21-40bdc56180 Tue May 23 13:22:25 2023 +0000 linux/amd64

but also reproduces with 1.20. Reproducer:

$ mkdir example
$ cd example
$ go mod init example
$ cat - > main.go
package main
func main() { println("hello world") }
^D
$ cd ..
$ go build -C example -gcflags=""
(succeeds)
$ go build -gcflags="" -C example
go: go.mod file not found in current directory or any parent directory; see 'go help modules'

Originally reported at go-delve/delve#3380 (comment)
@aarzilli
Copy link
Contributor Author

cc @bcmills

@seankhliao seankhliao added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. GoCommand cmd/go labels May 29, 2023
@seankhliao
Copy link
Member

both -C and the build flags are processed as they are set, doesn't seem like an easy fix

go/src/cmd/go/internal/base/flag.go

Line 65 in 7ad92e9

flags.Func("C", "AddChdirFlag", os.Chdir)

go/src/cmd/go/internal/work/build.go

Line 313 in 7ad92e9

cmd.Flag.Var(&load.BuildGcflags, "gcflags", "")

go/src/cmd/go/internal/load/flag.go

Line 38 in 7ad92e9

return f.set(v, base.Cwd())

@bcmills
Copy link
Contributor

bcmills commented Jan 23, 2024

The documentation for go build currently states:

If used, [the -C] flag must be the first one in the command line.

That restriction was added in https://go.dev/cl/500915 for #57001.

Closing as probably fixed, but please let us know if you can still reproduce similar problems using Go 1.21 or higher.

@bcmills bcmills closed this as completed Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
GoCommand cmd/go NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aarzilli @bcmills @seankhliao