Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite/internal/stdlib: update for "go1.21.0" onwards keeping ".0" trailing component #60373

Closed
dmitshur opened this issue May 23, 2023 · 4 comments
Closed

x/pkgsite/internal/stdlib: update for "go1.21.0" onwards keeping ".0" trailing component #60373

dmitshur opened this issue May 23, 2023 · 4 comments
Assignees
@findleyr
Labels
NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.21

Comments

@dmitshur
Copy link
Contributor

dmitshur commented May 23, 2023 •
edited

This package has a few places that might need updates for proposal #57631.
@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 23, 2023
@dmitshur dmitshur added this to the Unreleased milestone May 23, 2023
@dmitshur dmitshur mentioned this issue May 23, 2023
Closed
@heschi
Copy link
Contributor

heschi commented May 23, 2023

cc @golang/pkgsite

@heschi heschi modified the milestones: Unreleased, Go1.21 Jul 6, 2023
@matt-boris matt-boris mentioned this issue Jul 11, 2023
Closed
@cherrymui
Copy link
Member

Hello @golang/pkgsite @findleyr
It is now ~4 weeks before the 1.21 release. This is a release blocker issue so it needs to be addressed soon. Any updates on this? Thanks!

@findleyr
Copy link
Contributor

findleyr commented Jul 12, 2023 •
edited

Thanks. I was planning on doing this later this week, but I'll up its priority.

EDIT: I meant later this month, but anyway I'll do it now :)

@gopherbot
Copy link

Change https://go.dev/cl/508937 mentions this issue: internal/stdlib: update to account for .0 major version suffixes

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@findleyr findleyr

Labels
NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
Go1.21
Development

No branches or pull requests
5 participants
@dmitshur @gopherbot @cherrymui @heschi @findleyr