Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: TestStackGrowthCallback failures #60365

Closed
gopherbot opened this issue May 23, 2023 · 3 comments
Closed

runtime: TestStackGrowthCallback failures #60365

gopherbot opened this issue May 23, 2023 · 3 comments
Assignees
@mknyszek
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.21

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "runtime" && test == "TestStackGrowthCallback"

Issue created automatically to collect these failures.

Example (log):

panic: test timed out after 50m0s
running tests:
	TestStackGrowthCallback (46m8s)

runtime.gopark(0x1483fd8?, 0x1748c20?, 0x12?, 0x19?, 0x4?)
	/tmp/buildlet/go/src/runtime/proc.go:398 +0x10e fp=0xc000c2c680 sp=0xc000c2c660 pc=0x104192e
runtime.goparkunlock(...)
	/tmp/buildlet/go/src/runtime/proc.go:404
runtime.semacquire1(0xc000927d38, 0x0?, 0x1, 0x0, 0x12?)
	/tmp/buildlet/go/src/runtime/sema.go:160 +0x258 fp=0xc000c2c6e8 sp=0xc000c2c680 pc=0x1053658
sync.runtime_Semacquire(0xc000927d38?)
	/tmp/buildlet/go/src/runtime/sema.go:62 +0x30 fp=0xc000c2c720 sp=0xc000c2c6e8 pc=0x107a150
sync.(*WaitGroup).Wait(0xc000927d30?)
	/tmp/buildlet/go/src/sync/waitgroup.go:116 +0x54 fp=0xc000c2c748 sp=0xc000c2c720 pc=0x10878b4
runtime_test.TestStackGrowthCallback(0xc000402ea0?)
	/tmp/buildlet/go/src/runtime/stack_test.go:221 +0x12f fp=0xc000c2c770 sp=0xc000c2c748 pc=0x137f54f
testing.tRunner(0xc000402ea0, 0x14837c8)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 23, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime" && test == "TestStackGrowthCallback"
2023-05-23 11:37 darwin-amd64-longtest go@f81c8858 runtime.TestStackGrowthCallback (log) 
panic: test timed out after 50m0s
running tests:
	TestStackGrowthCallback (46m8s)

runtime.gopark(0x1483fd8?, 0x1748c20?, 0x12?, 0x19?, 0x4?)
	/tmp/buildlet/go/src/runtime/proc.go:398 +0x10e fp=0xc000c2c680 sp=0xc000c2c660 pc=0x104192e
runtime.goparkunlock(...)
	/tmp/buildlet/go/src/runtime/proc.go:404
runtime.semacquire1(0xc000927d38, 0x0?, 0x1, 0x0, 0x12?)
	/tmp/buildlet/go/src/runtime/sema.go:160 +0x258 fp=0xc000c2c6e8 sp=0xc000c2c680 pc=0x1053658
sync.runtime_Semacquire(0xc000927d38?)
	/tmp/buildlet/go/src/runtime/sema.go:62 +0x30 fp=0xc000c2c720 sp=0xc000c2c6e8 pc=0x107a150
sync.(*WaitGroup).Wait(0xc000927d30?)
	/tmp/buildlet/go/src/sync/waitgroup.go:116 +0x54 fp=0xc000c2c748 sp=0xc000c2c720 pc=0x10878b4
runtime_test.TestStackGrowthCallback(0xc000402ea0?)
	/tmp/buildlet/go/src/runtime/stack_test.go:221 +0x12f fp=0xc000c2c770 sp=0xc000c2c748 pc=0x137f54f
testing.tRunner(0xc000402ea0, 0x14837c8)

— watchflakes

@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label May 23, 2023
@mknyszek mknyszek self-assigned this May 24, 2023
@mknyszek mknyszek added this to the Go1.21 milestone May 24, 2023
@mknyszek mknyszek mentioned this issue Jun 16, 2023
Closed
@mknyszek
Copy link
Contributor

Looking more closely at this issue, I just realized this is failing in the mayMoreStack section. In fact, this hang looks a lot like the failures in #55160 in general. For instance, there's clearly a runnable goroutine sitting there, likely for the entire duration of the deadlock, which suggests a failure of work conservation in the Go scheduler (as @prattmic discovered).

@mknyszek
Copy link
Contributor

I'm not certain why watchflakes opened a new issue here given that this happened in the mayMoreStack section, but I definitely think this is a duplicate of #55160.

@mknyszek mknyszek closed this as not planned Won't fix, can't repro, duplicate, stale Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mknyszek mknyszek

Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Test Flakes
Status: Done
Milestone
Go1.21
Development

No branches or pull requests
2 participants
@mknyszek @gopherbot