Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: TestCloseIdleConnections failures #60364

Open
gopherbot opened this issue May 23, 2023 · 2 comments
Open

net/http: TestCloseIdleConnections failures #60364

gopherbot opened this issue May 23, 2023 · 2 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@gopherbot
Copy link

gopherbot commented May 23, 2023 •
edited by bcmills 

#!watchflakes
post <- pkg == "net/http" && test == "TestCloseIdleConnections" && `didn't close connection`

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestCloseIdleConnections (0.00s)
    --- FAIL: TestCloseIdleConnections/h1 (0.01s)
        clientserver_test.go:1371: didn't close connection

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 23, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestCloseIdleConnections"
2023-05-23 11:37 solaris-amd64-oraclerel go@ef670224 net/http.TestCloseIdleConnections (log) 
--- FAIL: TestCloseIdleConnections (0.00s)
    --- FAIL: TestCloseIdleConnections/h1 (0.01s)
        clientserver_test.go:1371: didn't close connection

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented May 23, 2023

(CC @neild, @golang/solaris)

I'm guessing this is probably a timing issue — perhaps the connection isn't being marked idle in time for the CloseIdleConnections call.

@bcmills bcmills added this to the Backlog milestone May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Test Flakes
Status: No status
Milestone
Backlog
Development

No branches or pull requests
2 participants
@bcmills @gopherbot