Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal: debug/elf: add R_PPC64_REL24_P9NOTOC #60348

Closed
pmur opened this issue May 22, 2023 · 4 comments
Closed

proposal: debug/elf: add R_PPC64_REL24_P9NOTOC #60348

pmur opened this issue May 22, 2023 · 4 comments
Labels
help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Backlog

Comments

@pmur
Copy link
Contributor

pmur commented May 22, 2023

This relocation is generated by gnu gas when @notoc relocations are used and the target CPU does not support power10 instructions. It is identical to R_PPC64_REL24_NOTOC, except that any linker mediated stubs should not use power10 or newer instructions.

It is not (yet?) defined by the PPC64 ELFv2 supplement, but I did encounter this behavior when creating CL 496916.

I propose adding elf.R_PPC64_REL24_P9NOTOC = 124 to support testing the internal linker.
@pmur pmur added the Proposal label May 22, 2023
@gopherbot gopherbot added this to the Proposal milestone May 22, 2023
@ianlancetaylor
Copy link
Contributor

It's always OK to add these kinds of new constants to debug/*.

@ianlancetaylor ianlancetaylor added NeedsFix The path to resolution is known, but the work has not been done. and removed Proposal labels May 22, 2023
@ianlancetaylor ianlancetaylor modified the milestones: Proposal, Backlog May 22, 2023
@gopherbot
Copy link

Change https://go.dev/cl/496918 mentions this issue: debug/elf: define R_PPC64_REL24_P9NOTOC

@pmur
Copy link
Contributor Author

pmur commented May 22, 2023

What is the correct way to add this while obeying the new API proposal requirement?

@ianlancetaylor
Copy link
Contributor

You can open an issue like this one, and refer to it in $GOROOT/api/next, but it doesn't have to be a proposal issue. Thanks.

@mknyszek mknyszek mentioned this issue Jun 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@ianlancetaylor @gopherbot @pmur