Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: paragraph links work incorrectly on mobile #60347

Open
handsomefox opened this issue May 22, 2023 · 2 comments
Open

x/pkgsite: paragraph links work incorrectly on mobile #60347

handsomefox opened this issue May 22, 2023 · 2 comments
Labels
pkgsite
Milestone
pkgsite/backlog

Comments

@handsomefox
Copy link

What is the URL of the page with the issue?

https://pkg.go.dev/runtime#SetFinalizer

What is your user agent?

Mozilla/5.0 (Linux; Android 10; K) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/113.0.0.0 Mobile Safari/537.36

Screenshot

Screenshot_2023-05-22-19-00-00-43_40deb401b9ffe8e1df2f1cc5ba480b12.jpg

What did you do?

  1. Got a link to a package, linking specifically to a paragraph (specifically, a function in that case)
  2. Opened the link using Chrome

What did you expect to see?

I expected to see my browser opening the link at that specific paragraph

What did you see instead?

The browser opened the link correctly, then jumped to the top of the page

Using links like: https://pkg.go.dev/runtime#:~:text=func%20SetFinalizer%20%C2%B6,will%20free%20obj does work.

Video of the issue: https://github.com/golang/go/assets/29275085/70f3e565-4cce-4b5b-bc53-9d1ade23785f
@gopherbot gopherbot added this to the Unreleased milestone May 22, 2023
@suzmue suzmue modified the milestones: Unreleased, pkgsite/later May 22, 2023
@seankhliao seankhliao mentioned this issue Apr 4, 2024
Closed
@mdempsky
Copy link
Member

mdempsky commented Apr 4, 2024

@suzmue I ran into this today. I can reliably reproduce it. Could you use any help investigating and/or fixing it? I'm happy to dig into it further, but I could some help getting started. Thanks. 😊

@thediveo
Copy link

thediveo commented Apr 7, 2024

See this issue still too, clicking in the address bar and then pressing enter scrolls anchor into view. but only after this manual intervention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pkgsite
Projects
None yet
Milestone
pkgsite/backlog
Development

No branches or pull requests
5 participants
@mdempsky @suzmue @thediveo @gopherbot @handsomefox