Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: misleading orphaned file diagnostics when using multiple views #60342

Closed
findleyr opened this issue May 22, 2023 · 1 comment
Closed

x/tools/gopls: misleading orphaned file diagnostics when using multiple views #60342

findleyr opened this issue May 22, 2023 · 1 comment
Assignees
@findleyr
Labels
FrozenDueToAge gopls/metadata Issues related to metadata loading in gopls gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.15.0

Comments

@findleyr
Copy link
Member

Just noticed this: when using multiple views, a file may be reported as orphaned in one even though it is not orphaned in another.

This is rather confusing, and must be fixed before #57979.
@findleyr findleyr added the gopls/metadata Issues related to metadata loading in gopls label May 22, 2023
@findleyr findleyr added this to the gopls/v0.13.0 milestone May 22, 2023
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels May 22, 2023
@findleyr findleyr modified the milestones: gopls/v0.14.0, gopls/v0.15.0 Oct 9, 2023
@findleyr findleyr self-assigned this Jan 6, 2024
@findleyr
Copy link
Member Author

findleyr commented Jan 6, 2024

This was fixed by https://go.dev/cl/551295.

@findleyr findleyr closed this as completed Jan 6, 2024
@golang golang locked and limited conversation to collaborators Jan 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@findleyr findleyr

Labels
FrozenDueToAge gopls/metadata Issues related to metadata loading in gopls gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.15.0
Development

No branches or pull requests
2 participants
@gopherbot @findleyr