Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: deprecate support for Go 1.16, Go 1.17 #60341

Closed
findleyr opened this issue May 22, 2023 · 1 comment
Closed

x/tools/gopls: deprecate support for Go 1.16, Go 1.17 #60341

findleyr opened this issue May 22, 2023 · 1 comment
Assignees
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@findleyr
Copy link
Contributor

We should surface a deprecation notice for Go 1.16 and Go 1.17 in gopls@v0.12.0, which is going out soon.

Per our documented support policy, we nominally support using gopls with the last 4 Go releases (notably longer than the 2 releases supported by Go itself). Note that we want to eventually narrow that support window (#50825), but will probably wait for the forward compatibility proposal before doing so.

Our next major release (v0.13.0) is likely to be at or around the Go 1.21 release, at which point the four previous major versions will be Go 1.18-21. Furthermore, survey results indicate only a tiny fraction of users are still on 1.17. Therefore, I think it is prudent to surface this deprecation notice now, and remove support in gopls@v0.13.0.

This also means that once we cut the v0.12.0 release in gopls, we can start using all the great new features of Go 1.18!

CC @adonovan

@findleyr findleyr added this to the gopls/v0.12.0 milestone May 22, 2023
@findleyr findleyr self-assigned this May 22, 2023
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels May 22, 2023
@gopherbot
Copy link

Change https://go.dev/cl/496881 mentions this issue: gopls: deprecate support for Go 1.16 and 1.17, update warnings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

2 participants