Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/ssa: TestTypeparamTest failing with go1.19 #60312

Closed
adonovan opened this issue May 19, 2023 · 5 comments
Closed

x/tools/go/ssa: TestTypeparamTest failing with go1.19 #60312

adonovan opened this issue May 19, 2023 · 5 comments
Assignees
@timothy-king
Labels
Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@adonovan
Copy link
Member 

xtools$ go1.19 test ./go/ssa -run=TestTypeparamTest
panic: variadic parameter must be of unnamed slice type

goroutine 232 [running]:
go/types.NewSignatureType(0x0, {0x0, 0x0, 0x0}, {0x0, 0x0, 0x0}, 0x14000690948, 0x140006905e8, 0x1)
	/Users/adonovan/sdk/go1.19/src/go/types/signature.go:53 +0x2a0
golang.org/x/tools/internal/typeparams.NewSignatureType(...)
	/Users/adonovan/w/xtools/internal/typeparams/typeparams_go118.go:55
golang.org/x/tools/go/ssa.(*subster).signature(0x104c665e0?, 0x14000169440)
	/Users/adonovan/w/xtools/go/ssa/subst.go:401 +0xd8
golang.org/x/tools/go/ssa.(*subster).typ(0x14000142de0, {0x104cbfc30?, 0x14000169440?})
	/Users/adonovan/w/xtools/go/ssa/subst.go:132 +0x540
golang.org/x/tools/go/ssa.(*Function).typ(...)
	/Users/adonovan/w/xtools/go/ssa/func.go:43
golang.org/x/tools/go/ssa.(*Function).typeOf(0x14000151200, {0x104cc05f0, 0x1400017c020})
	/Users/adonovan/w/xtools/go/ssa/func.go:36 +0x50
golang.org/x/tools/go/ssa.(*Function).instanceType(0x14000151200, 0x1400017c020)
	/Users/adonovan/w/xtools/go/ssa/func.go:52 +0x70
golang.org/x/tools/go/ssa.(*builder).expr0(0x14000427dd0, 0x14000151200, {0x104cc05f0?, 0x1400017c020?}, {0x2, {0x104cbfc30, 0x14000169440}, {0x0, 0x0}})
	/Users/adonovan/w/xtools/go/ssa/builder.go:791 +0x1b20
golang.org/x/tools/go/ssa.(*builder).expr(0x14000427198?, 0x14000151200, {0x104cc05f0?, 0x1400017c020?})
	/Users/adonovan/w/xtools/go/ssa/builder.go:623 +0x12c
golang.org/x/tools/go/ssa.(*builder).setCallFunc(0x104fc85b8?, 0x80?, 0x140004be000?, 0x1400014d440)
	/Users/adonovan/w/xtools/go/ssa/builder.go:1040 +0x2f4
golang.org/x/tools/go/ssa.(*builder).setCall(0x14000142de0?, 0x14000151200?, 0x14000168d80, 0x1400014d440)
	/Users/adonovan/w/xtools/go/ssa/builder.go:1119 +0x2c
golang.org/x/tools/go/ssa.(*builder).expr0(0x14000427dd0, 0x14000151200, {0x104cc02f0?, 0x14000168d80?}, {0x7, {0x104cbfc58, 0x140001ae840}, {0x0, 0x0}})
	/Users/adonovan/w/xtools/go/ssa/builder.go:702 +0x209c
golang.org/x/tools/go/ssa.(*builder).expr(0x14000170fc0?, 0x14000151200, {0x104cc02f0?, 0x14000168d80?})
	/Users/adonovan/w/xtools/go/ssa/builder.go:623 +0x12c
golang.org/x/tools/go/ssa.(*builder).assign(0x14000427658?, 0x14000151200?, {0x104cc1130?, 0x140001431d0}, {0x104cc02f0?, 0x14000168d80?}, 0x0?, 0x140004276b0)
	/Users/adonovan/w/xtools/go/ssa/builder.go:596 +0x2fc
golang.org/x/tools/go/ssa.(*builder).assignStmt(0xec1a3bc95d218727?, 0x14000151200, {0x140001ae580, 0x1, 0x14000170fc3?}, {0x140001ae5a0, 0x1, 0x0?}, 0x0)
	/Users/adonovan/w/xtools/go/ssa/builder.go:1204 +0x1bc
golang.org/x/tools/go/ssa.(*builder).stmt(0x14000427918?, 0x14000151200, {0x104cc0170?, 0x14000168dc0?})
	/Users/adonovan/w/xtools/go/ssa/builder.go:2160 +0xd94
golang.org/x/tools/go/ssa.(*builder).stmtList(0x140004be000?, 0x104cc2580?, {0x140001ae5b0?, 0x1, 0x14000427948?})
	/Users/adonovan/w/xtools/go/ssa/builder.go:944 +0x68
golang.org/x/tools/go/ssa.(*builder).stmt(0x14000151200?, 0x14000151200, {0x104cc0290?, 0x1400016ba10?})
	/Users/adonovan/w/xtools/go/ssa/builder.go:2256 +0xd34
golang.org/x/tools/go/ssa.(*builder).buildFunctionBody(0x14000150d80?, 0x14000151200)
	/Users/adonovan/w/xtools/go/ssa/builder.go:2370 +0x3c0
golang.org/x/tools/go/ssa.(*builder).buildFunction(0x104b38a10?, 0x14000151200)
	/Users/adonovan/w/xtools/go/ssa/builder.go:2305 +0x30
golang.org/x/tools/go/ssa.(*builder).buildCreated(0x14000427dd0)
	/Users/adonovan/w/xtools/go/ssa/builder.go:2392 +0x28
golang.org/x/tools/go/ssa.(*Package).build(0x1400014cf00)
	/Users/adonovan/w/xtools/go/ssa/builder.go:2585 +0xaec
sync.(*Once).doSlow(0x1400030b070?, 0x104b1bfd0?)
	/Users/adonovan/sdk/go1.19/src/sync/once.go:74 +0x104
sync.(*Once).Do(...)
	/Users/adonovan/sdk/go1.19/src/sync/once.go:65
golang.org/x/tools/go/ssa.(*Package).Build(...)
	/Users/adonovan/w/xtools/go/ssa/builder.go:2456
golang.org/x/tools/go/ssa.(*Program).Build.func1(0x38?)
	/Users/adonovan/w/xtools/go/ssa/builder.go:2441 +0x54
created by golang.org/x/tools/go/ssa.(*Program).Build
	/Users/adonovan/w/xtools/go/ssa/builder.go:2440 +0x180
FAIL	golang.org/x/tools/go/ssa	0.162s
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label May 19, 2023
@gopherbot gopherbot added this to the Unreleased milestone May 19, 2023
@bcmills
Copy link
Contributor

bcmills commented May 20, 2023

I don't see any such failures on the dashboard. Try go1.19.9 (the latest patch release) instead?

@bcmills bcmills added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label May 20, 2023
@bcmills
Copy link
Contributor

bcmills commented May 20, 2023

Looks like that was #54946.

@bcmills bcmills removed the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label May 20, 2023
@bcmills
Copy link
Contributor

bcmills commented May 20, 2023

Duplicate of #54946

@bcmills bcmills marked this as a duplicate of #54946 May 20, 2023
@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale May 20, 2023
@adonovan
Copy link
Member Author

I had vaguely assumed the dl tool would give me the latest minor release of go1.19 including any backported fixes. Sorry for the noise.

@bcmills
Copy link
Contributor

bcmills commented May 20, 2023

That is a significant motivating factor behind #57631. 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timothy-king timothy-king

Labels
Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@timothy-king @bcmills @adonovan @gopherbot