Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

database/sql: sql.RawBytes is not compatible with contexts [1.20 backport] #60308

Closed
gopherbot opened this issue May 19, 2023 · 7 comments
Closed

database/sql: sql.RawBytes is not compatible with contexts [1.20 backport] #60308

gopherbot opened this issue May 19, 2023 · 7 comments
Labels
CherryPickCandidate Used during the release process for point releases
Milestone
Go1.20.8

Comments

@gopherbot
Copy link

@rsc requested issue #60304 to be considered for backport to the next 1.20 minor release.

@gopherbot please backport Go 1.20 and Go 1.19
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label May 19, 2023
@gopherbot gopherbot mentioned this issue May 19, 2023
Closed
@gopherbot gopherbot added this to the Go1.20.5 milestone May 19, 2023
@mdempsky
Copy link
Member

Release planning suggests waiting for the CL to ship in 1.21 RC1 before backporting.

@bradfitz
Copy link
Contributor

Will also need https://go-review.googlesource.com/c/go/+/498398 it turns out.

@gopherbot gopherbot modified the milestones: Go1.20.5, Go1.20.6 Jun 6, 2023
@dmitshur
Copy link
Contributor

Release planning suggests waiting for the CL to ship in 1.21 RC1 before backporting.

The report in issue #60932 looks relevant to the review of this cherry-pick candidate.

@dmitshur dmitshur added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Jun 28, 2023
@rsc
Copy link
Contributor

rsc commented Jul 5, 2023

There has been enough uncertainty around the database/sql change that, while I think it is appropriate for Go 1.21, I am inclined to not backport it to Go 1.20.

@dmitshur dmitshur removed the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Jul 5, 2023
@gopherbot gopherbot modified the milestones: Go1.20.6, Go1.20.7 Jul 11, 2023
@cherrymui cherrymui added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Jul 12, 2023
@dmitshur
Copy link
Contributor

@cherrymui What information do you think this is waiting for? I think given the new information, we can make a decision (not to backport this), like in #60307.

@cherrymui
Copy link
Member

I think we decided to give it some time to soak, wait for 1.21 release then decide later (for 1.20 backport only, definitely not enough time for 1.19 backport.)

@gopherbot gopherbot modified the milestones: Go1.20.7, Go1.20.8 Aug 1, 2023
@dmitshur dmitshur removed the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Aug 15, 2023
@dmitshur
Copy link
Contributor

We've considered the information available by now and have decided not to proceed with this backport. The fix is available in Go 1.21.0 onwards, but the risk of backporting doesn't outweigh the benefits.

@dmitshur dmitshur closed this as not planned Won't fix, can't repro, duplicate, stale Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickCandidate Used during the release process for point releases
Projects
None yet
Milestone
Go1.20.8
Development

No branches or pull requests
6 participants
@bradfitz @mdempsky @rsc @dmitshur @gopherbot @cherrymui