Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: re-enable memory-based layer of filecache #60303

Closed
adonovan opened this issue May 19, 2023 · 1 comment
Closed

x/tools/gopls: re-enable memory-based layer of filecache #60303

adonovan opened this issue May 19, 2023 · 1 comment
Assignees
@adonovan
Labels
gopls/performance Issues related to gopls performance (CPU, memory, etc). gopls Issues related to the Go language server, gopls. release-blocker Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.12.0

Comments

@adonovan
Copy link
Member

adonovan commented May 19, 2023 •
edited

https://go.dev/cl/495800 disabled the memory cache so we can stress the new file cache implementation for a while. Don't forget to re-enable it before the release.
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels May 19, 2023
@adonovan adonovan added this to the gopls/v0.12.0 milestone May 19, 2023
@gopherbot gopherbot modified the milestones: gopls/v0.12.0, Unreleased May 19, 2023
@adonovan adonovan added release-blocker gopls/performance Issues related to gopls performance (CPU, memory, etc). labels May 19, 2023
@adonovan adonovan self-assigned this May 19, 2023
@suzmue suzmue modified the milestones: Unreleased, gopls/v0.12.0 May 22, 2023
@adonovan
Copy link
Member Author

Fixed by https://go.dev/cl/497955

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adonovan adonovan

Labels
gopls/performance Issues related to gopls performance (CPU, memory, etc). gopls Issues related to the Go language server, gopls. release-blocker Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.12.0
Development

No branches or pull requests
3 participants
@adonovan @suzmue @gopherbot