Skip to content

x/vulndb: improve internal/proxy package #60275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tatianab opened this issue May 17, 2023 · 3 comments
Open

x/vulndb: improve internal/proxy package #60275

tatianab opened this issue May 17, 2023 · 3 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Milestone
vuln/unplanned

Comments

@tatianab
Copy link

  • Refactor to make it easier to test
  • Add unit tests
  • Cache proxy lookups
@tatianab tatianab added the vulncheck or vulndb Issues for the x/vuln or x/vulndb repo label May 17, 2023
@tatianab tatianab self-assigned this May 17, 2023
@gopherbot gopherbot modified the milestones: Unreleased, vuln/unplanned May 17, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/497036 mentions this issue: internal/proxy: add unit tests for proxy package

gopherbot pushed a commit to golang/vulndb that referenced this issue May 23, 2023
@tatianab
internal/proxy: add unit tests for proxy package
24c92d8 
Adds additional unit tests for the proxy package.

For golang/go#60275

Change-Id: I4706cb2c0e3b54db27241eb19177bd48d2683fba
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/497036
Reviewed-by: Damien Neil <dneil@google.com>
Run-TryBot: Tatiana Bradley <tatianabradley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/506316 mentions this issue: internal/proxy: cache proxy lookups

gopherbot pushed a commit to golang/vulndb that referenced this issue Jun 26, 2023
@tatianab
internal/proxy: cache proxy lookups
4a0a847 
Cache proxy lookups with a simple in-memory cache.

For golang/go#60275

Change-Id: I24016f3d78b7fb70d452db5286abae0e4e71ba5a
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/506316
Reviewed-by: Damien Neil <dneil@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Tatiana Bradley <tatianabradley@google.com>
@tatianab tatianab removed their assignment Mar 6, 2025
@JunyangShao
Copy link
Contributor

@golang/vulndb Should we close this issue?

@JunyangShao JunyangShao added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Projects
None yet
Milestone
vuln/unplanned
Development

No branches or pull requests
3 participants
@tatianab @gopherbot @JunyangShao