-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/gopls: test failures due to rename
permission errors on linux-amd64-wsl
#60266
Comments
(Extracted from #56194 (comment) and #55324 (comment).) @qmuntal, I'm surprised to see these errors in the WSL environment. I know that renaming is non-atomic (and often fails) on Windows via the Win32 APIs, but I would expect WSL to provide POSIX |
Found new dashboard test flakes for:
2023-05-10 11:33 linux-amd64-wsl tools@005fa64f go@46847c63 x/tools/gopls/internal/regtest/misc.TestRenamePackage_NestedModule (log)
2023-05-10 11:33 linux-amd64-wsl tools@005fa64f go@46847c63 x/tools/gopls/internal/regtest/misc.TestRenamePackage_DuplicateBlankImport (log)
2023-05-10 11:33 linux-amd64-wsl tools@005fa64f go@46847c63 x/tools/gopls/internal/regtest/misc.TestRenamePackage_IntermediateTestVariant (log)
2023-05-10 11:33 linux-amd64-wsl tools@005fa64f go@8e8303e1 x/tools/gopls/internal/regtest/misc.TestRenamePackageWithDifferentDirectoryPath (log)
2023-05-10 11:33 linux-amd64-wsl tools@005fa64f go@8e8303e1 x/tools/gopls/internal/regtest/misc.TestRenamePackage_Tests (log)
2023-05-10 11:33 linux-amd64-wsl tools@005fa64f go@8e8303e1 x/tools/gopls/internal/regtest/misc.TestRenamePackage_Nesting (log)
2023-05-10 11:33 linux-amd64-wsl tools@005fa64f go@57e31898 x/tools/gopls/internal/regtest/misc.TestRenamePackageWithDifferentDirectoryPath (log)
2023-05-10 11:33 linux-amd64-wsl tools@005fa64f go@57e31898 x/tools/gopls/internal/regtest/misc.TestRenamePackage_Tests (log)
2023-05-10 11:33 linux-amd64-wsl tools@005fa64f go@57e31898 x/tools/gopls/internal/regtest/misc.TestRenamePackage_DuplicateBlankImport (log)
|
One possible workaround would be to move the Windows+macOS version of robustio.Rename to a common function called renameRetry and have the Windows+macOS Rename delegate to it; and on Linux, delegate to it if the rename system call fails and |
Don't know how WSL is implemented, but I would expect
If this end up being a host issue, then using robustio won't help. Lets wait till |
Found new dashboard test flakes for:
2023-05-10 11:33 linux-amd64-wsl tools@005fa64f go@dc0179bf x/tools/gopls/internal/regtest/misc.TestRenamePackageWithConflicts (log)
2023-05-10 11:33 linux-amd64-wsl tools@005fa64f go@dc0179bf x/tools/gopls/internal/regtest/misc.TestRenameFileFromEditor (log)
2023-05-12 22:29 linux-amd64-wsl tools@1c9fe3f8 go@268d2f7c x/tools/gopls/internal/regtest/misc.TestRenamePackage (log)
2023-05-12 22:29 linux-amd64-wsl tools@1c9fe3f8 go@949d0f4f x/tools/gopls/internal/regtest/misc.TestRenamePackageWithDifferentDirectoryPath (log)
2023-05-12 22:29 linux-amd64-wsl tools@1c9fe3f8 go@949d0f4f x/tools/gopls/internal/regtest/misc.TestRenamePackage_DuplicateImport (log)
2023-05-12 22:29 linux-amd64-wsl tools@1c9fe3f8 go@1b896bff x/tools/gopls/internal/regtest/misc.TestRenamePackageWithConflicts (log)
2023-05-12 22:29 linux-amd64-wsl tools@1c9fe3f8 go@1b896bff x/tools/gopls/internal/regtest/misc.TestRenamePackageWithAlias (log)
2023-05-12 22:29 linux-amd64-wsl tools@1c9fe3f8 go@1b896bff x/tools/gopls/internal/regtest/misc.TestRenamePackage_Tests (log)
2023-05-12 22:29 linux-amd64-wsl tools@1c9fe3f8 go@e9f1bb96 x/tools/gopls/internal/regtest/misc.TestRenamePackageWithDifferentDirectoryPath (log)
|
Found new dashboard test flakes for:
2023-05-15 18:37 linux-amd64-wsl tools@35fe77a6 go@4481042c x/tools/gopls/internal/regtest/misc.TestRenamePackageWithAlias (log)
2023-05-15 18:37 linux-amd64-wsl tools@35fe77a6 go@4481042c x/tools/gopls/internal/regtest/misc.TestRenamePackageWithDifferentDirectoryPath (log)
2023-05-15 18:37 linux-amd64-wsl tools@35fe77a6 go@4481042c x/tools/gopls/internal/regtest/misc.TestRenamePackage (log)
2023-05-15 18:46 linux-amd64-wsl tools@5eb1eb93 go@afbe1019 x/tools/gopls/internal/regtest/misc.TestRenamePackage (log)
2023-05-15 18:46 linux-amd64-wsl tools@5eb1eb93 go@afbe1019 x/tools/gopls/internal/regtest/misc.TestRenamePackage_Tests (log)
2023-05-15 18:46 linux-amd64-wsl tools@5eb1eb93 go@afbe1019 x/tools/gopls/internal/regtest/misc.TestRenamePackage_DuplicateBlankImport (log)
2023-05-15 19:46 linux-amd64-wsl tools@12a0517a go@7213f2e7 x/tools/gopls/internal/regtest/misc.TestReturnErrorWhenUsingNonGoFiles (log)
2023-05-15 19:46 linux-amd64-wsl tools@12a0517a go@7213f2e7 x/tools/gopls/internal/regtest/misc.TestRenamePackageWithAlias (log)
2023-05-15 19:46 linux-amd64-wsl tools@12a0517a go@7213f2e7 x/tools/gopls/internal/regtest/misc.TestRenamePackageWithDifferentDirectoryPath (log)
|
Found new dashboard test flakes for:
2023-05-15 19:46 linux-amd64-wsl tools@12a0517a go@ff3aefba x/tools/gopls/internal/regtest/misc.TestRenamePackage (log)
2023-05-15 19:46 linux-amd64-wsl tools@12a0517a go@ff3aefba x/tools/gopls/internal/regtest/misc.TestRenameFileFromEditor (log)
2023-05-15 22:02 linux-amd64-wsl tools@a13793e3 go@04e24728 x/tools/gopls/internal/regtest/misc.TestRenamePackage_Tests (log)
2023-05-15 22:02 linux-amd64-wsl tools@a13793e3 go@7213f2e7 x/tools/gopls/internal/regtest/misc.TestRenamePackageWithDifferentDirectoryPath (log)
2023-05-15 22:02 linux-amd64-wsl tools@a13793e3 go@7213f2e7 x/tools/gopls/internal/regtest/misc.TestRenameFileFromEditor (log)
2023-05-15 22:02 linux-amd64-wsl tools@a13793e3 go@7213f2e7 x/tools/gopls/internal/regtest/misc.TestRenamePackage_Nesting (log)
2023-05-16 01:58 linux-amd64-wsl tools@7f203f0c go@afbe1019 x/tools/gopls/internal/regtest/misc.TestRenamePackageWithAlias (log)
|
Found new dashboard test flakes for:
2023-05-16 03:26 linux-amd64-wsl tools@9dcd3d5d go@afbe1019 x/tools/gopls/internal/regtest/misc.TestRenamePackage (log)
2023-05-16 03:26 linux-amd64-wsl tools@9dcd3d5d go@afbe1019 x/tools/gopls/internal/regtest/misc.TestRenamePackage_Tests (log)
2023-05-16 03:26 linux-amd64-wsl tools@9dcd3d5d go@afbe1019 x/tools/gopls/internal/regtest/misc.TestRenamePackage_DuplicateBlankImport (log)
2023-05-16 16:48 linux-amd64-wsl tools@19d700c6 go@5534f044 x/tools/gopls/internal/regtest/misc.TestRenamePackageWithAlias (log)
2023-05-16 16:48 linux-amd64-wsl tools@19d700c6 go@5534f044 x/tools/gopls/internal/regtest/misc.TestRenamePackage_NestedModule (log)
2023-05-16 16:48 linux-amd64-wsl tools@19d700c6 go@5534f044 x/tools/gopls/internal/regtest/misc.TestRenamePackage_Nesting (log)
2023-05-16 17:05 linux-amd64-wsl tools@f4e8a711 go@5534f044 x/tools/gopls/internal/regtest/misc.TestRenamePackageWithConflicts (log)
2023-05-16 17:21 linux-amd64-wsl tools@e5c8d4db go@afbe1019 x/tools/gopls/internal/regtest/misc.TestRenamePackageWithConflicts (log)
|
Found new dashboard test flakes for:
2023-05-16 17:21 linux-amd64-wsl tools@e5c8d4db go@e738f130 x/tools/gopls/internal/regtest/misc.TestReturnErrorWhenUsingNonGoFiles (log)
2023-05-16 17:21 linux-amd64-wsl tools@e5c8d4db go@e738f130 x/tools/gopls/internal/regtest/misc.TestRenameFileFromEditor (log)
2023-05-16 17:21 linux-amd64-wsl tools@e5c8d4db go@e738f130 x/tools/gopls/internal/regtest/misc.TestRenamePackage_Nesting (log)
2023-05-16 17:22 linux-amd64-wsl tools@a0593829 go@6fc5e7d4 x/tools/gopls/internal/regtest/misc.TestRenamePackageWithConflicts (log)
2023-05-16 17:22 linux-amd64-wsl tools@a0593829 go@6fc5e7d4 x/tools/gopls/internal/regtest/misc.TestRenameFileFromEditor (log)
2023-05-16 17:22 linux-amd64-wsl tools@a0593829 go@6fc5e7d4 x/tools/gopls/internal/regtest/misc.TestRenamePackage_Tests (log)
2023-05-16 17:22 linux-amd64-wsl tools@a0593829 go@470c6f64 x/tools/gopls/internal/regtest/misc.TestRenamePackageWithConflicts (log)
2023-05-16 17:22 linux-amd64-wsl tools@a0593829 go@470c6f64 x/tools/gopls/internal/regtest/misc.TestRenameFileFromEditor (log)
2023-05-16 17:22 linux-amd64-wsl tools@a0593829 go@470c6f64 x/tools/gopls/internal/regtest/misc.TestRenamePackage_Tests (log)
2023-05-16 19:01 linux-amd64-wsl tools@522243a7 go@4cf79e47 x/tools/gopls/internal/regtest/misc.TestRenamePackage (log)
|
Found new dashboard test flakes for:
2023-05-16 19:01 linux-amd64-wsl tools@522243a7 go@6fc5e7d4 x/tools/gopls/internal/regtest/misc.TestRenamePackageWithAlias (log)
2023-05-16 19:01 linux-amd64-wsl tools@522243a7 go@6fc5e7d4 x/tools/gopls/internal/regtest/misc.TestRenamePackage_Tests (log)
2023-05-16 19:01 linux-amd64-wsl tools@522243a7 go@6fc5e7d4 x/tools/gopls/internal/regtest/misc.TestRenamePackage_Nesting (log)
2023-05-16 20:18 linux-amd64-wsl tools@743372f5 go@099f5a98 x/tools/gopls/internal/regtest/misc.TestRenamePackageWithAlias (log)
2023-05-16 20:18 linux-amd64-wsl tools@743372f5 go@099f5a98 x/tools/gopls/internal/regtest/misc.TestRenamePackageWithDifferentDirectoryPath (log)
2023-05-16 20:18 linux-amd64-wsl tools@743372f5 go@099f5a98 x/tools/gopls/internal/regtest/misc.TestRenamePackage (log)
2023-05-16 20:18 linux-amd64-wsl tools@743372f5 go@522be4e0 x/tools/gopls/internal/regtest/misc.TestRenamePackageWithAlias (log)
2023-05-16 20:18 linux-amd64-wsl tools@743372f5 go@522be4e0 x/tools/gopls/internal/regtest/misc.TestRenamePackage (log)
2023-05-16 20:18 linux-amd64-wsl tools@743372f5 go@522be4e0 x/tools/gopls/internal/regtest/misc.TestRenamePackage_Tests (log)
|
Timed out in state WaitingForInfo. Closing. (I am just a bot, though. Please speak up if this is a mistake or you have the requested information.) |
The last update |
Found new dashboard test flakes for:
2023-05-16 20:18 linux-amd64-wsl tools@743372f5 go@7240d7e9 x/tools/gopls/internal/regtest/misc.TestRenamePackageWithConflicts (log)
2023-05-16 20:18 linux-amd64-wsl tools@743372f5 go@7240d7e9 x/tools/gopls/internal/regtest/misc.TestRenamePackageWithDifferentDirectoryPath (log)
2023-05-16 20:18 linux-amd64-wsl tools@743372f5 go@7240d7e9 x/tools/gopls/internal/regtest/misc.TestRenamePackage_Tests (log)
2023-05-16 20:18 linux-amd64-wsl tools@743372f5 go@e738f130 x/tools/gopls/internal/regtest/misc.TestRenamePackageWithAlias (log)
2023-05-16 20:18 linux-amd64-wsl tools@743372f5 go@e738f130 x/tools/gopls/internal/regtest/misc.TestRenamePackage_TestVariant (log)
2023-05-16 20:18 linux-amd64-wsl tools@743372f5 go@e738f130 x/tools/gopls/internal/regtest/misc.TestRenamePackage_Nesting (log)
|
(attn @golang/wsl; CC @findleyr @adonovan)
The text was updated successfully, but these errors were encountered: